Граф коммитов

283 Коммитов

Автор SHA1 Сообщение Дата
Peter deHaan c60a4e98e1 adding styling to the h3 tag in a header so it uses the correct font-family 2014-02-12 14:41:02 -08:00
Peter deHaan 42fbf0750f Merge remote-tracking branch 'upstream/master' into lint-take-2 2014-02-12 09:55:08 -08:00
Shane Tomlinson 04d8322c50 Fix the intermittent failing front end tests.
The session tests attach a test "channel". "channel" cannot be cleared, and since Session is a singleton, the test channel never goes away. in fxa-clien.js->signIn, we attempt to send a message to a channel without a send function.

fixes #516
2014-02-12 15:20:33 +00:00
Shane Tomlinson 9aef25eb6f Update the fxa-client tests to check for lang 2014-02-12 10:26:46 +00:00
Zachary Carter 1a7dbf40a8 update fxa-client and add accept-language header based on browser language 2014-02-12 10:17:08 +00:00
Shane Tomlinson 346a66e1da Merge pull request #508 from mozilla/issue-507-graphic-touch-up
updated intro graphics

easiest review ever. r+
2014-02-12 10:13:00 +00:00
Zach Carter 793cec0675 Merge pull request #506 from mozilla/issue-460-service
Ensure the `service` and `redirectTo` URL search parameters make it to the fxa-js-client.
2014-02-11 17:54:36 -08:00
Peter deHaan d0541bc867 retighten up the linting rules 2014-02-11 11:48:00 -08:00
johngruen 823e596049 updated intro graphics 2014-02-11 13:33:06 -05:00
Shane Tomlinson 48a3006988 Ensure the `service` and `redirectTo` URL search parameters make it to the fxa-js-client.
* Pick `service` and `redirectTo` out of the URL search parameters on startup, add it to Session.
* Add sinon.js to ensure the fxa-js-client recieves the `service` parameter when expected.
* Update the views to get `service` from Session instead of the URL.
* Add two new test suites, complete_sign_up and reset_password_complete.
* Check whether service and redirectTo make it to the complete screens.
* Check whether the expected backend calls are made when expected.
* Hook up the real translator in the tests so string interpolation can be tested.

NOTE: I updated bower to use a specific version of sinon because the official sinon.js package in bower is not set up to correctly handle amd installs and does not give spy functionality.
2014-02-11 15:04:59 +00:00
Shane Tomlinson 66de7e2c4d Merge pull request #503 from pdehaan/issue-500
rename image, delete unused image

Looks good to me, tested using a local python server and the images still show. I'm happy.

r+
2014-02-11 10:37:29 +00:00
Zach Carter e4542cafbc Merge pull request #479 from mozilla/issue-401-resend-all-the-time
Fix the confirmation emails being sent on every click in the confirmation form.
2014-02-10 18:08:50 -08:00
Peter deHaan a3331cbd7c rename image, delete unused image 2014-02-10 14:08:59 -08:00
johngruen 67be94417d added fixes to intro and manage, legal pages, and responsive views 2014-02-10 11:36:05 -05:00
Shane Tomlinson 828a15dd33 Fix the confirmation emails being sent on every click in the confirmation form.
fixes #401
2014-02-10 15:22:35 +00:00
Shane Tomlinson 1274f8f7c5 Add helpers.js with requiresFocus, use that in form.js when checking for focus. 2014-02-07 21:19:06 +00:00
Shane Tomlinson f3cf8a98e3 fix the show button border to handle the keyboard accessibility updates 2014-02-07 21:08:08 +00:00
johngruen 62f45f8802 tweaked tooltip spacing to avoid overlap 2014-02-07 21:05:37 +00:00
Shane Tomlinson 322105e0e2 Add red outlines to form elements when invalid.
* Remove the outline as soon as the user changes the value of the field.

fixes #435
2014-02-07 21:03:48 +00:00
Shane Tomlinson c165b1afb4 Generic form validation, support for tooltips above and below the input elemnts & cleanup.
* Add tooltip/tooltip-below classes to tooltip containers.
* Add generic form validation in form.js with the ability for descendent views to override using strategy methods.
* MOAR TESTS!
2014-02-07 21:02:44 +00:00
Shane Tomlinson cede5ece0e Let's get us some tooltips!
* Create a new "base" View - FormView - useful for doing form validation.
* A FormView must provide three functions - isFormValid, showValidationErrors and submitForm.
* When a form element is invalid, it's containing .form-row recieves a title which is displayed as a tooltip.
* Change all Views that use forms to be a FormView
* Add a ton of tests.

fixes #252
2014-02-07 20:56:06 +00:00
Nick Chapman b4f62b5cb1 Merge pull request #480 from mozilla/issue-436-tos-pp-back
Only show the back button in the tos/pp agreements if the user can go ba...
2014-02-07 11:57:19 -08:00
Shane Tomlinson 1fb4c692e3 Simplify by moving the window.scrollTo into router.js->showView 2014-02-07 17:22:37 +00:00
Shane Tomlinson 5612b6f40b Scroll to the top of the tos/pp pages after render
fixes #437
2014-02-07 17:14:06 +00:00
Shane Tomlinson 4becf7d4b7 Fix the failing tests.
* Focus can only be checked for if the window is currently in focus.
* .error is used by mocha to indicate errors. Namespace all checks for .error to the view.
* Up time timeout for mocha to 5seconds and the intern to 120seconds.
* Add a unit test for signing in with a non-existent user (see https://github.com/mozilla/fxa-js-client/issues/74)

fixes #489
2014-02-07 17:05:04 +00:00
Nick Chapman fa2c93e1b5 Merge pull request #477 from mozilla/issue-459-ring-around-coppa
Remove the focus ring around the COPPA year.
2014-02-06 14:40:56 -08:00
Shane Tomlinson b54c108d9c Add the missing aria-controls target
* in change_password.mustache and delete_account.mustache
2014-02-06 17:49:26 +00:00
Shane Tomlinson 0b273034f6 Only show the back button in the tos/pp agreements if the user can go back.
fixes #436
2014-02-06 15:43:55 +00:00
Shane Tomlinson f7e52f50ab Remove the focus ring around the COPPA year.
fixes #459
2014-02-06 13:23:12 +00:00
Shane Tomlinson 1ee5e1c8f0 Keyboard accessible password show buttons!
fixes #414
2014-02-06 12:56:29 +00:00
Shane Tomlinson f027164183 Only show the "must be at least 8 characters" text on the /signup page when the user focuses the password element.
The help text for change-password and complete-reset-password are always displayed because there are two password inputs.

fixes #382
2014-02-06 12:56:29 +00:00
Shane Tomlinson f56793a679 Re-focus the password field after clicking the show button.
fixes #457
2014-02-06 12:56:29 +00:00
Peter deHaan a91eba3000 removing the password length notice on the sign_in page 2014-02-05 13:13:43 -08:00
Shane Tomlinson 72ec5aa4bd Merge pull request #470 from pdehaan/colormebadd
cleaning up the colors. Fixes #468

thanks for the colab effort @pdehaan and @johngruen!

r+
2014-02-05 10:15:09 +00:00
Shane Tomlinson 48b968f48e Merge pull request #466 from pdehaan/button-cursor
Adding hand pointer cursor to the enabled button states. Fixes #465

works beautifully, thanks @pdehaan!

r+
2014-02-05 10:11:14 +00:00
Peter deHaan f201f46759 cleaning up the colors. Fixes #468 2014-02-04 21:55:43 -08:00
Zachary Carter 4f5acebc0c Associate errors from the auth server by canonical number
This decouples the strings we use to describe errors from the auth server
from the error messages they may use.
2014-02-04 11:47:14 -08:00
Peter deHaan 46fe5124f8 Adding hand pointer cursor to the enabled button states. Fixes #465 2014-02-04 10:59:27 -08:00
Shane Tomlinson 1730b2c3c0 Add a file with a list of strings that are not yet in content that can be extracted for translation. 2014-02-04 13:14:39 +00:00
Shane Tomlinson a0e089c380 Ensure the translated messages array is at least 2 long before plucking the first item in the list. Trim translated strings. 2014-02-04 11:09:05 +00:00
Shane Tomlinson 0755705dcf Enable translations to handle po2json output.
* Use the format specified in 62e17c999a/test/fixtures/pl.json (L23-L27)
* Fix jshint errors
2014-02-04 10:43:27 +00:00
Shane Tomlinson ca1ee383e8 Rename `gettext` to `t` 2014-02-04 10:43:26 +00:00
Shane Tomlinson 32f0876157 Start to automate the l10n process.
* Wrap embedded strings in `gettext` calls for string extraction.
* Adding the first two pot files.
* Use a custom grunt-po2json to create the json files with names that we want.  (PR submitted to original author)
* Start to set up grunt to compile .json files from .po files

issue #14
2014-02-04 10:43:26 +00:00
Nick Chapman 1c5fd6de46 Merge pull request #454 from mozilla/issue-449-contact-link
Open "contact us" link in a new tab.
2014-02-04 00:11:56 -08:00
Nick Chapman dbc0559f08 Merge pull request #453 from mozilla/more-css-updates
CSS cleanup
2014-02-04 00:09:49 -08:00
John Gruen 3079767bb6 Update reset_password.mustache 2014-02-03 11:22:20 -05:00
John Gruen 75cffa7959 Update reset_password.mustache
Original syntax made no sense
2014-02-03 10:47:20 -05:00
Shane Tomlinson 65fc1769e2 CSS cleanup
* Rename fireFox*.png to firefox*.png
* Change all embedded image urls to use `url(/images/..`
* Alphebetize all properties.
* Fix & Remove duplicate transition commands.
* Fix tos/pp links both turning blue when hovering anywhere over the "By proceeding" text.
* Add :active/:focus states to the tos/pp links for keyboard accessibility

fixes #450
fixes #451
fixes #452
2014-02-03 13:07:34 +00:00
Peter deHaan 2ce637d82b Adding styling to the .success so it matches .error - Fixes #337 2014-02-03 12:57:37 +00:00
Shane Tomlinson e115b5f871 Open "contact us" link in a new tab.
issue #449

Still need to check whether the href is correct
2014-02-03 12:53:26 +00:00