fix(deps): update mocha and other dev deps

coverage/blanket.js

@@ -1,7 +0,0 @@
-var path = require('path');
-var srcDir = path.join(__dirname, '..', 'lib');
-
-require('blanket')({
-  // Only files that match the pattern will be instrumented
-  pattern: srcDir
-});

package.json

@@ -46,7 +46,7 @@
   "devDependencies": {
     "eslint-plugin-fxa": "git://github.com/mozilla/eslint-plugin-fxa.git#41504c9dd30e8b52900c15b524946aa0428aef95",
     "fxa-conventional-changelog": "1.1.0",
-    "grunt": "1.0.2",
+    "grunt": "1.0.3",
     "grunt-bump": "0.8.0",
     "grunt-conventional-changelog": "6.1.0",
     "grunt-copyright": "0.3.0",
@@ -54,13 +54,13 @@
     "grunt-nodemon": "0.4.2",
     "insist": "1.x",
     "load-grunt-tasks": "3.5.2",
-    "mocha": "3.5.3",
+    "mocha": "5.2.0",
     "nock": "8.2.2",
     "npmshrink": "1.0.1",
-    "nyc": "11.0.2",
+    "nyc": "13.1.0",
     "proxyquire": "1.8.0",
     "read": "1.0.7",
-    "sinon": "1.17.7",
+    "sinon": "7.0.0",
     "time-grunt": "1.4.0"
   }
 }

scripts/test-local.sh

@@ -11,7 +11,7 @@ if [ -z "$GLOB" ]; then
   GLOB="test/*.js test/routes/*.js test/db/*.js"
 fi
 
-DEFAULT_ARGS="-R spec --timeout 20000 --recursive"
+DEFAULT_ARGS="-R spec --timeout 20000 --recursive --exit"
 
 ./scripts/mocha-coverage.js $DEFAULT_ARGS $GLOB
 grunt lint copyright

test/auth_bearer.js

@@ -29,7 +29,7 @@ describe('authBearer', function() {
   beforeEach(function() {
     sandbox = sinon.sandbox.create();
 
-    sandbox.stub(dependencies['../../../lib/token'], 'verify', function() {
+    sandbox.stub(dependencies['../../../lib/token'], 'verify').callsFake(function() {
       return P.resolve({
         scope: ScopeSet.fromArray(['bar:foo', 'clients:write']),
         user: 'bar'
@@ -79,7 +79,7 @@ describe('authBearer', function() {
       sandbox.restore();
       sandbox = sinon.sandbox.create();
 
-      sandbox.stub(dependencies['../../../lib/token'], 'verify', function() {
+      sandbox.stub(dependencies['../../../lib/token'], 'verify').callsFake(function() {
         return P.reject(AppError.invalidToken());
       });
 

test/db/mysql.js

@@ -36,7 +36,7 @@ describe('db/mysql:', function() {
   beforeEach(function() {
     sandbox = sinon.sandbox.create();
 
-    sandbox.stub(dependencies['../../config'], 'get', function() {
+    sandbox.stub(dependencies['../../config'], 'get').callsFake(function() {
       return 'mock config.get result';
     });
     instances.logger = {
@@ -70,15 +70,15 @@ describe('db/mysql:', function() {
         end: nop,
         currentPatchLevel: dependencies['./patch'].level
       };
-      sandbox.stub(instances.patcher, 'connect', callback);
-      sandbox.stub(instances.patcher, 'patch', nop);
-      sandbox.stub(instances.patcher, 'end', callback);
-      sandbox.stub(process, 'exit', nop);
+      sandbox.stub(instances.patcher, 'connect').callsFake(callback);
+      sandbox.stub(instances.patcher, 'patch').callsFake(nop);
+      sandbox.stub(instances.patcher, 'end').callsFake(callback);
+      sandbox.stub(process, 'exit').callsFake(nop);
     });
 
     describe('readDbPatchLevel succeeds:', function() {
       beforeEach(function() {
-        sandbox.stub(instances.patcher, 'readDbPatchLevel', function(callback) {
+        sandbox.stub(instances.patcher, 'readDbPatchLevel').callsFake(function(callback) {
           callback();
         });
       });
@@ -167,7 +167,7 @@ describe('db/mysql:', function() {
       var result;
 
       beforeEach(function() {
-        sandbox.stub(instances.patcher, 'readDbPatchLevel', function(callback) {
+        sandbox.stub(instances.patcher, 'readDbPatchLevel').callsFake(function(callback) {
           callback(new Error('foo'));
         });
         return mysql.connect({ logger: instances.logger }).catch(function(err) {
@@ -213,7 +213,7 @@ describe('db/mysql:', function() {
       };
 
       store = new MysqlStore({});
-      sinon.stub(store._pool, 'getConnection', function(cb) {
+      sinon.stub(store._pool, 'getConnection').callsFake(function(cb) {
         cb(null, mockConnection);
       });
     });