Merge pull request #15718 from mozilla/FXA-8123

bug(settings): Fix missing connected service name after password reset

packages/functional-tests/tests/react-conversion/resetPassword.spec.ts

@@ -82,6 +82,11 @@ test.describe('reset password react', () => {
 
     await page.getByRole('heading', { name: 'Settings', level: 2 }).waitFor();
 
+    // Check that connected service name is not empty!
+    expect(await page.getByTestId('service-name').innerText()).toContain(
+      'Firefox'
+    );
+
     // Cleanup requires setting this value to correct password
     credentials.password = NEW_PASSWORD;
   });

packages/fxa-graphql-api/src/decorators.spec.ts

@@ -0,0 +1,32 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of the MPL was not distributed with this
+ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
+import { extractRequiredHeaders } from './decorators';
+
+describe('gql decorators', () => {
+  describe('header extraction for auth server', () => {
+    const ip = '127.0.0.1';
+    const agent = 'Mozilla/5.0';
+
+    it('forwards ip', () => {
+      const headers = extractRequiredHeaders({ ip, headers: {} });
+      expect(headers.get('x-forwarded-for')).toEqual('127.0.0.1');
+    });
+
+    it('forwards relevant headers', () => {
+      const headers = extractRequiredHeaders({
+        ip,
+        headers: { 'user-agent': agent },
+      });
+      expect(headers.get('user-agent')).toEqual(agent);
+    });
+
+    it('does not forward irrelevant headers', () => {
+      const headers = extractRequiredHeaders({
+        ip,
+        headers: { Accept: '*/*' },
+      });
+      expect(headers.get('Accept')).toBeNull();
+    });
+  });
+});

packages/fxa-graphql-api/src/decorators.ts

@@ -4,6 +4,8 @@
 import { createParamDecorator, ExecutionContext } from '@nestjs/common';
 import { GqlExecutionContext } from '@nestjs/graphql';
 import { SessionTokenResult } from './auth/session-token.strategy';
+import { Request } from 'express';
+import { IncomingHttpHeaders } from 'http';
 
 /**
  * Extracts the token from an authenticated user for a GraphQL request.
@@ -39,16 +41,29 @@ export const GqlUserState = createParamDecorator(
  * Extracts headers to be sent to auth-server
  */
 export const GqlXHeaders = createParamDecorator(
-  (data: unknown, context: ExecutionContext): Headers => {
+  (_data: unknown, context: ExecutionContext): Headers => {
     const ctx = GqlExecutionContext.create(context).getContext();
+    return extractRequiredHeaders(ctx.req);
+  }
+);
+
+export function extractRequiredHeaders(req?: {
+  ip: string;
+  headers: IncomingHttpHeaders;
+}): Headers {
   const headers: Record<string, string> = {};
 
   // Set the x-forwarded-for header since the auth-server will use this
   // to determine client geolocation
-    if (ctx.req?.ip) {
-      headers['x-forwarded-for'] = ctx.req?.ip;
+  if (req?.ip) {
+    headers['x-forwarded-for'] = req?.ip;
+  }
+
+  // Set the user agent headers. Connected devices use this header for display name purposes
+  const ua = req?.headers['user-agent'];
+  if (ua) {
+    headers['user-agent'] = ua;
   }
 
   return new Headers(headers);
 }
-);