chore(experiments): Remove the q3FormChanges experiment.

The experiment was removed long long ago, and we should have
been able to remove these remnants in train-113.

fixes #1040
This commit is contained in:
Shane Tomlinson 2019-05-08 08:15:52 +01:00
Родитель 6be0bd0535
Коммит 768d114576
Не найден ключ, соответствующий данной подписи
Идентификатор ключа GPG: 09D4F897B87A2D19
6 изменённых файлов: 1 добавлений и 53 удалений

Просмотреть файл

@ -14,7 +14,6 @@ const experimentGroupingRules = [
require('./communication-prefs'),
require('./email-first'),
require('./is-sampled-user'),
require('./q3-form-changes'),
require('./send-sms-install-link'),
require('./sentry'),
require('./token-code'),

Просмотреть файл

@ -1,21 +0,0 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
/**
* q3FormChanges is deprecated but kept around so that the experiment name
* still validate in the weeks after train-112 rolls out.
* The experiment can be removed in train-113 once the numbers of people
* reporting q3FormChanges are sufficiently low.
*/
'use strict';
const BaseGroupingRule = require('./base');
module.exports = class Q3FormChanges extends BaseGroupingRule {
constructor () {
super();
this.deprecated = true;
this.name = 'q3FormChanges';
}
};

Просмотреть файл

@ -9,7 +9,7 @@ import sinon from 'sinon';
describe('lib/experiments/grouping-rules/index', () => {
it('EXPERIMENT_NAMES is exported', () => {
assert.lengthOf(ExperimentGroupingRules.EXPERIMENT_NAMES, 7);
assert.lengthOf(ExperimentGroupingRules.EXPERIMENT_NAMES, 6);
});
describe('choose', () => {

Просмотреть файл

@ -1,28 +0,0 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
import { assert } from 'chai';
import Account from 'models/account';
import Experiment from 'lib/experiments/grouping-rules/q3-form-changes';
describe('lib/experiments/grouping-rules/q3-form-changes', () => {
let account;
let experiment;
before(() => {
account = new Account();
experiment = new Experiment();
});
describe('choose', () => {
it('throws', () => {
assert.throws(() => {
experiment.choose({
account,
uniqueUserId: 'user-id'
});
});
});
});
});

Просмотреть файл

@ -78,7 +78,6 @@ describe('views/pair/index', () => {
uid: 'uid'
});
return view.render().then(() => {
console.log('args', view.replaceCurrentPage.args[0])
assert.isTrue(view.replaceCurrentPage.calledOnceWith('pair/unsupported'));
});
});

Просмотреть файл

@ -46,7 +46,6 @@ require('./spec/lib/experiments/grouping-rules/communication-prefs');
require('./spec/lib/experiments/grouping-rules/email-first');
require('./spec/lib/experiments/grouping-rules/index');
require('./spec/lib/experiments/grouping-rules/is-sampled-user');
require('./spec/lib/experiments/grouping-rules/q3-form-changes');
require('./spec/lib/experiments/grouping-rules/send-sms-install-link');
require('./spec/lib/experiments/grouping-rules/sentry');
require('./spec/lib/experiments/grouping-rules/token-code');