Merge pull request #15110 from mozilla/dont-fail-fast-for-compile

task(ci): Build all packages but don't fail fast

.circleci/config.yml

@@ -299,7 +299,7 @@ commands:
     steps:
       - run:
           name: Compiling TypeScript
-          command: yarn workspaces foreach --exclude fxa-payments-server --exclude fxa-content-server --topological-dev --verbose run compile
+          command: yarn workspaces foreach --topological-dev --verbose run compile
 
   report-coverage:
     # Not currently used. But should be soon once coverage reports are fixed up.
@@ -720,8 +720,6 @@ workflows:
           name: Compile (PR)
           requires:
             - Build (PR)
-          post-steps:
-            - fail-fast
       - unit-test:
           name: Unit Test (PR)
           requires:
@@ -998,8 +996,6 @@ workflows:
               only: /.*/
           requires:
             - Build
-          post-steps:
-            - fail-fast
       - unit-test:
           name: Unit Test
           filters:
@@ -1152,8 +1148,6 @@ workflows:
           name: Compile (nightly)
           requires:
             - Build (nightly)
-          post-steps:
-            - fail-fast
       - unit-test:
           name: Unit Test (nightly)
           requires:

packages/fxa-content-server/app/scripts/models/subscription.ts

@@ -27,7 +27,11 @@ interface IResumeTokenMixin {
 }
 
 const RESUME_TOKEN_FIELDS = ['planId', 'productId'];
-class SubscriptionModel extends Backbone.Model {
+class SubscriptionModel extends Backbone.Model<
+  Record<string, unknown>,
+  Record<string, unknown>,
+  { window?: Window }
+> {
   window?: Window;
   resumeTokenFields?: string[];
 
@@ -42,7 +46,7 @@ class SubscriptionModel extends Backbone.Model {
     );
   }
 
-  initialize(attrs = {}, options: { window?: Window } = {}) {
+  initialize(_attrs = {}, options: { window?: Window } = {}) {
     if (this.get('planId') && this.get('productId')) {
       // already set, no need to look anywhere else for the values.
       return;

packages/fxa-content-server/tsconfig.json

@@ -4,7 +4,7 @@
   "exclude": ["node_modules", "**/*.spec.ts"],
   "compilerOptions": {
     "outDir": "./.tscompiled/",
-    "rootDir": "./app/scripts/",
+    "rootDirs": ["./app/scripts/", "./server/lib/routes/react-app"],
     "baseUrl": "./app/scripts",
     "noImplicitAny": false
   },

packages/fxa-payments-server/tsconfig.json

@@ -20,6 +20,10 @@
   "include": [
     "src"
   ],
+  "exclude": [
+    "**/*.test.ts",
+    "**/*.test.tsx"
+  ],
   "references": [
     {
       "path": "../fxa-react"