Merge pull request #14430 from mozilla/pushbox-fewer-statsd-tags

chore(pushbox): remove statsd metric tags

packages/fxa-auth-server/lib/pushbox/index.ts

@@ -182,11 +182,7 @@ export const pushboxApi = (
             'pushbox.db.retrieve.success',
             performance.now() - startTime
           );
-          statsd.increment('pushbox.db.retrieve', {
-            uid,
-            deviceId,
-            msgCount: result.messages.length.toString(),
-          });
+          statsd.increment('pushbox.db.retrieve');
           return {
             last: result.last,
             index: result.index,
@@ -260,7 +256,7 @@ export const pushboxApi = (
             'pushbox.db.store.success',
             performance.now() - startTime
           );
-          statsd.increment('pushbox.db.store', { uid, deviceId });
+          statsd.increment('pushbox.db.store');
           return { index: result.idx };
         } catch (err) {
           statsd.timing(
@@ -295,7 +291,7 @@ export const pushboxApi = (
             'pushbox.db.delete.device.success',
             performance.now() - startTime
           );
-          statsd.increment('pushbox.db.delete.device', { uid, deviceId });
+          statsd.increment('pushbox.db.delete.device');
         } catch (err) {
           statsd.timing(
             'pushbox.db.delete.device.failure',

packages/fxa-auth-server/test/local/pushbox.js

@@ -98,8 +98,7 @@ describe('pushbox', () => {
           );
           sinon.assert.calledOnceWithExactly(
             mockStatsD.increment,
-            'pushbox.db.store',
-            { uid: mockUid, deviceId: mockDeviceIds[0] }
+            'pushbox.db.store'
           );
           assert.equal(index, '12');
         });
@@ -236,8 +235,7 @@ describe('pushbox', () => {
           );
           sinon.assert.calledOnceWithExactly(
             mockStatsD.increment,
-            'pushbox.db.delete.device',
-            { uid: mockUid, deviceId: mockDeviceIds[0] }
+            'pushbox.db.delete.device'
           );
         },
         (err) => {