Because:
* Android responds immediately to the can_link_account message and we don't appear to always have the event listener attached
This fix:
* Adds requestAnimationFrame, as we have needed to use this a couple of times before for testing when the response back was immediate
fixes FXA-10057
Because:
- On android mobile this response for 'CanLinkAccount' comes back immediately and no pop up is displayed.
- As result, we potentially have a result, and the eventHandler might not be bound.
This commit:
- Attach the event handler before sending the message.
Because:
* Sign in cached, sign in once, use a different account test was failing on the sign out step due to redirect to cached signin
This commit:
* Update the sign out function to check for redirect away from settings but allow for different destinations (email first or sign in, for example)
* Remove the refresh in the test (not needed) and replace with URL check
Closes #FXA-10064
Because:
* We want to track clicks to start an account recovery key setup flow
This commit:
* Add glean event and emit in the appropriate settings page
Closes #FXA-10039
Because:
- We can hit a state where firefox will direct a user to sign in and the redirect uri, or client id won't be present
- This state is erroneous, but it'll take a bit for the fix in FF to be released.
This Commit:
- shortCircuits checkOauthData when we are dealing with a sync integration.
- Sync doesn't need to redirect back to a third party anyway, so this is probably okay.
Because:
- We want to know when a user interacts with the password field
This Commit:
- Adds the login_engage event
- Fires the event when a user focuses on the password input
Because:
* coupon tests are failing in stage due to IP rate limiting
This commit:
* adds signin as a pre-requisite to coupon tests (since all subscription tests now require signin, the steps have been encapsulated in an automatic fixture to reduce code duplication)
Closes # FXA-10045
Because:
* Users on non-Firefox desktop should be shown a more helpful page
This commit:
* Creates a new state on pair/unsupported for non-Firefox, non-Android and non-iOS users to inform them they need to download Firefox to proceed
* Adds cad_redirect_desktop_view and cad_redirect_desktop_download glean events. Ran glean-generate, creating a couple other glean reg.js events
closes FXA-10008
Because:
- the diff looks large because the Glean generated code uses double
quotes whereas our code base uses single quotes
This commit:
- runs the same prettier fix that's part of the pre-commit hook
immediately after generating the code
Because:
* In Backbone we ask users to confirm that they want to merge their Sync data on submission of password signin, if the flow is force_auth since they haven't answered the prompt at this point. We want to do the same for React
This commit:
* Modifies the fxaCanLinkAccount web channel message to return a promise waiting for the browser's response, and only proceeds if the user confirms
fixes FXA-9868
Because:
- we need to able to get metrics flow data directly in React/Settings
without relying on query params
This commit:
- injects a flow id and begin time into the HTML of the React page
- sets the metrics flow data for the app in the precedence of 0) direct
argument, 1) query params, 2) body data attrs
Because:
- Sentry errors logged by the paypal processor did not include
additional error information.
This commit:
- Update paypal processor script to use initSentry, which includes
additional Sentry integrations, such as ExtraErrorData.
- Replace deprecated ExtraErrorData integration with
Sentry.extraErrorDataIntegration()
Closes #FXA-9219
Lauren Zugai
Dan Schomburg
Valerie Pomerleau
dschom
Vijay Budhram
Vijay Budhram
Katrina Anderson
Reino Muhl
Jonathan Almeida
Barry Chen
Ben Bangert