gecko-dev/.flake8

[flake8]
# See http://pep8.readthedocs.io/en/latest/intro.html#configuration
ignore = E121, E123, E126, E129, E133, E226, E241, E242, E704, W503, E402, E741
max-line-length = 99
exclude =
    browser/extensions/mortar/ppapi/,
    build/pymake/,
    testing/mochitest/pywebsocket,
    tools/lint/test/files,
Bug 1270506 - [mozlint] Add python flake8 linter, r=smacleod For now, only the following two directories will be linted: python/mozlint tools/lint New directories can be added by adding them to the 'include' directive in tools/lint/flake8.lint. They all default to the configuration specified in topsrcdir/.flake8. Subdirectories can override this configuration by creating their own .flake8 file. MozReview-Commit-ID: Eag48Lnkp3l --HG-- extra : rebase_source : 6d98c9fef80055a48cc2622848aa04c3045b747e 2016-05-06 00:21:12 +03:00			`[flake8]`
Bug 1280571 - Add testing/mochitest to the flake8 linter, r=ahal MozReview-Commit-ID: INBZaZzcPmF --HG-- extra : rebase_source : c0ba416f110b2768fc744de0fbee21c765081400 2016-09-28 15:28:04 +03:00			`# See http://pep8.readthedocs.io/en/latest/intro.html#configuration`
Bug 1434430 - [flake8] Fix blank 'except' statements r=rwood This is a new issue that gets linted with flake8 3.5.0. Basically you should never use a blank except: statement. This will catch all exceptions, including KeyboardInterrupt and SystemExit (which is likely not intended). If a catch all is needed, use `except: Exception`. If you really mean to also catch KeyboardInterrupt et al, use `except: BaseException`. Of course, being specific is often better than a catch all. MozReview-Commit-ID: FKx80MLO4RN --HG-- extra : rebase_source : 7c74a7d0d81f2c984b47aff3a0ee3448b791177b 2018-01-31 22:32:08 +03:00			`ignore = E121, E123, E126, E129, E133, E226, E241, E242, E704, W503, E402, E741`
Bug 1270506 - [mozlint] Add python flake8 linter, r=smacleod For now, only the following two directories will be linted: python/mozlint tools/lint New directories can be added by adding them to the 'include' directive in tools/lint/flake8.lint. They all default to the configuration specified in topsrcdir/.flake8. Subdirectories can override this configuration by creating their own .flake8 file. MozReview-Commit-ID: Eag48Lnkp3l --HG-- extra : rebase_source : 6d98c9fef80055a48cc2622848aa04c3045b747e 2016-05-06 00:21:12 +03:00			`max-line-length = 99`
Bug 1395126 - Support cascading configuration for flake8, r=bc This allows .flake8 files to override one another, and fixes a pretty bad known bug with our flake8 implementation. For example, say we have a .flake8 file at: /foo/.flake8 Before this patch, if we ran \|mach lint foo/bar\|, the configuration defined in that .flake8 file wouldn't get picked up. It would only work if running the specific directory that contains it, e.g \|mach lint foo\|. This change additionally allows multiple .flake8 files to be used. So if there's one defined at both: /.flake8 /foo/.flake8 Then running \|mach lint foo/bar\| will first apply the root .flake8, then the one under /foo (overriding earlier configuration). This bug still doesn't make flake8 configuration perfect though. Any directory containing a .flake8 file still needs to be explicitly listed in the "include" section of /tools/lint/flake8.yml. Otherwise in the example above, if running \|mach lint /\|, it wouldn't be able to find /foo/.flake8. This is a hard problem and is likely best solved by fixing flake8's upstream configuration handling. Unfortunately this means we still can't switch from a whitelist to a blacklist. MozReview-Commit-ID: 3DZAi1QHYYo --HG-- extra : rebase_source : 51298c5847f6c2792581d9b312c87b70fa716ee1 2017-08-30 00:32:31 +03:00			`exclude =`
bug 1463425 - Fix flake8 in browser/ r=ahal,gps MozReview-Commit-ID: 11Kil84u0TP --HG-- extra : rebase_source : f5ec701490b52bba8b45a790812025c8ab5cf963 2018-05-22 00:13:07 +03:00			`browser/extensions/mortar/ppapi/,`
bug 1463425 - Add more directories to the flake8 list r=ahal MozReview-Commit-ID: JMZQonceq8W --HG-- extra : rebase_source : 1d8d0218f128dede197fa99e5cba1f0101a80384 2018-05-22 16:26:22 +03:00			`build/pymake/,`
Bug 1395126 - Support cascading configuration for flake8, r=bc This allows .flake8 files to override one another, and fixes a pretty bad known bug with our flake8 implementation. For example, say we have a .flake8 file at: /foo/.flake8 Before this patch, if we ran \|mach lint foo/bar\|, the configuration defined in that .flake8 file wouldn't get picked up. It would only work if running the specific directory that contains it, e.g \|mach lint foo\|. This change additionally allows multiple .flake8 files to be used. So if there's one defined at both: /.flake8 /foo/.flake8 Then running \|mach lint foo/bar\| will first apply the root .flake8, then the one under /foo (overriding earlier configuration). This bug still doesn't make flake8 configuration perfect though. Any directory containing a .flake8 file still needs to be explicitly listed in the "include" section of /tools/lint/flake8.yml. Otherwise in the example above, if running \|mach lint /\|, it wouldn't be able to find /foo/.flake8. This is a hard problem and is likely best solved by fixing flake8's upstream configuration handling. Unfortunately this means we still can't switch from a whitelist to a blacklist. MozReview-Commit-ID: 3DZAi1QHYYo --HG-- extra : rebase_source : 51298c5847f6c2792581d9b312c87b70fa716ee1 2017-08-30 00:32:31 +03:00			`testing/mochitest/pywebsocket,`
Bug 1436802 - [lint] Add some tests for the flake8 linter integration r=andi This essentially tests tools/lint/python/flake8.py. Though it also adds a basic framework for testing all the other linters as well. Getting this added now will allow others to collaborate on adding more tests without needing to get to 100% coverage for all linters right off the bat. All python tests under tools/lint/test will run as part of the 'ml' task on Linux, and the build task on Windows (OSX coverage is currently missing for python tests). The flake8 linter currently has a bug where the 'exclude' argument is ignored. This is why we need to also exclude 'tools/lint/test/files' in topsrcdir/.flake8, even though it is already listed in the 'mach_commands.py'. Other linters shouldn't need to do this, the exclusion in 'mach_commands.py' should be good enough. See bug 1277851 for more details. MozReview-Commit-ID: 9ho8C83eeuj --HG-- extra : rebase_source : 0adb01aa81c06f26cb891ae9f92a17f8f9fdf111 2018-03-23 00:24:15 +03:00			`tools/lint/test/files,`