2015-09-23 04:27:34 +03:00
|
|
|
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
|
|
|
|
/* CRTP refcounting templates. Do not use unless you are an Expert. */
|
|
|
|
|
|
|
|
#ifndef mozilla_RefCounted_h
|
|
|
|
#define mozilla_RefCounted_h
|
|
|
|
|
Bug 1609996 - Reorder some includes affected by the previous patches. r=froydnj
This was done by:
This was done by applying:
```
diff --git a/python/mozbuild/mozbuild/code-analysis/mach_commands.py b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
index 789affde7bbf..fe33c4c7d4d1 100644
--- a/python/mozbuild/mozbuild/code-analysis/mach_commands.py
+++ b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
@@ -2007,7 +2007,7 @@ class StaticAnalysis(MachCommandBase):
from subprocess import Popen, PIPE, check_output, CalledProcessError
diff_process = Popen(self._get_clang_format_diff_command(commit), stdout=PIPE)
- args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format]
+ args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format, '-sort-includes']
if not output_file:
args.append("-i")
```
Then running `./mach clang-format -c <commit-hash>`
Then undoing that patch.
Then running check_spidermonkey_style.py --fixup
Then running `./mach clang-format`
I had to fix four things:
* I needed to move <utility> back down in GuardObjects.h because I was hitting
obscure problems with our system include wrappers like this:
0:03.94 /usr/include/stdlib.h:550:14: error: exception specification in declaration does not match previous declaration
0:03.94 extern void *realloc (void *__ptr, size_t __size)
0:03.94 ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/malloc_decls.h:53:1: note: previous declaration is here
0:03.94 MALLOC_DECL(realloc, void*, void*, size_t)
0:03.94 ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozilla/mozalloc.h:22:32: note: expanded from macro 'MALLOC_DECL'
0:03.94 MOZ_MEMORY_API return_type name##_impl(__VA_ARGS__);
0:03.94 ^
0:03.94 <scratch space>:178:1: note: expanded from here
0:03.94 realloc_impl
0:03.94 ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozmemory_wrap.h:142:41: note: expanded from macro 'realloc_impl'
0:03.94 #define realloc_impl mozmem_malloc_impl(realloc)
Which I really didn't feel like digging into.
* I had to restore the order of TrustOverrideUtils.h and related files in nss
because the .inc files depend on TrustOverrideUtils.h being included earlier.
* I had to add a missing include to RollingNumber.h
* Also had to partially restore include order in JsepSessionImpl.cpp to avoid
some -WError issues due to some static inline functions being defined in a
header but not used in the rest of the compilation unit.
Differential Revision: https://phabricator.services.mozilla.com/D60327
--HG--
extra : moz-landing-system : lando
2020-01-20 19:19:48 +03:00
|
|
|
#include <atomic>
|
|
|
|
#include <utility>
|
|
|
|
|
2015-09-23 04:27:34 +03:00
|
|
|
#include "mozilla/AlreadyAddRefed.h"
|
|
|
|
#include "mozilla/Assertions.h"
|
|
|
|
#include "mozilla/Atomics.h"
|
|
|
|
#include "mozilla/Attributes.h"
|
|
|
|
#include "mozilla/RefCountType.h"
|
|
|
|
|
|
|
|
#if defined(MOZILLA_INTERNAL_API)
|
|
|
|
# include "nsXPCOM.h"
|
|
|
|
#endif
|
|
|
|
|
|
|
|
#if defined(MOZILLA_INTERNAL_API) && \
|
|
|
|
(defined(DEBUG) || defined(FORCE_BUILD_REFCNT_LOGGING))
|
|
|
|
# define MOZ_REFCOUNTED_LEAK_CHECKING
|
|
|
|
#endif
|
|
|
|
|
|
|
|
namespace mozilla {
|
|
|
|
|
|
|
|
/**
|
|
|
|
* RefCounted<T> is a sort of a "mixin" for a class T. RefCounted
|
|
|
|
* manages, well, refcounting for T, and because RefCounted is
|
|
|
|
* parameterized on T, RefCounted<T> can call T's destructor directly.
|
|
|
|
* This means T doesn't need to have a virtual dtor and so doesn't
|
|
|
|
* need a vtable.
|
|
|
|
*
|
|
|
|
* RefCounted<T> is created with refcount == 0. Newly-allocated
|
|
|
|
* RefCounted<T> must immediately be assigned to a RefPtr to make the
|
|
|
|
* refcount > 0. It's an error to allocate and free a bare
|
|
|
|
* RefCounted<T>, i.e. outside of the RefPtr machinery. Attempts to
|
|
|
|
* do so will abort DEBUG builds.
|
|
|
|
*
|
|
|
|
* Live RefCounted<T> have refcount > 0. The lifetime (refcounts) of
|
2015-10-18 08:24:48 +03:00
|
|
|
* live RefCounted<T> are controlled by RefPtr<T> and
|
|
|
|
* RefPtr<super/subclass of T>. Upon a transition from refcounted==1
|
2015-09-23 04:27:34 +03:00
|
|
|
* to 0, the RefCounted<T> "dies" and is destroyed. The "destroyed"
|
|
|
|
* state is represented in DEBUG builds by refcount==0xffffdead. This
|
|
|
|
* state distinguishes use-before-ref (refcount==0) from
|
|
|
|
* use-after-destroy (refcount==0xffffdead).
|
|
|
|
*
|
|
|
|
* Note that when deriving from RefCounted or AtomicRefCounted, you
|
|
|
|
* should add MOZ_DECLARE_REFCOUNTED_TYPENAME(ClassName) to the public
|
|
|
|
* section of your class, where ClassName is the name of your class.
|
2016-12-23 23:13:26 +03:00
|
|
|
*
|
|
|
|
* Note: SpiderMonkey should use js::RefCounted instead since that type
|
|
|
|
* will use appropriate js_delete and also not break ref-count logging.
|
2015-09-23 04:27:34 +03:00
|
|
|
*/
|
|
|
|
namespace detail {
|
|
|
|
const MozRefCountType DEAD = 0xffffdead;
|
|
|
|
|
|
|
|
// When building code that gets compiled into Gecko, try to use the
|
|
|
|
// trace-refcount leak logging facilities.
|
|
|
|
#ifdef MOZ_REFCOUNTED_LEAK_CHECKING
|
|
|
|
class RefCountLogger {
|
|
|
|
public:
|
|
|
|
static void logAddRef(const void* aPointer, MozRefCountType aRefCount,
|
|
|
|
const char* aTypeName, uint32_t aInstanceSize) {
|
|
|
|
MOZ_ASSERT(aRefCount != DEAD);
|
|
|
|
NS_LogAddRef(const_cast<void*>(aPointer), aRefCount, aTypeName,
|
|
|
|
aInstanceSize);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void logRelease(const void* aPointer, MozRefCountType aRefCount,
|
|
|
|
const char* aTypeName) {
|
|
|
|
MOZ_ASSERT(aRefCount != DEAD);
|
|
|
|
NS_LogRelease(const_cast<void*>(aPointer), aRefCount, aTypeName);
|
|
|
|
}
|
|
|
|
};
|
|
|
|
#endif
|
|
|
|
|
|
|
|
// This is used WeakPtr.h as well as this file.
|
|
|
|
enum RefCountAtomicity { AtomicRefCount, NonAtomicRefCount };
|
|
|
|
|
2020-02-27 20:39:15 +03:00
|
|
|
template <typename T, RefCountAtomicity Atomicity>
|
2017-10-27 20:05:51 +03:00
|
|
|
class RC {
|
|
|
|
public:
|
|
|
|
explicit RC(T aCount) : mValue(aCount) {}
|
|
|
|
|
2020-04-06 12:17:34 +03:00
|
|
|
RC(const RC&) = delete;
|
|
|
|
RC& operator=(const RC&) = delete;
|
|
|
|
RC(RC&&) = delete;
|
|
|
|
RC& operator=(RC&&) = delete;
|
|
|
|
|
2017-10-27 20:05:51 +03:00
|
|
|
T operator++() { return ++mValue; }
|
|
|
|
T operator--() { return --mValue; }
|
|
|
|
|
2020-04-06 12:17:34 +03:00
|
|
|
#ifdef DEBUG
|
2017-10-27 20:05:51 +03:00
|
|
|
void operator=(const T& aValue) { mValue = aValue; }
|
2020-04-06 12:17:34 +03:00
|
|
|
#endif
|
2017-10-27 20:05:51 +03:00
|
|
|
|
|
|
|
operator T() const { return mValue; }
|
|
|
|
|
|
|
|
private:
|
|
|
|
T mValue;
|
|
|
|
};
|
|
|
|
|
2020-02-27 20:39:15 +03:00
|
|
|
template <typename T>
|
|
|
|
class RC<T, AtomicRefCount> {
|
2017-10-27 20:05:51 +03:00
|
|
|
public:
|
2018-07-21 17:21:39 +03:00
|
|
|
explicit RC(T aCount) : mValue(aCount) {}
|
2017-10-27 20:05:51 +03:00
|
|
|
|
2020-04-06 12:17:34 +03:00
|
|
|
RC(const RC&) = delete;
|
|
|
|
RC& operator=(const RC&) = delete;
|
|
|
|
RC(RC&&) = delete;
|
|
|
|
RC& operator=(RC&&) = delete;
|
|
|
|
|
2017-10-27 20:05:51 +03:00
|
|
|
T operator++() {
|
|
|
|
// Memory synchronization is not required when incrementing a
|
|
|
|
// reference count. The first increment of a reference count on a
|
|
|
|
// thread is not important, since the first use of the object on a
|
|
|
|
// thread can happen before it. What is important is the transfer
|
|
|
|
// of the pointer to that thread, which may happen prior to the
|
|
|
|
// first increment on that thread. The necessary memory
|
|
|
|
// synchronization is done by the mechanism that transfers the
|
|
|
|
// pointer between threads.
|
|
|
|
return mValue.fetch_add(1, std::memory_order_relaxed) + 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
T operator--() {
|
|
|
|
// Since this may be the last release on this thread, we need
|
|
|
|
// release semantics so that prior writes on this thread are visible
|
|
|
|
// to the thread that destroys the object when it reads mValue with
|
|
|
|
// acquire semantics.
|
|
|
|
T result = mValue.fetch_sub(1, std::memory_order_release) - 1;
|
|
|
|
if (result == 0) {
|
|
|
|
// We're going to destroy the object on this thread, so we need
|
|
|
|
// acquire semantics to synchronize with the memory released by
|
|
|
|
// the last release on other threads, that is, to ensure that
|
|
|
|
// writes prior to that release are now visible on this thread.
|
2019-12-09 17:00:22 +03:00
|
|
|
#ifdef MOZ_TSAN
|
|
|
|
// TSan doesn't understand std::atomic_thread_fence, so in order
|
|
|
|
// to avoid a false positive for every time a refcounted object
|
|
|
|
// is deleted, we replace the fence with an atomic operation.
|
|
|
|
mValue.load(std::memory_order_acquire);
|
|
|
|
#else
|
2017-10-27 20:05:51 +03:00
|
|
|
std::atomic_thread_fence(std::memory_order_acquire);
|
2019-12-09 17:00:22 +03:00
|
|
|
#endif
|
2017-10-27 20:05:51 +03:00
|
|
|
}
|
|
|
|
return result;
|
|
|
|
}
|
|
|
|
|
2020-04-06 12:17:34 +03:00
|
|
|
#ifdef DEBUG
|
2017-10-27 20:05:51 +03:00
|
|
|
// This method is only called in debug builds, so we're not too concerned
|
|
|
|
// about its performance.
|
2018-07-21 17:21:39 +03:00
|
|
|
void operator=(const T& aValue) {
|
|
|
|
mValue.store(aValue, std::memory_order_seq_cst);
|
|
|
|
}
|
2020-04-06 12:17:34 +03:00
|
|
|
#endif
|
2017-10-27 20:05:51 +03:00
|
|
|
|
|
|
|
operator T() const {
|
|
|
|
// Use acquire semantics since we're not sure what the caller is
|
|
|
|
// doing.
|
|
|
|
return mValue.load(std::memory_order_acquire);
|
|
|
|
}
|
|
|
|
|
|
|
|
private:
|
|
|
|
std::atomic<T> mValue;
|
|
|
|
};
|
|
|
|
|
2020-02-27 20:39:15 +03:00
|
|
|
template <typename T, RefCountAtomicity Atomicity>
|
2015-09-23 04:27:34 +03:00
|
|
|
class RefCounted {
|
|
|
|
protected:
|
|
|
|
RefCounted() : mRefCnt(0) {}
|
2020-04-06 12:17:34 +03:00
|
|
|
#ifdef DEBUG
|
2015-09-23 04:27:34 +03:00
|
|
|
~RefCounted() { MOZ_ASSERT(mRefCnt == detail::DEAD); }
|
2020-04-06 12:17:34 +03:00
|
|
|
#endif
|
2015-09-23 04:27:34 +03:00
|
|
|
|
|
|
|
public:
|
|
|
|
// Compatibility with nsRefPtr.
|
|
|
|
void AddRef() const {
|
|
|
|
// Note: this method must be thread safe for AtomicRefCounted.
|
|
|
|
MOZ_ASSERT(int32_t(mRefCnt) >= 0);
|
|
|
|
#ifndef MOZ_REFCOUNTED_LEAK_CHECKING
|
|
|
|
++mRefCnt;
|
|
|
|
#else
|
|
|
|
const char* type = static_cast<const T*>(this)->typeName();
|
|
|
|
uint32_t size = static_cast<const T*>(this)->typeSize();
|
|
|
|
const void* ptr = static_cast<const T*>(this);
|
|
|
|
MozRefCountType cnt = ++mRefCnt;
|
|
|
|
detail::RefCountLogger::logAddRef(ptr, cnt, type, size);
|
|
|
|
#endif
|
|
|
|
}
|
|
|
|
|
|
|
|
void Release() const {
|
|
|
|
// Note: this method must be thread safe for AtomicRefCounted.
|
|
|
|
MOZ_ASSERT(int32_t(mRefCnt) > 0);
|
|
|
|
#ifndef MOZ_REFCOUNTED_LEAK_CHECKING
|
|
|
|
MozRefCountType cnt = --mRefCnt;
|
|
|
|
#else
|
|
|
|
const char* type = static_cast<const T*>(this)->typeName();
|
|
|
|
const void* ptr = static_cast<const T*>(this);
|
|
|
|
MozRefCountType cnt = --mRefCnt;
|
|
|
|
// Note: it's not safe to touch |this| after decrementing the refcount,
|
|
|
|
// except for below.
|
|
|
|
detail::RefCountLogger::logRelease(ptr, cnt, type);
|
|
|
|
#endif
|
|
|
|
if (0 == cnt) {
|
|
|
|
// Because we have atomically decremented the refcount above, only
|
|
|
|
// one thread can get a 0 count here, so as long as we can assume that
|
|
|
|
// everything else in the system is accessing this object through
|
|
|
|
// RefPtrs, it's safe to access |this| here.
|
|
|
|
#ifdef DEBUG
|
|
|
|
mRefCnt = detail::DEAD;
|
|
|
|
#endif
|
2016-12-23 23:13:26 +03:00
|
|
|
delete static_cast<const T*>(this);
|
2015-09-23 04:27:34 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Compatibility with wtf::RefPtr.
|
|
|
|
void ref() { AddRef(); }
|
|
|
|
void deref() { Release(); }
|
|
|
|
MozRefCountType refCount() const { return mRefCnt; }
|
|
|
|
bool hasOneRef() const {
|
|
|
|
MOZ_ASSERT(mRefCnt > 0);
|
|
|
|
return mRefCnt == 1;
|
|
|
|
}
|
|
|
|
|
|
|
|
private:
|
2020-02-27 20:39:15 +03:00
|
|
|
mutable RC<MozRefCountType, Atomicity> mRefCnt;
|
2015-09-23 04:27:34 +03:00
|
|
|
};
|
|
|
|
|
|
|
|
#ifdef MOZ_REFCOUNTED_LEAK_CHECKING
|
|
|
|
// Passing override for the optional argument marks the typeName and
|
|
|
|
// typeSize functions defined by this macro as overrides.
|
|
|
|
# define MOZ_DECLARE_REFCOUNTED_VIRTUAL_TYPENAME(T, ...) \
|
|
|
|
virtual const char* typeName() const __VA_ARGS__ { return #T; } \
|
|
|
|
virtual size_t typeSize() const __VA_ARGS__ { return sizeof(*this); }
|
|
|
|
#else
|
|
|
|
# define MOZ_DECLARE_REFCOUNTED_VIRTUAL_TYPENAME(T, ...)
|
|
|
|
#endif
|
|
|
|
|
|
|
|
// Note that this macro is expanded unconditionally because it declares only
|
|
|
|
// two small inline functions which will hopefully get eliminated by the linker
|
|
|
|
// in non-leak-checking builds.
|
|
|
|
#define MOZ_DECLARE_REFCOUNTED_TYPENAME(T) \
|
|
|
|
const char* typeName() const { return #T; } \
|
|
|
|
size_t typeSize() const { return sizeof(*this); }
|
|
|
|
|
|
|
|
} // namespace detail
|
|
|
|
|
2016-12-23 23:13:26 +03:00
|
|
|
template <typename T>
|
|
|
|
class RefCounted : public detail::RefCounted<T, detail::NonAtomicRefCount> {
|
2015-09-23 04:27:34 +03:00
|
|
|
public:
|
|
|
|
~RefCounted() {
|
2020-01-08 17:52:10 +03:00
|
|
|
static_assert(std::is_base_of<RefCounted, T>::value,
|
2015-09-23 04:27:34 +03:00
|
|
|
"T must derive from RefCounted<T>");
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
namespace external {
|
|
|
|
|
|
|
|
/**
|
|
|
|
* AtomicRefCounted<T> is like RefCounted<T>, with an atomically updated
|
|
|
|
* reference counter.
|
|
|
|
*
|
|
|
|
* NOTE: Please do not use this class, use NS_INLINE_DECL_THREADSAFE_REFCOUNTING
|
|
|
|
* instead.
|
|
|
|
*/
|
2020-02-27 20:39:15 +03:00
|
|
|
template <typename T>
|
2015-09-23 04:27:34 +03:00
|
|
|
class AtomicRefCounted
|
2020-02-27 20:39:15 +03:00
|
|
|
: public mozilla::detail::RefCounted<T, mozilla::detail::AtomicRefCount> {
|
2015-09-23 04:27:34 +03:00
|
|
|
public:
|
|
|
|
~AtomicRefCounted() {
|
2020-01-08 17:52:10 +03:00
|
|
|
static_assert(std::is_base_of<AtomicRefCounted, T>::value,
|
2015-09-23 04:27:34 +03:00
|
|
|
"T must derive from AtomicRefCounted<T>");
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
|
|
|
} // namespace external
|
|
|
|
|
|
|
|
} // namespace mozilla
|
|
|
|
|
|
|
|
#endif // mozilla_RefCounted_h
|