2014-11-07 19:17:41 +03:00
|
|
|
/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
|
|
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
|
|
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
|
|
|
|
/* Typed temporary pointers for reference-counted smart pointers. */
|
|
|
|
|
|
|
|
#ifndef AlreadyAddRefed_h
|
|
|
|
#define AlreadyAddRefed_h
|
|
|
|
|
Bug 1609996 - Reorder some includes affected by the previous patches. r=froydnj
This was done by:
This was done by applying:
```
diff --git a/python/mozbuild/mozbuild/code-analysis/mach_commands.py b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
index 789affde7bbf..fe33c4c7d4d1 100644
--- a/python/mozbuild/mozbuild/code-analysis/mach_commands.py
+++ b/python/mozbuild/mozbuild/code-analysis/mach_commands.py
@@ -2007,7 +2007,7 @@ class StaticAnalysis(MachCommandBase):
from subprocess import Popen, PIPE, check_output, CalledProcessError
diff_process = Popen(self._get_clang_format_diff_command(commit), stdout=PIPE)
- args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format]
+ args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format, '-sort-includes']
if not output_file:
args.append("-i")
```
Then running `./mach clang-format -c <commit-hash>`
Then undoing that patch.
Then running check_spidermonkey_style.py --fixup
Then running `./mach clang-format`
I had to fix four things:
* I needed to move <utility> back down in GuardObjects.h because I was hitting
obscure problems with our system include wrappers like this:
0:03.94 /usr/include/stdlib.h:550:14: error: exception specification in declaration does not match previous declaration
0:03.94 extern void *realloc (void *__ptr, size_t __size)
0:03.94 ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/malloc_decls.h:53:1: note: previous declaration is here
0:03.94 MALLOC_DECL(realloc, void*, void*, size_t)
0:03.94 ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozilla/mozalloc.h:22:32: note: expanded from macro 'MALLOC_DECL'
0:03.94 MOZ_MEMORY_API return_type name##_impl(__VA_ARGS__);
0:03.94 ^
0:03.94 <scratch space>:178:1: note: expanded from here
0:03.94 realloc_impl
0:03.94 ^
0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozmemory_wrap.h:142:41: note: expanded from macro 'realloc_impl'
0:03.94 #define realloc_impl mozmem_malloc_impl(realloc)
Which I really didn't feel like digging into.
* I had to restore the order of TrustOverrideUtils.h and related files in nss
because the .inc files depend on TrustOverrideUtils.h being included earlier.
* I had to add a missing include to RollingNumber.h
* Also had to partially restore include order in JsepSessionImpl.cpp to avoid
some -WError issues due to some static inline functions being defined in a
header but not used in the rest of the compilation unit.
Differential Revision: https://phabricator.services.mozilla.com/D60327
--HG--
extra : moz-landing-system : lando
2020-01-20 19:19:48 +03:00
|
|
|
#include <utility>
|
|
|
|
|
2014-11-07 19:17:41 +03:00
|
|
|
#include "mozilla/Assertions.h"
|
|
|
|
#include "mozilla/Attributes.h"
|
|
|
|
|
|
|
|
namespace mozilla {
|
|
|
|
|
|
|
|
struct unused_t;
|
|
|
|
|
|
|
|
} // namespace mozilla
|
|
|
|
|
|
|
|
/**
|
2014-12-31 19:42:05 +03:00
|
|
|
* already_AddRefed cooperates with reference counting smart pointers to enable
|
|
|
|
* you to assign in a pointer _without_ |AddRef|ing it. You might want to use
|
|
|
|
* this as a return type from a function that returns an already |AddRef|ed
|
|
|
|
* pointer.
|
|
|
|
*
|
|
|
|
* TODO Move already_AddRefed to namespace mozilla. This has not yet been done
|
|
|
|
* because of the sheer number of usages of already_AddRefed.
|
2017-03-22 02:00:34 +03:00
|
|
|
*
|
|
|
|
* When should you use already_AddRefed<>?
|
|
|
|
* * Ensure a consumer takes ownership of a reference
|
|
|
|
* * Pass ownership without calling AddRef/Release (sometimes required in
|
|
|
|
* off-main-thread code)
|
|
|
|
* * The ref pointer type you're using doesn't support move construction
|
|
|
|
*
|
2018-05-30 22:15:35 +03:00
|
|
|
* Otherwise, use std::move(RefPtr/nsCOMPtr/etc).
|
2014-11-07 19:17:41 +03:00
|
|
|
*/
|
|
|
|
template <class T>
|
2021-09-15 08:10:51 +03:00
|
|
|
struct
|
|
|
|
#if !defined(MOZ_CLANG_PLUGIN) && !defined(XGILL_PLUGIN)
|
|
|
|
[[nodiscard]]
|
|
|
|
#endif
|
|
|
|
MOZ_NON_AUTOABLE already_AddRefed {
|
2014-11-07 19:17:41 +03:00
|
|
|
already_AddRefed() : mRawPtr(nullptr) {}
|
|
|
|
|
2018-06-23 09:25:19 +03:00
|
|
|
// For simplicity, allow returning nullptr from functions returning
|
|
|
|
// already_AddRefed<T>. Don't permit returning raw T*, though; it's preferred
|
|
|
|
// to create already_AddRefed<T> from a reference-counting smart pointer.
|
2017-06-01 08:01:40 +03:00
|
|
|
MOZ_IMPLICIT already_AddRefed(decltype(nullptr)) : mRawPtr(nullptr) {}
|
2014-11-07 19:17:41 +03:00
|
|
|
explicit already_AddRefed(T* aRawPtr) : mRawPtr(aRawPtr) {}
|
|
|
|
|
2015-04-10 15:03:00 +03:00
|
|
|
// Disallow copy constructor and copy assignment operator: move semantics used
|
|
|
|
// instead.
|
2015-01-07 02:35:02 +03:00
|
|
|
already_AddRefed(const already_AddRefed<T>& aOther) = delete;
|
2015-04-10 15:03:00 +03:00
|
|
|
already_AddRefed<T>& operator=(const already_AddRefed<T>& aOther) = delete;
|
2014-11-07 19:17:41 +03:00
|
|
|
|
2018-03-07 22:27:28 +03:00
|
|
|
// WARNING: sketchiness ahead.
|
|
|
|
//
|
|
|
|
// The x86-64 ABI for Unix-like operating systems requires structures to be
|
|
|
|
// returned via invisible reference if they are non-trivial for the purposes
|
|
|
|
// of calls according to the C++ ABI[1]. For our consideration here, that
|
|
|
|
// means that if we have a non-trivial move constructor or destructor,
|
|
|
|
// already_AddRefed must be returned by invisible reference. But
|
|
|
|
// already_AddRefed is small enough and so commonly used that it would be
|
|
|
|
// beneficial to return it via registers instead. So we need to figure out
|
|
|
|
// a way to make the move constructor and the destructor trivial.
|
|
|
|
//
|
|
|
|
// Our destructor is normally non-trivial, because it asserts that the
|
|
|
|
// stored pointer has been taken by somebody else prior to destruction.
|
|
|
|
// However, since the assert in question is compiled only for DEBUG builds,
|
|
|
|
// we can make the destructor trivial in non-DEBUG builds by simply defining
|
|
|
|
// it with `= default`.
|
|
|
|
//
|
|
|
|
// We now have to make the move constructor trivial as well. It is normally
|
|
|
|
// non-trivial, because the incoming object has its pointer null-ed during
|
|
|
|
// the move. This null-ing is done to satisfy the assert in the destructor.
|
|
|
|
// But since that destructor has no assert in non-DEBUG builds, the clearing
|
|
|
|
// is unnecessary in such builds; all we really need to perform is a copy of
|
|
|
|
// the pointer from the incoming object. So we can let the compiler define
|
|
|
|
// a trivial move constructor for us, and already_AddRefed can now be
|
|
|
|
// returned in registers rather than needing to allocate a stack slot for
|
|
|
|
// an invisible reference.
|
|
|
|
//
|
|
|
|
// The above considerations apply to Unix-like operating systems only; the
|
|
|
|
// conditions for the same optimization to apply on x86-64 Windows are much
|
|
|
|
// more strigent and are basically impossible for already_AddRefed to
|
|
|
|
// satisfy[2]. But we do get some benefit from this optimization on Windows
|
|
|
|
// because we removed the nulling of the pointer during the move, so that's
|
|
|
|
// a codesize win.
|
|
|
|
//
|
|
|
|
// [1] https://itanium-cxx-abi.github.io/cxx-abi/abi.html#non-trivial
|
|
|
|
// [2] https://docs.microsoft.com/en-us/cpp/build/return-values-cpp
|
|
|
|
|
|
|
|
already_AddRefed(already_AddRefed<T>&& aOther)
|
|
|
|
#ifdef DEBUG
|
|
|
|
: mRawPtr(aOther.take()) {
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
= default;
|
|
|
|
#endif
|
2014-11-07 19:17:41 +03:00
|
|
|
|
2015-04-10 15:03:00 +03:00
|
|
|
already_AddRefed<T>& operator=(already_AddRefed<T>&& aOther) {
|
|
|
|
mRawPtr = aOther.take();
|
|
|
|
return *this;
|
|
|
|
}
|
|
|
|
|
2014-11-07 19:17:41 +03:00
|
|
|
/**
|
|
|
|
* This helper is useful in cases like
|
|
|
|
*
|
|
|
|
* already_AddRefed<BaseClass>
|
|
|
|
* Foo()
|
|
|
|
* {
|
2015-10-18 08:24:48 +03:00
|
|
|
* RefPtr<SubClass> x = ...;
|
2014-11-07 19:17:41 +03:00
|
|
|
* return x.forget();
|
|
|
|
* }
|
|
|
|
*
|
|
|
|
* The autoconversion allows one to omit the idiom
|
|
|
|
*
|
2015-10-18 08:24:48 +03:00
|
|
|
* RefPtr<BaseClass> y = x.forget();
|
2014-11-07 19:17:41 +03:00
|
|
|
* return y.forget();
|
2014-12-31 19:42:05 +03:00
|
|
|
*
|
|
|
|
* Note that nsRefPtr is the XPCOM reference counting smart pointer class.
|
2014-11-07 19:17:41 +03:00
|
|
|
*/
|
2015-01-08 07:32:55 +03:00
|
|
|
template <typename U>
|
2015-07-28 04:12:06 +03:00
|
|
|
MOZ_IMPLICIT already_AddRefed(already_AddRefed<U>&& aOther)
|
|
|
|
: mRawPtr(aOther.take()) {}
|
2015-01-08 07:32:55 +03:00
|
|
|
|
2018-03-07 22:27:28 +03:00
|
|
|
~already_AddRefed()
|
|
|
|
#ifdef DEBUG
|
|
|
|
{
|
|
|
|
MOZ_ASSERT(!mRawPtr);
|
|
|
|
}
|
|
|
|
#else
|
|
|
|
= default;
|
|
|
|
#endif
|
2015-01-08 07:32:55 +03:00
|
|
|
|
|
|
|
// Specialize the unused operator<< for already_AddRefed, to allow
|
|
|
|
// nsCOMPtr<nsIFoo> foo;
|
2015-11-02 08:53:26 +03:00
|
|
|
// Unused << foo.forget();
|
2015-01-08 07:32:55 +03:00
|
|
|
// Note that nsCOMPtr is the XPCOM reference counting smart pointer class.
|
|
|
|
friend void operator<<(const mozilla::unused_t& aUnused,
|
|
|
|
const already_AddRefed<T>& aRhs) {
|
|
|
|
auto mutableAlreadyAddRefed = const_cast<already_AddRefed<T>*>(&aRhs);
|
|
|
|
aUnused << mutableAlreadyAddRefed->take();
|
|
|
|
}
|
|
|
|
|
2021-03-17 06:01:21 +03:00
|
|
|
[[nodiscard]] T* take() {
|
2015-01-08 07:32:55 +03:00
|
|
|
T* rawPtr = mRawPtr;
|
2014-11-07 19:17:41 +03:00
|
|
|
mRawPtr = nullptr;
|
2015-01-08 07:32:55 +03:00
|
|
|
return rawPtr;
|
2014-11-07 19:17:41 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* This helper provides a static_cast replacement for already_AddRefed, so
|
|
|
|
* if you have
|
|
|
|
*
|
|
|
|
* already_AddRefed<Parent> F();
|
|
|
|
*
|
|
|
|
* you can write
|
|
|
|
*
|
|
|
|
* already_AddRefed<Child>
|
|
|
|
* G()
|
|
|
|
* {
|
|
|
|
* return F().downcast<Child>();
|
|
|
|
* }
|
|
|
|
*/
|
|
|
|
template <class U>
|
|
|
|
already_AddRefed<U> downcast() {
|
|
|
|
U* tmp = static_cast<U*>(mRawPtr);
|
|
|
|
mRawPtr = nullptr;
|
|
|
|
return already_AddRefed<U>(tmp);
|
|
|
|
}
|
|
|
|
|
|
|
|
private:
|
2014-12-24 05:17:50 +03:00
|
|
|
T* MOZ_OWNING_REF mRawPtr;
|
2014-11-07 19:17:41 +03:00
|
|
|
};
|
|
|
|
|
|
|
|
#endif // AlreadyAddRefed_h
|