2019-04-18 22:37:15 +03:00
|
|
|
/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
|
|
|
|
/* vim:set ts=2 sw=2 sts=2 et cindent: */
|
|
|
|
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
|
|
|
|
#include "mozilla/dom/JSWindowActor.h"
|
|
|
|
#include "mozilla/dom/JSWindowActorBinding.h"
|
|
|
|
#include "mozilla/dom/MessageManagerBinding.h"
|
|
|
|
#include "mozilla/dom/PWindowGlobal.h"
|
Bug 1541557: Part 1 - Use correct globals for JSWindowActors not in the shared JSM global. r=nika
The current JSWindowActor code assumes that all actors will be created in the
shared JSM global. This has a few problems:
1) For actors in other scopes, it enters the wrong compartment before decoding
messages, which leads to a compartment checker error when trying to call
message handlers. That could be fixed by just wrapping the result for the
caller, but that would lead to other problems. Aside from the efficiency
concerns of having to deal with cross-compartment wrappers, SpecialPowers in
particular would not be able to pass the resulting objects to unprivileged
scopes, since only SpecialPowers compartments have permissive CCWs enabled.
2) It also leads to the prototype objects for the actor instances being
created in the shared JSM scope, even when the actors themselves are defined
in other compartments. Again, aside from CCW efficiency issues, this prevents
the SpecialPowers instances from being accessed by the unprivileged scopes
that they're exposed to, since the prototype objects live in privileged scopes
which don't have permissive CCWs enabled.
This patch changes child actors to always create their objects in the global
of their constructors.
The parent objects are still created in the shared JSM global, but they now
wrap values for the appropriate compartment before trying to call message
handlers.
Differential Revision: https://phabricator.services.mozilla.com/D35051
--HG--
extra : rebase_source : 436ce516080812680d1433bf3ecbd12f91d88165
extra : source : 61fa2745733f3631488a3ecccc144823683b7b6d
2019-06-13 02:06:40 +03:00
|
|
|
#include "mozilla/dom/Promise.h"
|
2019-06-14 01:01:05 +03:00
|
|
|
#include "js/Promise.h"
|
2019-04-18 22:37:15 +03:00
|
|
|
|
|
|
|
namespace mozilla {
|
|
|
|
namespace dom {
|
|
|
|
|
|
|
|
NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(JSWindowActor)
|
|
|
|
NS_WRAPPERCACHE_INTERFACE_MAP_ENTRY
|
|
|
|
NS_INTERFACE_MAP_ENTRY(nsISupports)
|
|
|
|
NS_INTERFACE_MAP_END
|
|
|
|
|
|
|
|
NS_IMPL_CYCLE_COLLECTING_ADDREF(JSWindowActor)
|
|
|
|
NS_IMPL_CYCLE_COLLECTING_RELEASE(JSWindowActor)
|
|
|
|
|
|
|
|
NS_IMPL_CYCLE_COLLECTION_CLASS(JSWindowActor)
|
|
|
|
|
|
|
|
NS_IMPL_CYCLE_COLLECTION_UNLINK_BEGIN(JSWindowActor)
|
|
|
|
tmp->RejectPendingQueries(); // Clear out & reject mPendingQueries
|
|
|
|
NS_IMPL_CYCLE_COLLECTION_UNLINK_PRESERVED_WRAPPER
|
|
|
|
NS_IMPL_CYCLE_COLLECTION_UNLINK_END
|
|
|
|
|
|
|
|
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN(JSWindowActor)
|
|
|
|
NS_IMPL_CYCLE_COLLECTION_TRAVERSE(mPendingQueries)
|
|
|
|
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_END
|
|
|
|
|
|
|
|
NS_IMPL_CYCLE_COLLECTION_TRACE_WRAPPERCACHE(JSWindowActor)
|
|
|
|
|
|
|
|
JSWindowActor::JSWindowActor() : mNextQueryId(0) {}
|
|
|
|
|
2019-05-10 18:01:40 +03:00
|
|
|
void JSWindowActor::StartDestroy() {
|
2019-08-15 02:13:13 +03:00
|
|
|
InvokeCallback(CallbackFunction::WillDestroy);
|
2019-05-10 18:01:40 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
void JSWindowActor::AfterDestroy() {
|
2019-08-15 02:13:13 +03:00
|
|
|
InvokeCallback(CallbackFunction::DidDestroy);
|
2019-05-10 18:01:40 +03:00
|
|
|
}
|
|
|
|
|
2019-08-15 02:13:13 +03:00
|
|
|
void JSWindowActor::InvokeCallback(CallbackFunction callback) {
|
2019-06-14 01:01:05 +03:00
|
|
|
AutoEntryScript aes(GetParentObject(), "JSWindowActor destroy callback");
|
2019-05-10 18:01:40 +03:00
|
|
|
JSContext* cx = aes.cx();
|
2019-08-15 02:13:13 +03:00
|
|
|
MozJSWindowActorCallbacks callbacksHolder;
|
2019-05-10 18:01:40 +03:00
|
|
|
NS_ENSURE_TRUE_VOID(GetWrapper());
|
|
|
|
JS::Rooted<JS::Value> val(cx, JS::ObjectValue(*GetWrapper()));
|
|
|
|
if (NS_WARN_IF(!callbacksHolder.Init(cx, val))) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Destroy callback is optional.
|
2019-08-15 02:13:13 +03:00
|
|
|
if (callback == CallbackFunction::WillDestroy) {
|
2019-05-10 18:01:40 +03:00
|
|
|
if (callbacksHolder.mWillDestroy.WasPassed()) {
|
2019-06-10 20:53:22 +03:00
|
|
|
callbacksHolder.mWillDestroy.Value()->Call(this);
|
2019-05-10 18:01:40 +03:00
|
|
|
}
|
2019-08-15 02:13:13 +03:00
|
|
|
} else if (callback == CallbackFunction::DidDestroy) {
|
2019-05-10 18:01:40 +03:00
|
|
|
if (callbacksHolder.mDidDestroy.WasPassed()) {
|
2019-06-10 20:53:22 +03:00
|
|
|
callbacksHolder.mDidDestroy.Value()->Call(this);
|
2019-05-10 18:01:40 +03:00
|
|
|
}
|
2019-08-15 02:13:13 +03:00
|
|
|
} else {
|
|
|
|
if (callbacksHolder.mActorCreated.WasPassed()) {
|
|
|
|
callbacksHolder.mActorCreated.Value()->Call(this);
|
|
|
|
}
|
2019-05-10 18:01:40 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2019-04-18 22:37:15 +03:00
|
|
|
void JSWindowActor::RejectPendingQueries() {
|
|
|
|
// Take our queries out, in case somehow rejecting promises can trigger
|
|
|
|
// additions or removals.
|
|
|
|
nsRefPtrHashtable<nsUint64HashKey, Promise> pendingQueries;
|
|
|
|
mPendingQueries.SwapElements(pendingQueries);
|
|
|
|
for (auto iter = pendingQueries.Iter(); !iter.Done(); iter.Next()) {
|
|
|
|
iter.Data()->MaybeReject(NS_ERROR_NOT_AVAILABLE);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void JSWindowActor::SetName(const nsAString& aName) {
|
|
|
|
MOZ_ASSERT(mName.IsEmpty(), "Cannot set name twice!");
|
|
|
|
mName = aName;
|
|
|
|
}
|
|
|
|
|
|
|
|
void JSWindowActor::SendAsyncMessage(JSContext* aCx,
|
|
|
|
const nsAString& aMessageName,
|
|
|
|
JS::Handle<JS::Value> aObj,
|
|
|
|
JS::Handle<JS::Value> aTransfers,
|
|
|
|
ErrorResult& aRv) {
|
|
|
|
ipc::StructuredCloneData data;
|
2019-06-14 01:01:05 +03:00
|
|
|
if (!nsFrameMessageManager::GetParamsForMessage(aCx, aObj, aTransfers,
|
|
|
|
data)) {
|
2019-04-18 22:37:15 +03:00
|
|
|
aRv.Throw(NS_ERROR_DOM_DATA_CLONE_ERR);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
JSWindowActorMessageMeta meta;
|
|
|
|
meta.actorName() = mName;
|
|
|
|
meta.messageName() = aMessageName;
|
|
|
|
meta.kind() = JSWindowActorMessageKind::Message;
|
|
|
|
|
|
|
|
SendRawMessage(meta, std::move(data), aRv);
|
|
|
|
}
|
|
|
|
|
|
|
|
already_AddRefed<Promise> JSWindowActor::SendQuery(
|
|
|
|
JSContext* aCx, const nsAString& aMessageName, JS::Handle<JS::Value> aObj,
|
|
|
|
JS::Handle<JS::Value> aTransfers, ErrorResult& aRv) {
|
|
|
|
ipc::StructuredCloneData data;
|
2019-06-14 01:01:05 +03:00
|
|
|
if (!nsFrameMessageManager::GetParamsForMessage(aCx, aObj, aTransfers,
|
|
|
|
data)) {
|
2019-04-18 22:37:15 +03:00
|
|
|
aRv.Throw(NS_ERROR_DOM_DATA_CLONE_ERR);
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
nsIGlobalObject* global = xpc::CurrentNativeGlobal(aCx);
|
|
|
|
if (NS_WARN_IF(!global)) {
|
|
|
|
aRv.Throw(NS_ERROR_UNEXPECTED);
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
RefPtr<Promise> promise = Promise::Create(global, aRv);
|
|
|
|
if (NS_WARN_IF(aRv.Failed())) {
|
|
|
|
return nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
JSWindowActorMessageMeta meta;
|
|
|
|
meta.actorName() = mName;
|
|
|
|
meta.messageName() = aMessageName;
|
|
|
|
meta.queryId() = mNextQueryId++;
|
|
|
|
meta.kind() = JSWindowActorMessageKind::Query;
|
|
|
|
|
|
|
|
mPendingQueries.Put(meta.queryId(), promise);
|
|
|
|
|
|
|
|
SendRawMessage(meta, std::move(data), aRv);
|
|
|
|
return promise.forget();
|
|
|
|
}
|
|
|
|
|
|
|
|
void JSWindowActor::ReceiveRawMessage(const JSWindowActorMessageMeta& aMetadata,
|
|
|
|
ipc::StructuredCloneData&& aData) {
|
2019-06-14 01:01:05 +03:00
|
|
|
AutoEntryScript aes(GetParentObject(), "JSWindowActor message handler");
|
2019-04-18 22:37:15 +03:00
|
|
|
JSContext* cx = aes.cx();
|
|
|
|
|
|
|
|
// Read the message into a JS object from IPC.
|
|
|
|
ErrorResult error;
|
|
|
|
JS::Rooted<JS::Value> data(cx);
|
|
|
|
aData.Read(cx, &data, error);
|
|
|
|
if (NS_WARN_IF(error.Failed())) {
|
2019-06-14 01:01:05 +03:00
|
|
|
if (XRE_IsParentProcess()) {
|
|
|
|
MOZ_ASSERT(false, "Should not receive non-decodable data");
|
|
|
|
} else {
|
|
|
|
MOZ_DIAGNOSTIC_ASSERT(false, "Should not receive non-decodable data");
|
|
|
|
}
|
2019-04-18 22:37:15 +03:00
|
|
|
MOZ_ALWAYS_TRUE(error.MaybeSetPendingException(cx));
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
switch (aMetadata.kind()) {
|
|
|
|
case JSWindowActorMessageKind::QueryResolve:
|
|
|
|
case JSWindowActorMessageKind::QueryReject:
|
|
|
|
ReceiveQueryReply(cx, aMetadata, data, error);
|
|
|
|
break;
|
|
|
|
|
|
|
|
case JSWindowActorMessageKind::Message:
|
|
|
|
case JSWindowActorMessageKind::Query:
|
|
|
|
ReceiveMessageOrQuery(cx, aMetadata, data, error);
|
|
|
|
break;
|
|
|
|
|
|
|
|
default:
|
|
|
|
MOZ_ASSERT_UNREACHABLE();
|
|
|
|
}
|
|
|
|
|
|
|
|
if (NS_WARN_IF(error.Failed())) {
|
|
|
|
MOZ_ALWAYS_TRUE(error.MaybeSetPendingException(cx));
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void JSWindowActor::ReceiveMessageOrQuery(
|
|
|
|
JSContext* aCx, const JSWindowActorMessageMeta& aMetadata,
|
|
|
|
JS::Handle<JS::Value> aData, ErrorResult& aRv) {
|
|
|
|
// The argument which we want to pass to IPC.
|
|
|
|
RootedDictionary<ReceiveMessageArgument> argument(aCx);
|
|
|
|
argument.mObjects = JS_NewPlainObject(aCx);
|
|
|
|
argument.mTarget = this;
|
|
|
|
argument.mName = aMetadata.messageName();
|
|
|
|
argument.mData = aData;
|
|
|
|
argument.mJson = aData;
|
|
|
|
argument.mSync = false;
|
|
|
|
|
|
|
|
JS::Rooted<JSObject*> self(aCx, GetWrapper());
|
|
|
|
JS::Rooted<JSObject*> global(aCx, JS::GetNonCCWObjectGlobal(self));
|
|
|
|
|
|
|
|
// We only need to create a promise if we're dealing with a query here. It
|
|
|
|
// will be resolved or rejected once the listener has been called. Our
|
|
|
|
// listener on this promise will then send the reply.
|
|
|
|
RefPtr<Promise> promise;
|
|
|
|
if (aMetadata.kind() == JSWindowActorMessageKind::Query) {
|
|
|
|
promise = Promise::Create(xpc::NativeGlobal(global), aRv);
|
|
|
|
if (NS_WARN_IF(aRv.Failed())) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
RefPtr<QueryHandler> handler = new QueryHandler(this, aMetadata);
|
|
|
|
promise->AppendNativeHandler(handler);
|
|
|
|
}
|
|
|
|
|
|
|
|
// Invoke the actual callback.
|
|
|
|
JS::Rooted<JS::Value> retval(aCx);
|
|
|
|
RefPtr<MessageListener> messageListener =
|
|
|
|
new MessageListener(self, global, nullptr, nullptr);
|
|
|
|
messageListener->ReceiveMessage(argument, &retval, aRv,
|
|
|
|
"JSWindowActor receive message");
|
|
|
|
|
|
|
|
// If we have a promise, resolve or reject it respectively.
|
|
|
|
if (promise) {
|
|
|
|
if (aRv.Failed()) {
|
|
|
|
promise->MaybeReject(aRv);
|
|
|
|
} else {
|
2019-07-29 17:43:54 +03:00
|
|
|
promise->MaybeResolve(retval);
|
2019-04-18 22:37:15 +03:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
void JSWindowActor::ReceiveQueryReply(JSContext* aCx,
|
|
|
|
const JSWindowActorMessageMeta& aMetadata,
|
|
|
|
JS::Handle<JS::Value> aData,
|
|
|
|
ErrorResult& aRv) {
|
|
|
|
if (NS_WARN_IF(aMetadata.actorName() != mName)) {
|
|
|
|
aRv.Throw(NS_ERROR_UNEXPECTED);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
RefPtr<Promise> promise;
|
|
|
|
if (NS_WARN_IF(!mPendingQueries.Remove(aMetadata.queryId(),
|
|
|
|
getter_AddRefs(promise)))) {
|
|
|
|
aRv.Throw(NS_ERROR_DOM_INVALID_STATE_ERR);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
Bug 1541557: Part 1 - Use correct globals for JSWindowActors not in the shared JSM global. r=nika
The current JSWindowActor code assumes that all actors will be created in the
shared JSM global. This has a few problems:
1) For actors in other scopes, it enters the wrong compartment before decoding
messages, which leads to a compartment checker error when trying to call
message handlers. That could be fixed by just wrapping the result for the
caller, but that would lead to other problems. Aside from the efficiency
concerns of having to deal with cross-compartment wrappers, SpecialPowers in
particular would not be able to pass the resulting objects to unprivileged
scopes, since only SpecialPowers compartments have permissive CCWs enabled.
2) It also leads to the prototype objects for the actor instances being
created in the shared JSM scope, even when the actors themselves are defined
in other compartments. Again, aside from CCW efficiency issues, this prevents
the SpecialPowers instances from being accessed by the unprivileged scopes
that they're exposed to, since the prototype objects live in privileged scopes
which don't have permissive CCWs enabled.
This patch changes child actors to always create their objects in the global
of their constructors.
The parent objects are still created in the shared JSM global, but they now
wrap values for the appropriate compartment before trying to call message
handlers.
Differential Revision: https://phabricator.services.mozilla.com/D35051
--HG--
extra : rebase_source : 436ce516080812680d1433bf3ecbd12f91d88165
extra : source : 61fa2745733f3631488a3ecccc144823683b7b6d
2019-06-13 02:06:40 +03:00
|
|
|
JSAutoRealm ar(aCx, promise->PromiseObj());
|
|
|
|
JS::RootedValue data(aCx, aData);
|
|
|
|
if (NS_WARN_IF(!JS_WrapValue(aCx, &data))) {
|
|
|
|
aRv.Throw(NS_ERROR_FAILURE);
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2019-04-18 22:37:15 +03:00
|
|
|
if (aMetadata.kind() == JSWindowActorMessageKind::QueryResolve) {
|
2019-07-29 17:43:54 +03:00
|
|
|
promise->MaybeResolve(data);
|
2019-04-18 22:37:15 +03:00
|
|
|
} else {
|
|
|
|
promise->MaybeReject(NS_ERROR_DOM_OPERATION_ERR);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
// Native handler for our generated promise which is used to handle Queries and
|
|
|
|
// send the reply when their promises have been resolved.
|
|
|
|
JSWindowActor::QueryHandler::QueryHandler(
|
|
|
|
JSWindowActor* aActor, const JSWindowActorMessageMeta& aMetadata)
|
|
|
|
: mActor(aActor),
|
|
|
|
mMessageName(aMetadata.messageName()),
|
|
|
|
mQueryId(aMetadata.queryId()) {}
|
|
|
|
|
|
|
|
void JSWindowActor::QueryHandler::RejectedCallback(
|
|
|
|
JSContext* aCx, JS::Handle<JS::Value> aValue) {
|
|
|
|
if (!mActor) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Make sure that this rejection is reported, despite being "handled". This
|
|
|
|
// is done by creating a new promise in the rejected state, and throwing it
|
|
|
|
// away. This will be reported as an unhandled rejected promise.
|
|
|
|
Unused << JS::CallOriginalPromiseReject(aCx, aValue);
|
|
|
|
|
|
|
|
// The exception probably isn't cloneable, so just send down undefined.
|
2019-06-14 01:01:05 +03:00
|
|
|
ipc::StructuredCloneData data;
|
|
|
|
data.Write(aCx, JS::UndefinedHandleValue, IgnoredErrorResult());
|
|
|
|
SendReply(aCx, JSWindowActorMessageKind::QueryReject, std::move(data));
|
2019-04-18 22:37:15 +03:00
|
|
|
}
|
|
|
|
|
|
|
|
void JSWindowActor::QueryHandler::ResolvedCallback(
|
|
|
|
JSContext* aCx, JS::Handle<JS::Value> aValue) {
|
|
|
|
if (!mActor) {
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
ipc::StructuredCloneData data;
|
|
|
|
data.InitScope(JS::StructuredCloneScope::DifferentProcess);
|
|
|
|
|
|
|
|
IgnoredErrorResult error;
|
|
|
|
data.Write(aCx, aValue, error);
|
|
|
|
if (NS_WARN_IF(error.Failed())) {
|
|
|
|
// We failed to serialize the message over IPC. Report this error to the
|
|
|
|
// console, and send a reject reply.
|
|
|
|
nsAutoString msg;
|
|
|
|
msg.Append(mActor->Name());
|
|
|
|
msg.Append(':');
|
|
|
|
msg.Append(mMessageName);
|
|
|
|
msg.Append(NS_LITERAL_STRING(": message reply cannot be cloned."));
|
|
|
|
nsContentUtils::LogSimpleConsoleError(msg, "chrome", false, true);
|
|
|
|
|
|
|
|
JS_ClearPendingException(aCx);
|
|
|
|
|
2019-06-14 01:01:05 +03:00
|
|
|
ipc::StructuredCloneData data;
|
|
|
|
data.Write(aCx, JS::UndefinedHandleValue, IgnoredErrorResult());
|
|
|
|
SendReply(aCx, JSWindowActorMessageKind::QueryReject, std::move(data));
|
2019-04-18 22:37:15 +03:00
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
SendReply(aCx, JSWindowActorMessageKind::QueryResolve, std::move(data));
|
|
|
|
}
|
|
|
|
|
|
|
|
void JSWindowActor::QueryHandler::SendReply(JSContext* aCx,
|
|
|
|
JSWindowActorMessageKind aKind,
|
|
|
|
ipc::StructuredCloneData&& aData) {
|
|
|
|
MOZ_ASSERT(mActor);
|
|
|
|
|
|
|
|
JSWindowActorMessageMeta meta;
|
|
|
|
meta.actorName() = mActor->Name();
|
|
|
|
meta.messageName() = mMessageName;
|
|
|
|
meta.queryId() = mQueryId;
|
|
|
|
meta.kind() = aKind;
|
|
|
|
|
|
|
|
mActor->SendRawMessage(meta, std::move(aData), IgnoreErrors());
|
|
|
|
mActor = nullptr;
|
|
|
|
}
|
|
|
|
|
|
|
|
NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(JSWindowActor::QueryHandler)
|
|
|
|
NS_INTERFACE_MAP_ENTRY(nsISupports)
|
|
|
|
NS_INTERFACE_MAP_END
|
|
|
|
|
|
|
|
NS_IMPL_CYCLE_COLLECTING_ADDREF(JSWindowActor::QueryHandler)
|
|
|
|
NS_IMPL_CYCLE_COLLECTING_RELEASE(JSWindowActor::QueryHandler)
|
|
|
|
|
|
|
|
NS_IMPL_CYCLE_COLLECTION(JSWindowActor::QueryHandler, mActor)
|
|
|
|
|
|
|
|
} // namespace dom
|
|
|
|
} // namespace mozilla
|