gecko-dev/xpcom/ds/nsTHashtable.h

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

677 строки
22 KiB
C
Исходник Обычный вид История

/* -*- Mode: C++; tab-width: 8; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* vim: set ts=8 sts=2 et sw=2 tw=80: */
2012-05-21 15:12:37 +04:00
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
// See the comment at the top of mfbt/HashTable.h for a comparison between
// PLDHashTable and mozilla::HashTable.
#ifndef nsTHashtable_h__
#define nsTHashtable_h__
Bug 1609996 - Reorder some includes affected by the previous patches. r=froydnj This was done by: This was done by applying: ``` diff --git a/python/mozbuild/mozbuild/code-analysis/mach_commands.py b/python/mozbuild/mozbuild/code-analysis/mach_commands.py index 789affde7bbf..fe33c4c7d4d1 100644 --- a/python/mozbuild/mozbuild/code-analysis/mach_commands.py +++ b/python/mozbuild/mozbuild/code-analysis/mach_commands.py @@ -2007,7 +2007,7 @@ class StaticAnalysis(MachCommandBase): from subprocess import Popen, PIPE, check_output, CalledProcessError diff_process = Popen(self._get_clang_format_diff_command(commit), stdout=PIPE) - args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format] + args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format, '-sort-includes'] if not output_file: args.append("-i") ``` Then running `./mach clang-format -c <commit-hash>` Then undoing that patch. Then running check_spidermonkey_style.py --fixup Then running `./mach clang-format` I had to fix four things: * I needed to move <utility> back down in GuardObjects.h because I was hitting obscure problems with our system include wrappers like this: 0:03.94 /usr/include/stdlib.h:550:14: error: exception specification in declaration does not match previous declaration 0:03.94 extern void *realloc (void *__ptr, size_t __size) 0:03.94 ^ 0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/malloc_decls.h:53:1: note: previous declaration is here 0:03.94 MALLOC_DECL(realloc, void*, void*, size_t) 0:03.94 ^ 0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozilla/mozalloc.h:22:32: note: expanded from macro 'MALLOC_DECL' 0:03.94 MOZ_MEMORY_API return_type name##_impl(__VA_ARGS__); 0:03.94 ^ 0:03.94 <scratch space>:178:1: note: expanded from here 0:03.94 realloc_impl 0:03.94 ^ 0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozmemory_wrap.h:142:41: note: expanded from macro 'realloc_impl' 0:03.94 #define realloc_impl mozmem_malloc_impl(realloc) Which I really didn't feel like digging into. * I had to restore the order of TrustOverrideUtils.h and related files in nss because the .inc files depend on TrustOverrideUtils.h being included earlier. * I had to add a missing include to RollingNumber.h * Also had to partially restore include order in JsepSessionImpl.cpp to avoid some -WError issues due to some static inline functions being defined in a header but not used in the rest of the compilation unit. Differential Revision: https://phabricator.services.mozilla.com/D60327 --HG-- extra : moz-landing-system : lando
2020-01-20 19:19:48 +03:00
#include <new>
#include <type_traits>
Bug 1609996 - Reorder some includes affected by the previous patches. r=froydnj This was done by: This was done by applying: ``` diff --git a/python/mozbuild/mozbuild/code-analysis/mach_commands.py b/python/mozbuild/mozbuild/code-analysis/mach_commands.py index 789affde7bbf..fe33c4c7d4d1 100644 --- a/python/mozbuild/mozbuild/code-analysis/mach_commands.py +++ b/python/mozbuild/mozbuild/code-analysis/mach_commands.py @@ -2007,7 +2007,7 @@ class StaticAnalysis(MachCommandBase): from subprocess import Popen, PIPE, check_output, CalledProcessError diff_process = Popen(self._get_clang_format_diff_command(commit), stdout=PIPE) - args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format] + args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format, '-sort-includes'] if not output_file: args.append("-i") ``` Then running `./mach clang-format -c <commit-hash>` Then undoing that patch. Then running check_spidermonkey_style.py --fixup Then running `./mach clang-format` I had to fix four things: * I needed to move <utility> back down in GuardObjects.h because I was hitting obscure problems with our system include wrappers like this: 0:03.94 /usr/include/stdlib.h:550:14: error: exception specification in declaration does not match previous declaration 0:03.94 extern void *realloc (void *__ptr, size_t __size) 0:03.94 ^ 0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/malloc_decls.h:53:1: note: previous declaration is here 0:03.94 MALLOC_DECL(realloc, void*, void*, size_t) 0:03.94 ^ 0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozilla/mozalloc.h:22:32: note: expanded from macro 'MALLOC_DECL' 0:03.94 MOZ_MEMORY_API return_type name##_impl(__VA_ARGS__); 0:03.94 ^ 0:03.94 <scratch space>:178:1: note: expanded from here 0:03.94 realloc_impl 0:03.94 ^ 0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozmemory_wrap.h:142:41: note: expanded from macro 'realloc_impl' 0:03.94 #define realloc_impl mozmem_malloc_impl(realloc) Which I really didn't feel like digging into. * I had to restore the order of TrustOverrideUtils.h and related files in nss because the .inc files depend on TrustOverrideUtils.h being included earlier. * I had to add a missing include to RollingNumber.h * Also had to partially restore include order in JsepSessionImpl.cpp to avoid some -WError issues due to some static inline functions being defined in a header but not used in the rest of the compilation unit. Differential Revision: https://phabricator.services.mozilla.com/D60327 --HG-- extra : moz-landing-system : lando
2020-01-20 19:19:48 +03:00
#include <utility>
#include "PLDHashTable.h"
#include "mozilla/Assertions.h"
#include "mozilla/Attributes.h"
#include "mozilla/MemoryReporting.h"
#include "mozilla/OperatorNewExtensions.h"
#include "mozilla/PodOperations.h"
Bug 1609996 - Reorder some includes affected by the previous patches. r=froydnj This was done by: This was done by applying: ``` diff --git a/python/mozbuild/mozbuild/code-analysis/mach_commands.py b/python/mozbuild/mozbuild/code-analysis/mach_commands.py index 789affde7bbf..fe33c4c7d4d1 100644 --- a/python/mozbuild/mozbuild/code-analysis/mach_commands.py +++ b/python/mozbuild/mozbuild/code-analysis/mach_commands.py @@ -2007,7 +2007,7 @@ class StaticAnalysis(MachCommandBase): from subprocess import Popen, PIPE, check_output, CalledProcessError diff_process = Popen(self._get_clang_format_diff_command(commit), stdout=PIPE) - args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format] + args = [sys.executable, clang_format_diff, "-p1", "-binary=%s" % clang_format, '-sort-includes'] if not output_file: args.append("-i") ``` Then running `./mach clang-format -c <commit-hash>` Then undoing that patch. Then running check_spidermonkey_style.py --fixup Then running `./mach clang-format` I had to fix four things: * I needed to move <utility> back down in GuardObjects.h because I was hitting obscure problems with our system include wrappers like this: 0:03.94 /usr/include/stdlib.h:550:14: error: exception specification in declaration does not match previous declaration 0:03.94 extern void *realloc (void *__ptr, size_t __size) 0:03.94 ^ 0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/malloc_decls.h:53:1: note: previous declaration is here 0:03.94 MALLOC_DECL(realloc, void*, void*, size_t) 0:03.94 ^ 0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozilla/mozalloc.h:22:32: note: expanded from macro 'MALLOC_DECL' 0:03.94 MOZ_MEMORY_API return_type name##_impl(__VA_ARGS__); 0:03.94 ^ 0:03.94 <scratch space>:178:1: note: expanded from here 0:03.94 realloc_impl 0:03.94 ^ 0:03.94 /home/emilio/src/moz/gecko-2/obj-debug/dist/include/mozmemory_wrap.h:142:41: note: expanded from macro 'realloc_impl' 0:03.94 #define realloc_impl mozmem_malloc_impl(realloc) Which I really didn't feel like digging into. * I had to restore the order of TrustOverrideUtils.h and related files in nss because the .inc files depend on TrustOverrideUtils.h being included earlier. * I had to add a missing include to RollingNumber.h * Also had to partially restore include order in JsepSessionImpl.cpp to avoid some -WError issues due to some static inline functions being defined in a header but not used in the rest of the compilation unit. Differential Revision: https://phabricator.services.mozilla.com/D60327 --HG-- extra : moz-landing-system : lando
2020-01-20 19:19:48 +03:00
#include "mozilla/fallible.h"
#include "nsPointerHashKeys.h"
namespace detail {
// STL-style iterators to allow the use in range-based for loops, e.g.
template <typename T>
class nsTHashtable_base_iterator
: public std::iterator<std::forward_iterator_tag, T, int32_t> {
public:
using
typename std::iterator<std::forward_iterator_tag, T, int32_t>::value_type;
using typename std::iterator<std::forward_iterator_tag, T,
int32_t>::difference_type;
using iterator_type = nsTHashtable_base_iterator;
using const_iterator_type = nsTHashtable_base_iterator<const T>;
using EndIteratorTag = PLDHashTable::Iterator::EndIteratorTag;
nsTHashtable_base_iterator(nsTHashtable_base_iterator&& aOther) = default;
nsTHashtable_base_iterator& operator=(nsTHashtable_base_iterator&& aOther) {
// User-defined because the move assignment operator is deleted in
// PLDHashtable::Iterator.
return operator=(static_cast<const nsTHashtable_base_iterator&>(aOther));
}
nsTHashtable_base_iterator(const nsTHashtable_base_iterator& aOther)
: mIterator{aOther.mIterator.Clone()} {}
nsTHashtable_base_iterator& operator=(
const nsTHashtable_base_iterator& aOther) {
// Since PLDHashTable::Iterator has no assignment operator, we destroy and
// recreate mIterator.
mIterator.~Iterator();
new (&mIterator) PLDHashTable::Iterator(aOther.mIterator.Clone());
return *this;
}
explicit nsTHashtable_base_iterator(PLDHashTable::Iterator aFrom)
: mIterator{std::move(aFrom)} {}
explicit nsTHashtable_base_iterator(const PLDHashTable& aTable)
: mIterator{&const_cast<PLDHashTable&>(aTable)} {}
nsTHashtable_base_iterator(const PLDHashTable& aTable, EndIteratorTag aTag)
: mIterator{&const_cast<PLDHashTable&>(aTable), aTag} {}
bool operator==(const iterator_type& aRhs) const {
return mIterator == aRhs.mIterator;
}
bool operator!=(const iterator_type& aRhs) const { return !(*this == aRhs); }
value_type* operator->() const {
return static_cast<value_type*>(mIterator.Get());
}
value_type& operator*() const {
return *static_cast<value_type*>(mIterator.Get());
}
iterator_type& operator++() {
mIterator.Next();
return *this;
}
iterator_type operator++(int) {
iterator_type it = *this;
++*this;
return it;
}
operator const_iterator_type() const {
return const_iterator_type{mIterator.Clone()};
}
private:
PLDHashTable::Iterator mIterator;
};
} // namespace detail
/**
* a base class for templated hashtables.
*
* Clients will rarely need to use this class directly. Check the derived
* classes first, to see if they will meet your needs.
*
* @param EntryType the templated entry-type class that is managed by the
* hashtable. <code>EntryType</code> must extend the following declaration,
* and <strong>must not declare any virtual functions or derive from classes
* with virtual functions.</strong> Any vtable pointer would break the
* PLDHashTable code.
*<pre> class EntryType : public PLDHashEntryHdr
* {
* public: or friend nsTHashtable<EntryType>;
* // KeyType is what we use when Get()ing or Put()ing this entry
* // this should either be a simple datatype (uint32_t, nsISupports*) or
* // a const reference (const nsAString&)
* typedef something KeyType;
* // KeyTypePointer is the pointer-version of KeyType, because
* // PLDHashTable.h requires keys to cast to <code>const void*</code>
* typedef const something* KeyTypePointer;
*
* EntryType(KeyTypePointer aKey);
*
* // A copy or C++11 Move constructor must be defined, even if
* // AllowMemMove() == true, otherwise you will cause link errors.
* EntryType(const EntryType& aEnt); // Either this...
* EntryType(EntryType&& aEnt); // ...or this
*
* // the destructor must be defined... or you will cause link errors!
* ~EntryType();
*
* // KeyEquals(): does this entry match this key?
* bool KeyEquals(KeyTypePointer aKey) const;
*
* // KeyToPointer(): Convert KeyType to KeyTypePointer
* static KeyTypePointer KeyToPointer(KeyType aKey);
*
* // HashKey(): calculate the hash number
* static PLDHashNumber HashKey(KeyTypePointer aKey);
*
* // ALLOW_MEMMOVE can we move this class with memmove(), or do we have
* // to use the copy constructor?
* enum { ALLOW_MEMMOVE = true/false };
* }</pre>
*
* @see nsInterfaceHashtable
* @see nsDataHashtable
* @see nsClassHashtable
* @author "Benjamin Smedberg <bsmedberg@covad.net>"
*/
template <class EntryType>
class MOZ_NEEDS_NO_VTABLE_TYPE nsTHashtable {
typedef mozilla::fallible_t fallible_t;
static_assert(std::is_pointer_v<typename EntryType::KeyTypePointer>,
"KeyTypePointer should be a pointer");
public:
// Separate constructors instead of default aInitLength parameter since
// otherwise the default no-arg constructor isn't found.
nsTHashtable()
: mTable(Ops(), sizeof(EntryType), PLDHashTable::kDefaultInitialLength) {}
explicit nsTHashtable(uint32_t aInitLength)
: mTable(Ops(), sizeof(EntryType), aInitLength) {}
/**
* destructor, cleans up and deallocates
*/
~nsTHashtable() = default;
nsTHashtable(nsTHashtable<EntryType>&& aOther);
nsTHashtable<EntryType>& operator=(nsTHashtable<EntryType>&& aOther);
/**
* Return the generation number for the table. This increments whenever
* the table data items are moved.
*/
uint32_t GetGeneration() const { return mTable.Generation(); }
/**
* KeyType is typedef'ed for ease of use.
*/
typedef typename EntryType::KeyType KeyType;
/**
* KeyTypePointer is typedef'ed for ease of use.
*/
typedef typename EntryType::KeyTypePointer KeyTypePointer;
/**
* Return the number of entries in the table.
* @return number of entries
*/
uint32_t Count() const { return mTable.EntryCount(); }
/**
* Return true if the hashtable is empty.
*/
bool IsEmpty() const { return Count() == 0; }
/**
* Get the entry associated with a key.
* @param aKey the key to retrieve
* @return pointer to the entry class, if the key exists; nullptr if the
* key doesn't exist
*/
EntryType* GetEntry(KeyType aKey) const {
return static_cast<EntryType*>(
mTable.Search(EntryType::KeyToPointer(aKey)));
}
/**
* Return true if an entry for the given key exists, false otherwise.
* @param aKey the key to retrieve
* @return true if the key exists, false if the key doesn't exist
*/
bool Contains(KeyType aKey) const { return !!GetEntry(aKey); }
/**
* Infallibly get the entry associated with a key, or create a new entry,
* @param aKey the key to retrieve
* @return pointer to the entry retrieved; never nullptr
*/
EntryType* PutEntry(KeyType aKey) {
// infallible add
return static_cast<EntryType*>(mTable.Add(EntryType::KeyToPointer(aKey)));
}
/**
* Fallibly get the entry associated with a key, or create a new entry,
* @param aKey the key to retrieve
* @return pointer to the entry retrieved; nullptr only if memory can't
* be allocated
*/
[[nodiscard]] EntryType* PutEntry(KeyType aKey, const fallible_t&) {
return static_cast<EntryType*>(
mTable.Add(EntryType::KeyToPointer(aKey), mozilla::fallible));
}
/**
* Get the entry associated with a key, or create a new entry using infallible
* allocation and insert that.
* @param aKey the key to retrieve
* @param aEntry will be assigned (if non-null) to the entry that was
* found or created
* @return true if a new entry was created, or false if an existing entry
* was found
*/
[[nodiscard]] bool EnsureInserted(KeyType aKey,
EntryType** aEntry = nullptr) {
auto oldCount = Count();
EntryType* entry = PutEntry(aKey);
if (aEntry) {
*aEntry = entry;
}
return oldCount != Count();
}
/**
* Remove the entry associated with a key.
* @param aKey of the entry to remove
*/
void RemoveEntry(KeyType aKey) {
mTable.Remove(EntryType::KeyToPointer(aKey));
}
/**
* Lookup the entry associated with aKey and remove it if found, otherwise
* do nothing.
* @param aKey of the entry to remove
* @return true if an entry was found and removed, or false if no entry
* was found for aKey
*/
bool EnsureRemoved(KeyType aKey) {
auto* entry = GetEntry(aKey);
if (entry) {
RemoveEntry(entry);
return true;
}
return false;
}
/**
* Remove the entry associated with a key.
* @param aEntry the entry-pointer to remove (obtained from GetEntry)
*/
void RemoveEntry(EntryType* aEntry) { mTable.RemoveEntry(aEntry); }
/**
* Remove the entry associated with a key, but don't resize the hashtable.
* This is a low-level method, and is not recommended unless you know what
* you're doing. If you use it, please add a comment explaining why you
* didn't use RemoveEntry().
* @param aEntry the entry-pointer to remove (obtained from GetEntry)
*/
void RawRemoveEntry(EntryType* aEntry) { mTable.RawRemove(aEntry); }
// This is an iterator that also allows entry removal. Example usage:
//
// for (auto iter = table.Iter(); !iter.Done(); iter.Next()) {
// Entry* entry = iter.Get();
// // ... do stuff with |entry| ...
// // ... possibly call iter.Remove() once ...
// }
//
class Iterator : public PLDHashTable::Iterator {
public:
typedef PLDHashTable::Iterator Base;
explicit Iterator(nsTHashtable* aTable) : Base(&aTable->mTable) {}
Iterator(Iterator&& aOther) : Base(aOther.mTable) {}
~Iterator() = default;
EntryType* Get() const { return static_cast<EntryType*>(Base::Get()); }
private:
Iterator() = delete;
Iterator(const Iterator&) = delete;
Iterator& operator=(const Iterator&) = delete;
Iterator& operator=(const Iterator&&) = delete;
};
Iterator Iter() { return Iterator(this); }
Iterator ConstIter() const {
return Iterator(const_cast<nsTHashtable*>(this));
}
using const_iterator = ::detail::nsTHashtable_base_iterator<const EntryType>;
using iterator = ::detail::nsTHashtable_base_iterator<EntryType>;
iterator begin() { return iterator{mTable}; }
const_iterator begin() const { return const_iterator{mTable}; }
const_iterator cbegin() const { return begin(); }
iterator end() {
return iterator{mTable, typename iterator::EndIteratorTag{}};
}
const_iterator end() const {
return const_iterator{mTable, typename const_iterator::EndIteratorTag{}};
}
const_iterator cend() const { return end(); }
/**
* Remove all entries, return hashtable to "pristine" state. It's
* conceptually the same as calling the destructor and then re-calling the
* constructor.
*/
void Clear() { mTable.Clear(); }
/**
* Measure the size of the table's entry storage. Does *not* measure anything
* hanging off table entries; hence the "Shallow" prefix. To measure that,
* either use SizeOfExcludingThis() or iterate manually over the entries,
* calling SizeOfExcludingThis() on each one.
*
* @param aMallocSizeOf the function used to measure heap-allocated blocks
* @return the measured shallow size of the table
*/
size_t ShallowSizeOfExcludingThis(mozilla::MallocSizeOf aMallocSizeOf) const {
return mTable.ShallowSizeOfExcludingThis(aMallocSizeOf);
}
/**
* Like ShallowSizeOfExcludingThis, but includes sizeof(*this).
*/
size_t ShallowSizeOfIncludingThis(mozilla::MallocSizeOf aMallocSizeOf) const {
return aMallocSizeOf(this) + ShallowSizeOfExcludingThis(aMallocSizeOf);
}
/**
* This is a "deep" measurement of the table. To use it, |EntryType| must
* define SizeOfExcludingThis, and that method will be called on all live
* entries.
*/
size_t SizeOfExcludingThis(mozilla::MallocSizeOf aMallocSizeOf) const {
size_t n = ShallowSizeOfExcludingThis(aMallocSizeOf);
for (auto iter = ConstIter(); !iter.Done(); iter.Next()) {
n += (*iter.Get()).SizeOfExcludingThis(aMallocSizeOf);
}
return n;
}
/**
* Like SizeOfExcludingThis, but includes sizeof(*this).
*/
size_t SizeOfIncludingThis(mozilla::MallocSizeOf aMallocSizeOf) const {
return aMallocSizeOf(this) + SizeOfExcludingThis(aMallocSizeOf);
}
/**
* Swap the elements in this hashtable with the elements in aOther.
*/
void SwapElements(nsTHashtable<EntryType>& aOther) {
MOZ_ASSERT_IF(this->mTable.Ops() && aOther.mTable.Ops(),
this->mTable.Ops() == aOther.mTable.Ops());
std::swap(this->mTable, aOther.mTable);
}
/**
* Mark the table as constant after initialization.
*
* This will prevent assertions when a read-only hash is accessed on multiple
* threads without synchronization.
*/
void MarkImmutable() { mTable.MarkImmutable(); }
protected:
PLDHashTable mTable;
static PLDHashNumber s_HashKey(const void* aKey);
static bool s_MatchEntry(const PLDHashEntryHdr* aEntry, const void* aKey);
static void s_CopyEntry(PLDHashTable* aTable, const PLDHashEntryHdr* aFrom,
PLDHashEntryHdr* aTo);
2005-08-11 23:43:02 +04:00
static void s_ClearEntry(PLDHashTable* aTable, PLDHashEntryHdr* aEntry);
static void s_InitEntry(PLDHashEntryHdr* aEntry, const void* aKey);
private:
// copy constructor, not implemented
nsTHashtable(nsTHashtable<EntryType>& aToCopy) = delete;
/**
* Gets the table's ops.
*/
static const PLDHashTableOps* Ops();
// assignment operator, not implemented
nsTHashtable<EntryType>& operator=(nsTHashtable<EntryType>& aToEqual) =
delete;
};
namespace mozilla {
namespace detail {
// Like PLDHashTable::MoveEntryStub, but specialized for fixed N (i.e. the size
// of the entries in the hashtable). Saves a memory read to figure out the size
// from the table and gives the compiler the opportunity to inline the memcpy.
//
// We define this outside of nsTHashtable so only one copy exists for every N,
// rather than separate copies for every EntryType used with nsTHashtable.
template <size_t N>
static void FixedSizeEntryMover(PLDHashTable*, const PLDHashEntryHdr* aFrom,
PLDHashEntryHdr* aTo) {
memcpy(aTo, aFrom, N);
}
} // namespace detail
} // namespace mozilla
//
// template definitions
//
template <class EntryType>
nsTHashtable<EntryType>::nsTHashtable(nsTHashtable<EntryType>&& aOther)
: mTable(std::move(aOther.mTable)) {}
template <class EntryType>
nsTHashtable<EntryType>& nsTHashtable<EntryType>::operator=(
nsTHashtable<EntryType>&& aOther) {
mTable = std::move(aOther.mTable);
return *this;
}
template <class EntryType>
/* static */ const PLDHashTableOps* nsTHashtable<EntryType>::Ops() {
// If this variable is a global variable, we get strange start-up failures on
// WindowsCrtPatch.h (see bug 1166598 comment 20). But putting it inside a
// function avoids that problem.
static const PLDHashTableOps sOps = {
s_HashKey, s_MatchEntry,
EntryType::ALLOW_MEMMOVE
? mozilla::detail::FixedSizeEntryMover<sizeof(EntryType)>
: s_CopyEntry,
s_ClearEntry, s_InitEntry};
return &sOps;
}
// static definitions
template <class EntryType>
PLDHashNumber nsTHashtable<EntryType>::s_HashKey(const void* aKey) {
return EntryType::HashKey(static_cast<KeyTypePointer>(aKey));
}
template <class EntryType>
bool nsTHashtable<EntryType>::s_MatchEntry(const PLDHashEntryHdr* aEntry,
const void* aKey) {
return (static_cast<const EntryType*>(aEntry))
->KeyEquals(static_cast<KeyTypePointer>(aKey));
}
template <class EntryType>
void nsTHashtable<EntryType>::s_CopyEntry(PLDHashTable* aTable,
const PLDHashEntryHdr* aFrom,
PLDHashEntryHdr* aTo) {
Bug 1599160 - Fix build error with nsTHashtable<const SheetLoadDataHashKey>. r=froydnj Trying to use nsTHashtable<SheetLoadDataHashKey> yields the following error: 0:01.28 /home/emilio/src/moz/gecko-2/obj-debug-no-sccache/dist/include/nsTHashtable.h:288:8: error: multiple overloads of 'RemoveEntry' instantiate to the same signature 'void (mozilla::SheetLoadDataHashKey *)' 0:01.28 void RemoveEntry(EntryType* aEntry) { mTable.RemoveEntry(aEntry); } 0:01.28 ^ 0:01.28 /home/emilio/src/moz/gecko-2/obj-debug-no-sccache/dist/include/mozilla/css/Loader.h:600:38: note: in instantiation of template class 'nsTHashtable<mozilla::SheetLoadDataHashKey>' requested here 0:01.28 nsTHashtable<SheetLoadDataHashKey> mLoadsPerformed; 0:01.28 ^ 0:01.28 /home/emilio/src/moz/gecko-2/obj-debug-no-sccache/dist/include/nsTHashtable.h:264:8: note: previous declaration is here 0:01.28 void RemoveEntry(KeyType aKey) { I tried and failed to std::enable_if my way to victory, but then realized I could probably use nsTHashtable<const SheetLoadDataHashKey>, so that the compiler wouldn't complain about the overload (they're identical, so they don't really matter). But doesn't work either, unless I have this patch, because: 0:12.57 /home/emilio/src/moz/gecko-2/obj-debug-no-sccache/dist/include/nsTHashtable.h:504:36: error: call to implicitly-deleted copy constructor of 'const mozilla::SheetLoadDataHashKey' 0:12.57 new (mozilla::KnownNotNull, aTo) EntryType(std::move(*fromEntry)); 0:12.57 ^ ~~~~~~~~~~~~~~~~~~~~~ 0:12.57 /home/emilio/src/moz/gecko-2/obj-debug-no-sccache/dist/include/nsTHashtable.h:478:13: note: in instantiation of member function 'nsTHashtable<const mozilla::SheetLoadDataHashKey>::s_CopyEntry' requested here 0:12.57 : s_CopyEntry, 0:12.57 ^ 0:12.57 /home/emilio/src/moz/gecko-2/obj-debug-no-sccache/dist/include/nsTHashtable.h:163:16: note: in instantiation of member function 'nsTHashtable<const mozilla::SheetLoadDataHashKey>::Ops' requested here 0:12.57 : mTable(Ops(), sizeof(EntryType), PLDHashTable::kDefaultInitialLength) {} 0:12.57 ^ 0:12.57 /home/emilio/src/moz/gecko-2/layout/style/Loader.cpp:359:9: note: in instantiation of member function 'nsTHashtable<const mozilla::SheetLoadDataHashKey>::nsTHashtable' requested here 0:12.57 Loader::Loader() 0:12.57 ^ 0:12.57 /home/emilio/src/moz/gecko-2/obj-debug-no-sccache/dist/include/mozilla/css/Loader.h:97:3: note: copy constructor is implicitly deleted because 'SheetLoadDataHashKey' has a user-declared move constructor 0:12.57 SheetLoadDataHashKey(SheetLoadDataHashKey&& toMove) 0:12.57 ^ 0:13.08 1 error generated This one was easier to fix though. Not too proud of this one. Differential Revision: https://phabricator.services.mozilla.com/D77830
2020-06-02 20:02:51 +03:00
auto* fromEntry = const_cast<std::remove_const_t<EntryType>*>(
static_cast<const EntryType*>(aFrom));
new (mozilla::KnownNotNull, aTo) EntryType(std::move(*fromEntry));
fromEntry->~EntryType();
}
template <class EntryType>
void nsTHashtable<EntryType>::s_ClearEntry(PLDHashTable* aTable,
PLDHashEntryHdr* aEntry) {
static_cast<EntryType*>(aEntry)->~EntryType();
}
template <class EntryType>
void nsTHashtable<EntryType>::s_InitEntry(PLDHashEntryHdr* aEntry,
const void* aKey) {
new (mozilla::KnownNotNull, aEntry)
EntryType(static_cast<KeyTypePointer>(aKey));
}
class nsCycleCollectionTraversalCallback;
template <class EntryType>
inline void ImplCycleCollectionUnlink(nsTHashtable<EntryType>& aField) {
aField.Clear();
}
template <class EntryType>
inline void ImplCycleCollectionTraverse(
nsCycleCollectionTraversalCallback& aCallback,
nsTHashtable<EntryType>& aField, const char* aName, uint32_t aFlags = 0) {
for (auto iter = aField.Iter(); !iter.Done(); iter.Next()) {
EntryType* entry = iter.Get();
ImplCycleCollectionTraverse(aCallback, *entry, aName, aFlags);
}
}
/**
* For nsTHashtable with pointer entries, we can have a template specialization
* that layers a typed T* interface on top of a common implementation that
* works internally with void pointers. This arrangement saves code size and
* might slightly improve performance as well.
*/
/**
* We need a separate entry type class for the inheritance structure of the
* nsTHashtable specialization below; nsVoidPtrHashKey is simply typedefed to a
* specialization of nsPtrHashKey, and the formulation:
*
* class nsTHashtable<nsPtrHashKey<T>> :
* protected nsTHashtable<nsPtrHashKey<const void>
*
* is not going to turn out very well, since we'd wind up with an nsTHashtable
* instantiation that is its own base class.
*/
namespace detail {
class VoidPtrHashKey : public nsPtrHashKey<const void> {
typedef nsPtrHashKey<const void> Base;
public:
explicit VoidPtrHashKey(const void* aKey) : Base(aKey) {}
};
} // namespace detail
/**
* See the main nsTHashtable documentation for descriptions of this class's
* methods.
*/
template <typename T>
class nsTHashtable<nsPtrHashKey<T>>
: protected nsTHashtable<::detail::VoidPtrHashKey> {
typedef nsTHashtable<::detail::VoidPtrHashKey> Base;
typedef nsPtrHashKey<T> EntryType;
// We play games with reinterpret_cast'ing between these two classes, so
// try to ensure that playing said games is reasonable.
static_assert(sizeof(nsPtrHashKey<T>) == sizeof(::detail::VoidPtrHashKey),
"hash keys must be the same size");
nsTHashtable(const nsTHashtable& aOther) = delete;
nsTHashtable& operator=(const nsTHashtable& aOther) = delete;
public:
nsTHashtable() = default;
explicit nsTHashtable(uint32_t aInitLength) : Base(aInitLength) {}
~nsTHashtable() = default;
nsTHashtable(nsTHashtable&&) = default;
using Base::Clear;
using Base::Count;
using Base::GetGeneration;
using Base::IsEmpty;
using Base::MarkImmutable;
using Base::ShallowSizeOfExcludingThis;
using Base::ShallowSizeOfIncludingThis;
/* Wrapper functions */
EntryType* GetEntry(T* aKey) const {
return reinterpret_cast<EntryType*>(Base::GetEntry(aKey));
}
bool Contains(T* aKey) const { return Base::Contains(aKey); }
EntryType* PutEntry(T* aKey) {
return reinterpret_cast<EntryType*>(Base::PutEntry(aKey));
}
[[nodiscard]] EntryType* PutEntry(T* aKey, const mozilla::fallible_t&) {
return reinterpret_cast<EntryType*>(
Base::PutEntry(aKey, mozilla::fallible));
}
[[nodiscard]] bool EnsureInserted(T* aKey, EntryType** aEntry = nullptr) {
return Base::EnsureInserted(
aKey, reinterpret_cast<::detail::VoidPtrHashKey**>(aEntry));
}
void RemoveEntry(T* aKey) { Base::RemoveEntry(aKey); }
bool EnsureRemoved(T* aKey) { return Base::EnsureRemoved(aKey); }
void RemoveEntry(EntryType* aEntry) {
Base::RemoveEntry(reinterpret_cast<::detail::VoidPtrHashKey*>(aEntry));
}
void RawRemoveEntry(EntryType* aEntry) {
Base::RawRemoveEntry(reinterpret_cast<::detail::VoidPtrHashKey*>(aEntry));
}
class Iterator : public Base::Iterator {
public:
typedef nsTHashtable::Base::Iterator Base;
explicit Iterator(nsTHashtable* aTable) : Base(aTable) {}
Iterator(Iterator&& aOther) : Base(std::move(aOther)) {}
~Iterator() = default;
EntryType* Get() const { return reinterpret_cast<EntryType*>(Base::Get()); }
private:
Iterator() = delete;
Iterator(const Iterator&) = delete;
Iterator& operator=(const Iterator&) = delete;
Iterator& operator=(Iterator&&) = delete;
};
Iterator Iter() { return Iterator(this); }
Iterator ConstIter() const {
return Iterator(const_cast<nsTHashtable*>(this));
}
using const_iterator = ::detail::nsTHashtable_base_iterator<const EntryType>;
using iterator = ::detail::nsTHashtable_base_iterator<EntryType>;
iterator begin() { return iterator{mTable}; }
const_iterator begin() const { return const_iterator{mTable}; }
const_iterator cbegin() const { return begin(); }
iterator end() {
return iterator{mTable, typename iterator::EndIteratorTag{}};
}
const_iterator end() const {
return const_iterator{mTable, typename const_iterator::EndIteratorTag{}};
}
const_iterator cend() const { return end(); }
void SwapElements(nsTHashtable& aOther) { Base::SwapElements(aOther); }
};
#endif // nsTHashtable_h__