Bug 1435717 - Make calling WidgetEvent::PreventDefault*() stop cross process forwarding too r=smaug
Currently, if an event is consumed in the main process, EventStateManager
does not send it to remote process. However, this is unexpected behavior
for some WidgetKeyboardEvent dispatchers. OS sometimes has consumed native
key events before sending applications. For example, Alt key on Windows
should activate menu bar of focused window but Alt key may be consumed before
focused window receives the event. In such case, we mark Alt keyboard event
as "consumed before dispatch", and chrome treat it like as its preventDefault()
is called in web content. (Note that for compatibility with other browsers,
the consumed state is not exposed to web content. So, Event.defaultPrevented
returns false in web content.)
Therefore, we need to treat "consumed" state and "cross process forwarding"
state separately. This patch makes calling WidgetEvent::PreventDefault()
always stops cross process forwarding for backward compatibility. Additionally,
for the special case mentioned above, this patch makes
WidgetEvent::PreventDefaultBeforeDispatch() take additional argument,
|aIfStopCrossProcessForwarding|. If this is CrossProcessForwarding::eStop,
the event won't be sent to remote process as same as calling PreventDefault().
Otherwise, CrossProcessForwarding::eHold, PreventDefaultBeforeDispatch() call
does not change "cross process forwarding" state. I.e., if the event's
StopCrossProcessForwarding() and PreventDefault() are not called until
EventStateManager::PostHandleEvent(), the event will be sent to remote process
as usual.
MozReview-Commit-ID: IQGWJvXetxV
--HG--
extra : rebase_source : 4ccdd500e80b8fe29e469ac3b85578e1c07c8358
2018-06-25 12:17:18 +03:00
|
|
|
[test_AltGr_key_events_in_web_content_on_windows.html]
|
|
|
|
|
skip-if = toolkit != 'windows' || headless # headless: Bug 1410525
|
2019-04-05 11:15:15 +03:00
|
|
|
[test_actionhint.html]
|
2013-12-08 19:51:16 +04:00
|
|
|
[test_assign_event_data.html]
|
2019-05-01 11:16:44 +03:00
|
|
|
skip-if = toolkit == "cocoa" || (toolkit == 'android' && debug) || android_version == '24' || (headless && os == "win") # Mac: Bug 933303, Android bug 1285414
|
2020-09-15 17:27:00 +03:00
|
|
|
[test_autocapitalize.html]
|
2018-05-23 16:27:17 +03:00
|
|
|
[test_keypress_event_with_alt_on_mac.html]
|
|
|
|
|
skip-if = toolkit != "cocoa"
|
2020-05-26 16:11:45 +03:00
|
|
|
[test_mouse_event_with_control_on_mac.html]
|
2021-06-15 21:24:18 +03:00
|
|
|
skip-if =
|
|
|
|
|
toolkit != "cocoa"
|
|
|
|
|
fission && xorigin # Bug 1716413 - New fission platform triage
|
2013-11-28 18:04:21 +04:00
|
|
|
[test_picker_no_crash.html]
|
2016-04-26 04:45:46 +03:00
|
|
|
skip-if = toolkit != "windows" || e10s # Bug 1267491
|
2013-11-28 18:04:21 +04:00
|
|
|
support-files = window_picker_no_crash_child.html
|
2018-05-29 09:37:35 +03:00
|
|
|
[test_scrollbar_colors.html]
|
2019-10-15 18:07:09 +03:00
|
|
|
skip-if = (os == 'linux' && headless) # bug 1460109
|
