mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность
gecko-dev/widget/CommandList.h

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

172 строки
8.4 KiB
C
Исходник Обычный вид История

Bug 977959 part.1 Define constants for each command which may be caused by native key bindings r=roc
2014-03-14 17:13:30 +04:00
/* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
/**
Bug 1403759 - part 2: Handle edit/selection commands like insertNewline: in TextInputHandler::HandleCommand() r=m_kato Let's make TextInputHandler::HandleCommand() handle other commands which are caused by Backspace, Delete, Tab, ArrowUp, ArrowDown, ArrowRight, ArrowLeft, PageUp, PageDown, Home, End and Escape keys with various modifiers. This patch makes Korean users can do most key operation in editor even with composing Hangul character. Note that this patch has a hack for cancelOperation: command. The command is typically fired for Escape key press. However, it's also fired for Command + Period. Unfortunately, this behavior is really odd if subclass of NSResponder implements |void cancelOperation:(id)sender|. If it's implemented, Cocoa doesn't call its |void keyDown:(NSEvent)theEvent|. Instead, it calls only |void doCommandBySelector:(SEL)aSelector| and |void cancelOperation:(id)sender| when Command + Period is pressed. Therefore, we cannot dispatch keydown nor keypress event for this key combination if we implement it. Therefore, this patch doesn't implement the method but handle it in doCommandBySelector even though the super class of ChildView cannot handle the command with this path. MozReview-Commit-ID: 4hS23SiwNJv --HG-- extra : rebase_source : 38ac1ea494b5f786ecd5c9327efbacd460b59faf
2017-12-02 08:53:10 +03:00
* Define NS_DEFINE_COMMAND(aName, aCommandStr) before including this.
Bug 977959 part.1 Define constants for each command which may be caused by native key bindings r=roc
2014-03-14 17:13:30 +04:00
* @param aName The name useful in C++ of the command.
* @param aCommandStr The command string in JS.
Bug 1403759 - part 2: Handle edit/selection commands like insertNewline: in TextInputHandler::HandleCommand() r=m_kato Let's make TextInputHandler::HandleCommand() handle other commands which are caused by Backspace, Delete, Tab, ArrowUp, ArrowDown, ArrowRight, ArrowLeft, PageUp, PageDown, Home, End and Escape keys with various modifiers. This patch makes Korean users can do most key operation in editor even with composing Hangul character. Note that this patch has a hack for cancelOperation: command. The command is typically fired for Escape key press. However, it's also fired for Command + Period. Unfortunately, this behavior is really odd if subclass of NSResponder implements |void cancelOperation:(id)sender|. If it's implemented, Cocoa doesn't call its |void keyDown:(NSEvent)theEvent|. Instead, it calls only |void doCommandBySelector:(SEL)aSelector| and |void cancelOperation:(id)sender| when Command + Period is pressed. Therefore, we cannot dispatch keydown nor keypress event for this key combination if we implement it. Therefore, this patch doesn't implement the method but handle it in doCommandBySelector even though the super class of ChildView cannot handle the command with this path. MozReview-Commit-ID: 4hS23SiwNJv --HG-- extra : rebase_source : 38ac1ea494b5f786ecd5c9327efbacd460b59faf
2017-12-02 08:53:10 +03:00
*
Bug 1546839 - part 2: Define commands which are handled by editor r=smaug `NS_DEFINE_COMMAND_WITH_PARAM` macro is special case for `cmd_align`. `cmd_align` can be mapped to multiple `Command` values. It's distinguished with additional parameter, '"left"', '"right"', '"center"' or '"justify"'. Therefore, we cannot map from XUL command to `Command` value simply with hashtable created by the next patch. So, this new macro is necessary for the next patch to ignore this special case. The used commands are listed up from: * [converted from `execCommand`, `cmd_bold` - `cmd_superscript`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2066-2071) * [converted from `execCommand`, `cmd_undo` - `cmd_redo`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2078-2079) * [converted from `execCommand`, `cmd_paragraphState` - `cmd_outdent`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2080-2081,2105-2106) * [converted from `execCommand`, `cmd_align`s](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2095-2098) * [converted from `execCommand`, `cmd_highlight` - `cmd_decreaseFont`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2082-2088) * [converted from `execCommand`, `cmd_insertHR` - `cmd_ul`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2089-2093,2101-2102) * [converted from `execCommand`, `cmd_getContents` - `cmd_enableAbsolutePositionEditing`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2094,2099-2100,2107-2113) * [internal commands, `obs_documentCreated` - `obs_documentWillBeDestroyed`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#26-28) * [internal command, `cmd_abbr`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#68) * [internal command, `cmd_absPos`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#102) * [internal commands, `cmd_acronym` - `cmd_var`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#58,63,65-67,69-72) * [internal commands, `cmd_dd` - `cmd_dt`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#78-79) * [internal commands, `cmd_moveDown` - `cmd_selectUp2`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/EditorController.cpp#97-112) * [internal command, `cmd_setDocumentModified`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#31) Differential Revision: https://phabricator.services.mozilla.com/D29171 --HG-- extra : moz-landing-system : lando
2019-04-30 09:04:01 +03:00
* Define NS_DEFINE_COMMAND_WITH_PARAM(aName, aCommandStr, aParam) before
* including this.
* @param aName The name useful in C++ of the command.
* @param aCommandStr The command string in JS, but this may be shared with
* other aName values. I.e., cannot map aName and
* aCommandStr 1:1.
* @param aParam Additional param value. When aCommandStr is executed,
* this value is also specified. I.e., aName becomes
* unique when you look for with both aCommandStr and
* aParam.
*
Bug 1403759 - part 2: Handle edit/selection commands like insertNewline: in TextInputHandler::HandleCommand() r=m_kato Let's make TextInputHandler::HandleCommand() handle other commands which are caused by Backspace, Delete, Tab, ArrowUp, ArrowDown, ArrowRight, ArrowLeft, PageUp, PageDown, Home, End and Escape keys with various modifiers. This patch makes Korean users can do most key operation in editor even with composing Hangul character. Note that this patch has a hack for cancelOperation: command. The command is typically fired for Escape key press. However, it's also fired for Command + Period. Unfortunately, this behavior is really odd if subclass of NSResponder implements |void cancelOperation:(id)sender|. If it's implemented, Cocoa doesn't call its |void keyDown:(NSEvent)theEvent|. Instead, it calls only |void doCommandBySelector:(SEL)aSelector| and |void cancelOperation:(id)sender| when Command + Period is pressed. Therefore, we cannot dispatch keydown nor keypress event for this key combination if we implement it. Therefore, this patch doesn't implement the method but handle it in doCommandBySelector even though the super class of ChildView cannot handle the command with this path. MozReview-Commit-ID: 4hS23SiwNJv --HG-- extra : rebase_source : 38ac1ea494b5f786ecd5c9327efbacd460b59faf
2017-12-02 08:53:10 +03:00
* Define NS_DEFINE_COMMAND_NO_EXEC_COMMAND(aName) before including this.
* @param aName The name useful in C++ of the command.
Bug 977959 part.1 Define constants for each command which may be caused by native key bindings r=roc
2014-03-14 17:13:30 +04:00
*/
Bug 1546839 - part 2: Define commands which are handled by editor r=smaug `NS_DEFINE_COMMAND_WITH_PARAM` macro is special case for `cmd_align`. `cmd_align` can be mapped to multiple `Command` values. It's distinguished with additional parameter, '"left"', '"right"', '"center"' or '"justify"'. Therefore, we cannot map from XUL command to `Command` value simply with hashtable created by the next patch. So, this new macro is necessary for the next patch to ignore this special case. The used commands are listed up from: * [converted from `execCommand`, `cmd_bold` - `cmd_superscript`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2066-2071) * [converted from `execCommand`, `cmd_undo` - `cmd_redo`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2078-2079) * [converted from `execCommand`, `cmd_paragraphState` - `cmd_outdent`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2080-2081,2105-2106) * [converted from `execCommand`, `cmd_align`s](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2095-2098) * [converted from `execCommand`, `cmd_highlight` - `cmd_decreaseFont`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2082-2088) * [converted from `execCommand`, `cmd_insertHR` - `cmd_ul`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2089-2093,2101-2102) * [converted from `execCommand`, `cmd_getContents` - `cmd_enableAbsolutePositionEditing`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2094,2099-2100,2107-2113) * [internal commands, `obs_documentCreated` - `obs_documentWillBeDestroyed`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#26-28) * [internal command, `cmd_abbr`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#68) * [internal command, `cmd_absPos`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#102) * [internal commands, `cmd_acronym` - `cmd_var`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#58,63,65-67,69-72) * [internal commands, `cmd_dd` - `cmd_dt`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#78-79) * [internal commands, `cmd_moveDown` - `cmd_selectUp2`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/EditorController.cpp#97-112) * [internal command, `cmd_setDocumentModified`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#31) Differential Revision: https://phabricator.services.mozilla.com/D29171 --HG-- extra : moz-landing-system : lando
2019-04-30 09:04:01 +03:00
// Mapped from commands of some platforms
Bug 977959 part.1 Define constants for each command which may be caused by native key bindings r=roc
2014-03-14 17:13:30 +04:00
NS_DEFINE_COMMAND(BeginLine, cmd_beginLine)
NS_DEFINE_COMMAND(CharNext, cmd_charNext)
NS_DEFINE_COMMAND(CharPrevious, cmd_charPrevious)
NS_DEFINE_COMMAND(Copy, cmd_copy)
NS_DEFINE_COMMAND(Cut, cmd_cut)
NS_DEFINE_COMMAND(Delete, cmd_delete)
NS_DEFINE_COMMAND(DeleteCharBackward, cmd_deleteCharBackward)
NS_DEFINE_COMMAND(DeleteCharForward, cmd_deleteCharForward)
NS_DEFINE_COMMAND(DeleteToBeginningOfLine, cmd_deleteToBeginningOfLine)
NS_DEFINE_COMMAND(DeleteToEndOfLine, cmd_deleteToEndOfLine)
NS_DEFINE_COMMAND(DeleteWordBackward, cmd_deleteWordBackward)
NS_DEFINE_COMMAND(DeleteWordForward, cmd_deleteWordForward)
NS_DEFINE_COMMAND(EndLine, cmd_endLine)
Bug 1403759 - part 1: Make TextInputHandler::InsertNewline() treat other commands r=m_kato Currently, we handle insertNewline: of NSResponder with TextInputHandler::InsertNewline(). However, its implementation is useful for handling some other commands. So, let's rename it to HandleCommand() and make it take Command as its argument for handling specific behavior of each command. MozReview-Commit-ID: GgzQdTlVtYl --HG-- extra : rebase_source : e1d1c8617897d29eb10ba62708e3549a77c6ee59
2017-12-02 04:46:31 +03:00
NS_DEFINE_COMMAND(InsertParagraph, cmd_insertParagraph)
NS_DEFINE_COMMAND(InsertLineBreak, cmd_insertLineBreak)
Bug 977959 part.1 Define constants for each command which may be caused by native key bindings r=roc
2014-03-14 17:13:30 +04:00
NS_DEFINE_COMMAND(LineNext, cmd_lineNext)
NS_DEFINE_COMMAND(LinePrevious, cmd_linePrevious)
NS_DEFINE_COMMAND(MoveBottom, cmd_moveBottom)
NS_DEFINE_COMMAND(MovePageDown, cmd_movePageDown)
NS_DEFINE_COMMAND(MovePageUp, cmd_movePageUp)
NS_DEFINE_COMMAND(MoveTop, cmd_moveTop)
NS_DEFINE_COMMAND(Paste, cmd_paste)
NS_DEFINE_COMMAND(ScrollBottom, cmd_scrollBottom)
Bug 1357365 - part 3: Make `TypeInState::OnSelectionChange()` stop keeping link style if caret is positioned at edge of a link element and not moved in the link r=m_kato,edgar Although different from the other browsers' behavior, our traditional behavior might be better than them because the behavior on the other browser does not allow users to insert new content at start nor end of a link. However, we can relax more about keeping traditional behavior for web-compat. Perhaps, only when caret is moved from the other side of first or last character in the link and moves caret to the edge of the link with arrow key, we should allow users to modify the link text. Otherwise, e.g., `Home` and `End` key press should make it stop keeping the link style. This helps advanced users who are familiar with keyboard navigatin in editor. Note that this patch also changes the condition which checks `aReason & nsISelectionListener::KEYPRESS_REASON` to check also `nsISelectionListener::COLLAPSETO_START_REASON` and `nsISelectionListener::COLLAPSETO_END_REASON` because all of them are set by `nsFrameSelection::MoveCaret` exclusively. https://searchfox.org/mozilla-central/rev/a0ccd492719b1ad2106f6456549be62a76f45acb/layout/generic/nsFrameSelection.cpp#738,741,745 Therefore, they should be treated as same as a key press. Note that they are also set by `Selection::CollapseToStart` and `Selection::CollapseToEnd` too. But a following patch will add a new reason to notify selection listeners of caused by JS. So, the problem will be fixed by the following patch. Differential Revision: https://phabricator.services.mozilla.com/D101002
2021-01-13 04:55:29 +03:00
NS_DEFINE_COMMAND(ScrollLeft, cmd_scrollLeft)
Bug 977959 part.1 Define constants for each command which may be caused by native key bindings r=roc
2014-03-14 17:13:30 +04:00
NS_DEFINE_COMMAND(ScrollLineDown, cmd_scrollLineDown)
NS_DEFINE_COMMAND(ScrollLineUp, cmd_scrollLineUp)
NS_DEFINE_COMMAND(ScrollPageDown, cmd_scrollPageDown)
NS_DEFINE_COMMAND(ScrollPageUp, cmd_scrollPageUp)
Bug 1357365 - part 3: Make `TypeInState::OnSelectionChange()` stop keeping link style if caret is positioned at edge of a link element and not moved in the link r=m_kato,edgar Although different from the other browsers' behavior, our traditional behavior might be better than them because the behavior on the other browser does not allow users to insert new content at start nor end of a link. However, we can relax more about keeping traditional behavior for web-compat. Perhaps, only when caret is moved from the other side of first or last character in the link and moves caret to the edge of the link with arrow key, we should allow users to modify the link text. Otherwise, e.g., `Home` and `End` key press should make it stop keeping the link style. This helps advanced users who are familiar with keyboard navigatin in editor. Note that this patch also changes the condition which checks `aReason & nsISelectionListener::KEYPRESS_REASON` to check also `nsISelectionListener::COLLAPSETO_START_REASON` and `nsISelectionListener::COLLAPSETO_END_REASON` because all of them are set by `nsFrameSelection::MoveCaret` exclusively. https://searchfox.org/mozilla-central/rev/a0ccd492719b1ad2106f6456549be62a76f45acb/layout/generic/nsFrameSelection.cpp#738,741,745 Therefore, they should be treated as same as a key press. Note that they are also set by `Selection::CollapseToStart` and `Selection::CollapseToEnd` too. But a following patch will add a new reason to notify selection listeners of caused by JS. So, the problem will be fixed by the following patch. Differential Revision: https://phabricator.services.mozilla.com/D101002
2021-01-13 04:55:29 +03:00
NS_DEFINE_COMMAND(ScrollRight, cmd_scrollRight)
Bug 977959 part.1 Define constants for each command which may be caused by native key bindings r=roc
2014-03-14 17:13:30 +04:00
NS_DEFINE_COMMAND(ScrollTop, cmd_scrollTop)
NS_DEFINE_COMMAND(SelectAll, cmd_selectAll)
NS_DEFINE_COMMAND(SelectBeginLine, cmd_selectBeginLine)
NS_DEFINE_COMMAND(SelectBottom, cmd_selectBottom)
NS_DEFINE_COMMAND(SelectCharNext, cmd_selectCharNext)
NS_DEFINE_COMMAND(SelectCharPrevious, cmd_selectCharPrevious)
NS_DEFINE_COMMAND(SelectEndLine, cmd_selectEndLine)
NS_DEFINE_COMMAND(SelectLineNext, cmd_selectLineNext)
NS_DEFINE_COMMAND(SelectLinePrevious, cmd_selectLinePrevious)
NS_DEFINE_COMMAND(SelectPageDown, cmd_selectPageDown)
NS_DEFINE_COMMAND(SelectPageUp, cmd_selectPageUp)
NS_DEFINE_COMMAND(SelectTop, cmd_selectTop)
NS_DEFINE_COMMAND(SelectWordNext, cmd_selectWordNext)
NS_DEFINE_COMMAND(SelectWordPrevious, cmd_selectWordPrevious)
NS_DEFINE_COMMAND(WordNext, cmd_wordNext)
NS_DEFINE_COMMAND(WordPrevious, cmd_wordPrevious)
Bug 1403759 - part 2: Handle edit/selection commands like insertNewline: in TextInputHandler::HandleCommand() r=m_kato Let's make TextInputHandler::HandleCommand() handle other commands which are caused by Backspace, Delete, Tab, ArrowUp, ArrowDown, ArrowRight, ArrowLeft, PageUp, PageDown, Home, End and Escape keys with various modifiers. This patch makes Korean users can do most key operation in editor even with composing Hangul character. Note that this patch has a hack for cancelOperation: command. The command is typically fired for Escape key press. However, it's also fired for Command + Period. Unfortunately, this behavior is really odd if subclass of NSResponder implements |void cancelOperation:(id)sender|. If it's implemented, Cocoa doesn't call its |void keyDown:(NSEvent)theEvent|. Instead, it calls only |void doCommandBySelector:(SEL)aSelector| and |void cancelOperation:(id)sender| when Command + Period is pressed. Therefore, we cannot dispatch keydown nor keypress event for this key combination if we implement it. Therefore, this patch doesn't implement the method but handle it in doCommandBySelector even though the super class of ChildView cannot handle the command with this path. MozReview-Commit-ID: 4hS23SiwNJv --HG-- extra : rebase_source : 38ac1ea494b5f786ecd5c9327efbacd460b59faf
2017-12-02 08:53:10 +03:00
Bug 1546839 - part 2: Define commands which are handled by editor r=smaug `NS_DEFINE_COMMAND_WITH_PARAM` macro is special case for `cmd_align`. `cmd_align` can be mapped to multiple `Command` values. It's distinguished with additional parameter, '"left"', '"right"', '"center"' or '"justify"'. Therefore, we cannot map from XUL command to `Command` value simply with hashtable created by the next patch. So, this new macro is necessary for the next patch to ignore this special case. The used commands are listed up from: * [converted from `execCommand`, `cmd_bold` - `cmd_superscript`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2066-2071) * [converted from `execCommand`, `cmd_undo` - `cmd_redo`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2078-2079) * [converted from `execCommand`, `cmd_paragraphState` - `cmd_outdent`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2080-2081,2105-2106) * [converted from `execCommand`, `cmd_align`s](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2095-2098) * [converted from `execCommand`, `cmd_highlight` - `cmd_decreaseFont`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2082-2088) * [converted from `execCommand`, `cmd_insertHR` - `cmd_ul`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2089-2093,2101-2102) * [converted from `execCommand`, `cmd_getContents` - `cmd_enableAbsolutePositionEditing`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2094,2099-2100,2107-2113) * [internal commands, `obs_documentCreated` - `obs_documentWillBeDestroyed`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#26-28) * [internal command, `cmd_abbr`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#68) * [internal command, `cmd_absPos`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#102) * [internal commands, `cmd_acronym` - `cmd_var`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#58,63,65-67,69-72) * [internal commands, `cmd_dd` - `cmd_dt`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#78-79) * [internal commands, `cmd_moveDown` - `cmd_selectUp2`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/EditorController.cpp#97-112) * [internal command, `cmd_setDocumentModified`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#31) Differential Revision: https://phabricator.services.mozilla.com/D29171 --HG-- extra : moz-landing-system : lando
2019-04-30 09:04:01 +03:00
// We don't have corresponding commands for them, but some platforms have them.
Bug 1403759 - part 2: Handle edit/selection commands like insertNewline: in TextInputHandler::HandleCommand() r=m_kato Let's make TextInputHandler::HandleCommand() handle other commands which are caused by Backspace, Delete, Tab, ArrowUp, ArrowDown, ArrowRight, ArrowLeft, PageUp, PageDown, Home, End and Escape keys with various modifiers. This patch makes Korean users can do most key operation in editor even with composing Hangul character. Note that this patch has a hack for cancelOperation: command. The command is typically fired for Escape key press. However, it's also fired for Command + Period. Unfortunately, this behavior is really odd if subclass of NSResponder implements |void cancelOperation:(id)sender|. If it's implemented, Cocoa doesn't call its |void keyDown:(NSEvent)theEvent|. Instead, it calls only |void doCommandBySelector:(SEL)aSelector| and |void cancelOperation:(id)sender| when Command + Period is pressed. Therefore, we cannot dispatch keydown nor keypress event for this key combination if we implement it. Therefore, this patch doesn't implement the method but handle it in doCommandBySelector even though the super class of ChildView cannot handle the command with this path. MozReview-Commit-ID: 4hS23SiwNJv --HG-- extra : rebase_source : 38ac1ea494b5f786ecd5c9327efbacd460b59faf
2017-12-02 08:53:10 +03:00
NS_DEFINE_COMMAND_NO_EXEC_COMMAND(CancelOperation)
NS_DEFINE_COMMAND_NO_EXEC_COMMAND(Complete)
NS_DEFINE_COMMAND_NO_EXEC_COMMAND(InsertBacktab)
NS_DEFINE_COMMAND_NO_EXEC_COMMAND(InsertTab)
Bug 1546839 - part 2: Define commands which are handled by editor r=smaug `NS_DEFINE_COMMAND_WITH_PARAM` macro is special case for `cmd_align`. `cmd_align` can be mapped to multiple `Command` values. It's distinguished with additional parameter, '"left"', '"right"', '"center"' or '"justify"'. Therefore, we cannot map from XUL command to `Command` value simply with hashtable created by the next patch. So, this new macro is necessary for the next patch to ignore this special case. The used commands are listed up from: * [converted from `execCommand`, `cmd_bold` - `cmd_superscript`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2066-2071) * [converted from `execCommand`, `cmd_undo` - `cmd_redo`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2078-2079) * [converted from `execCommand`, `cmd_paragraphState` - `cmd_outdent`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2080-2081,2105-2106) * [converted from `execCommand`, `cmd_align`s](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2095-2098) * [converted from `execCommand`, `cmd_highlight` - `cmd_decreaseFont`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2082-2088) * [converted from `execCommand`, `cmd_insertHR` - `cmd_ul`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2089-2093,2101-2102) * [converted from `execCommand`, `cmd_getContents` - `cmd_enableAbsolutePositionEditing`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2094,2099-2100,2107-2113) * [internal commands, `obs_documentCreated` - `obs_documentWillBeDestroyed`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#26-28) * [internal command, `cmd_abbr`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#68) * [internal command, `cmd_absPos`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#102) * [internal commands, `cmd_acronym` - `cmd_var`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#58,63,65-67,69-72) * [internal commands, `cmd_dd` - `cmd_dt`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#78-79) * [internal commands, `cmd_moveDown` - `cmd_selectUp2`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/EditorController.cpp#97-112) * [internal command, `cmd_setDocumentModified`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#31) Differential Revision: https://phabricator.services.mozilla.com/D29171 --HG-- extra : moz-landing-system : lando
2019-04-30 09:04:01 +03:00
// Commands mapped from HTMLDocument.execCommand()
NS_DEFINE_COMMAND(FormatBold, cmd_bold)
NS_DEFINE_COMMAND(FormatItalic, cmd_italic)
NS_DEFINE_COMMAND(FormatUnderline, cmd_underline)
NS_DEFINE_COMMAND(FormatStrikeThrough, cmd_strikethrough)
NS_DEFINE_COMMAND(FormatSubscript, cmd_subscript)
NS_DEFINE_COMMAND(FormatSuperscript, cmd_superscript)
NS_DEFINE_COMMAND(HistoryUndo, cmd_undo)
NS_DEFINE_COMMAND(HistoryRedo, cmd_redo)
Bug 1244437 - part 1: Make `HTMLEditUtils::IsFormatNode` check same tags as Chromium does r=m_kato I realized that our `HTMLEditUtils::IsFormatNode` is not maintained different from the other browsers. Therefore, only we do not check new elements defined after HTML 4.01. This patch aligns the list of the format elements to the others [1]. Then, this also changes some expectations of `editing/run/formatblock.html` to align common behavior of the browsers. Note that we mapped `formatBlock` of `execCommand` to `cmd_paragraphState`, and the XUL command handles `<blockquote>` in a different path [2] and the behavior is pretty different from the other formatBlock command implementations. Therefore, this patch creates new command for `formatBlock` and makes `HTMLEditor` switch behavior in any places. 1. https://source.chromium.org/chromium/chromium/src/+/ba50f40fc4a203df704dc697d6e72469da8c5019:third_party/WebKit/WebCore/editing/FormatBlockCommand.cpp;l=114-134 2. https://searchfox.org/mozilla-central/rev/6602bdf9fff5020fbc8e248c963ddddf09a77b1b/editor/libeditor/HTMLEditor.cpp#2461-2474 Differential Revision: https://phabricator.services.mozilla.com/D190900
2023-10-26 06:45:17 +03:00
NS_DEFINE_COMMAND(FormatBlock, cmd_formatBlock)
Bug 1546839 - part 2: Define commands which are handled by editor r=smaug `NS_DEFINE_COMMAND_WITH_PARAM` macro is special case for `cmd_align`. `cmd_align` can be mapped to multiple `Command` values. It's distinguished with additional parameter, '"left"', '"right"', '"center"' or '"justify"'. Therefore, we cannot map from XUL command to `Command` value simply with hashtable created by the next patch. So, this new macro is necessary for the next patch to ignore this special case. The used commands are listed up from: * [converted from `execCommand`, `cmd_bold` - `cmd_superscript`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2066-2071) * [converted from `execCommand`, `cmd_undo` - `cmd_redo`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2078-2079) * [converted from `execCommand`, `cmd_paragraphState` - `cmd_outdent`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2080-2081,2105-2106) * [converted from `execCommand`, `cmd_align`s](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2095-2098) * [converted from `execCommand`, `cmd_highlight` - `cmd_decreaseFont`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2082-2088) * [converted from `execCommand`, `cmd_insertHR` - `cmd_ul`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2089-2093,2101-2102) * [converted from `execCommand`, `cmd_getContents` - `cmd_enableAbsolutePositionEditing`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2094,2099-2100,2107-2113) * [internal commands, `obs_documentCreated` - `obs_documentWillBeDestroyed`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#26-28) * [internal command, `cmd_abbr`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#68) * [internal command, `cmd_absPos`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#102) * [internal commands, `cmd_acronym` - `cmd_var`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#58,63,65-67,69-72) * [internal commands, `cmd_dd` - `cmd_dt`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#78-79) * [internal commands, `cmd_moveDown` - `cmd_selectUp2`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/EditorController.cpp#97-112) * [internal command, `cmd_setDocumentModified`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#31) Differential Revision: https://phabricator.services.mozilla.com/D29171 --HG-- extra : moz-landing-system : lando
2019-04-30 09:04:01 +03:00
NS_DEFINE_COMMAND(FormatIndent, cmd_indent)
NS_DEFINE_COMMAND(FormatOutdent, cmd_outdent)
NS_DEFINE_COMMAND_WITH_PARAM(FormatJustifyLeft, cmd_align, left)
NS_DEFINE_COMMAND_WITH_PARAM(FormatJustifyRight, cmd_align, right)
NS_DEFINE_COMMAND_WITH_PARAM(FormatJustifyCenter, cmd_align, center)
NS_DEFINE_COMMAND_WITH_PARAM(FormatJustifyFull, cmd_align, justify)
NS_DEFINE_COMMAND(FormatBackColor, cmd_highlight)
NS_DEFINE_COMMAND(FormatFontColor, cmd_fontColor)
NS_DEFINE_COMMAND(FormatFontName, cmd_fontFace)
NS_DEFINE_COMMAND(FormatFontSize, cmd_fontSize)
NS_DEFINE_COMMAND(FormatIncreaseFontSize, cmd_increaseFont)
NS_DEFINE_COMMAND(FormatDecreaseFontSize, cmd_decreaseFont)
NS_DEFINE_COMMAND(InsertHorizontalRule, cmd_insertHR)
NS_DEFINE_COMMAND(InsertLink, cmd_insertLinkNoUI)
NS_DEFINE_COMMAND(InsertImage, cmd_insertImageNoUI)
NS_DEFINE_COMMAND(InsertHTML, cmd_insertHTML)
NS_DEFINE_COMMAND(InsertText, cmd_insertText)
NS_DEFINE_COMMAND(InsertOrderedList, cmd_ol)
NS_DEFINE_COMMAND(InsertUnorderedList, cmd_ul)
NS_DEFINE_COMMAND(FormatRemove, cmd_removeStyles)
NS_DEFINE_COMMAND(FormatRemoveLink, cmd_removeLinks)
NS_DEFINE_COMMAND(SetDocumentUseCSS, cmd_setDocumentUseCSS)
NS_DEFINE_COMMAND(SetDocumentReadOnly, cmd_setDocumentReadOnly)
NS_DEFINE_COMMAND(SetDocumentInsertBROnEnterKeyPress, cmd_insertBrOnReturn)
NS_DEFINE_COMMAND(SetDocumentDefaultParagraphSeparator,
cmd_defaultParagraphSeparator)
NS_DEFINE_COMMAND(ToggleObjectResizers, cmd_enableObjectResizing)
NS_DEFINE_COMMAND(ToggleInlineTableEditor, cmd_enableInlineTableEditing)
NS_DEFINE_COMMAND(ToggleAbsolutePositionEditor,
cmd_enableAbsolutePositionEditing)
Bug 1810663 - Add Gecko specific command to enable new join/split node direction r=smaug,m_kato This API is temporarily available and useful for web app developers who want to stop supporting Gecko specific join/split direction handling as soon as possible and who do not want Mozilla block their release schedule by rescheduling of shipping the new behavior. Additionally, adding this command allows web apps detects whether Gecko supports the new behavior and whether it's enabled. On the other hand, We don't want to ship opt-out API because it's hard to keep maintaining the legacy behavior specific paths. Therefore, the command does nothing if web app calls `Document.execCommand("enableCompatibleJoinSplitDirection", false "false")` if the new behavior is enabled by default. Differential Revision: https://phabricator.services.mozilla.com/D172351
2023-03-22 02:58:04 +03:00
NS_DEFINE_COMMAND(EnableCompatibleJoinSplitNodeDirection,
cmd_enableCompatibleJoinSplitNodeDirection)
Bug 1546839 - part 2: Define commands which are handled by editor r=smaug `NS_DEFINE_COMMAND_WITH_PARAM` macro is special case for `cmd_align`. `cmd_align` can be mapped to multiple `Command` values. It's distinguished with additional parameter, '"left"', '"right"', '"center"' or '"justify"'. Therefore, we cannot map from XUL command to `Command` value simply with hashtable created by the next patch. So, this new macro is necessary for the next patch to ignore this special case. The used commands are listed up from: * [converted from `execCommand`, `cmd_bold` - `cmd_superscript`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2066-2071) * [converted from `execCommand`, `cmd_undo` - `cmd_redo`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2078-2079) * [converted from `execCommand`, `cmd_paragraphState` - `cmd_outdent`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2080-2081,2105-2106) * [converted from `execCommand`, `cmd_align`s](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2095-2098) * [converted from `execCommand`, `cmd_highlight` - `cmd_decreaseFont`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2082-2088) * [converted from `execCommand`, `cmd_insertHR` - `cmd_ul`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2089-2093,2101-2102) * [converted from `execCommand`, `cmd_getContents` - `cmd_enableAbsolutePositionEditing`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2094,2099-2100,2107-2113) * [internal commands, `obs_documentCreated` - `obs_documentWillBeDestroyed`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#26-28) * [internal command, `cmd_abbr`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#68) * [internal command, `cmd_absPos`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#102) * [internal commands, `cmd_acronym` - `cmd_var`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#58,63,65-67,69-72) * [internal commands, `cmd_dd` - `cmd_dt`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#78-79) * [internal commands, `cmd_moveDown` - `cmd_selectUp2`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/EditorController.cpp#97-112) * [internal command, `cmd_setDocumentModified`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#31) Differential Revision: https://phabricator.services.mozilla.com/D29171 --HG-- extra : moz-landing-system : lando
2019-04-30 09:04:01 +03:00
// Commands not mapped from HTMLDocument.execCommand() but available with
// command dispatcher and handled in editor.
Bug 1549661 - part 1: Create `EditorCommand::DoCommandParam(Command aCommand, TextEditor& aTextEditor)` and make it just call `DoCommand()` r=m_kato Most `EditorCommand` classes don't require additional params for executing a command. All of them just calls their `DoCommand()` or returns same result. So, we can create new virtual method, `EditorCommand::DoCommandParam(Command aCommand, TextEditor& aTextEditor)`, which just delegates to `DoCommand()`. This patch adds some undeclared commands but which are handled by `EditorCommand` subclasses, and changes `CommandInt` type from `int8_t` to `uint8_t` since the count of `Command` items becomes over 128. Differential Revision: https://phabricator.services.mozilla.com/D30495 --HG-- extra : moz-landing-system : lando
2019-05-21 10:44:11 +03:00
NS_DEFINE_COMMAND(CutOrDelete, cmd_cutOrDelete)
NS_DEFINE_COMMAND(CopyOrDelete, cmd_copyOrDelete)
Bug 1546839 - part 2: Define commands which are handled by editor r=smaug `NS_DEFINE_COMMAND_WITH_PARAM` macro is special case for `cmd_align`. `cmd_align` can be mapped to multiple `Command` values. It's distinguished with additional parameter, '"left"', '"right"', '"center"' or '"justify"'. Therefore, we cannot map from XUL command to `Command` value simply with hashtable created by the next patch. So, this new macro is necessary for the next patch to ignore this special case. The used commands are listed up from: * [converted from `execCommand`, `cmd_bold` - `cmd_superscript`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2066-2071) * [converted from `execCommand`, `cmd_undo` - `cmd_redo`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2078-2079) * [converted from `execCommand`, `cmd_paragraphState` - `cmd_outdent`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2080-2081,2105-2106) * [converted from `execCommand`, `cmd_align`s](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2095-2098) * [converted from `execCommand`, `cmd_highlight` - `cmd_decreaseFont`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2082-2088) * [converted from `execCommand`, `cmd_insertHR` - `cmd_ul`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2089-2093,2101-2102) * [converted from `execCommand`, `cmd_getContents` - `cmd_enableAbsolutePositionEditing`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2094,2099-2100,2107-2113) * [internal commands, `obs_documentCreated` - `obs_documentWillBeDestroyed`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#26-28) * [internal command, `cmd_abbr`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#68) * [internal command, `cmd_absPos`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#102) * [internal commands, `cmd_acronym` - `cmd_var`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#58,63,65-67,69-72) * [internal commands, `cmd_dd` - `cmd_dt`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#78-79) * [internal commands, `cmd_moveDown` - `cmd_selectUp2`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/EditorController.cpp#97-112) * [internal command, `cmd_setDocumentModified`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#31) Differential Revision: https://phabricator.services.mozilla.com/D29171 --HG-- extra : moz-landing-system : lando
2019-04-30 09:04:01 +03:00
NS_DEFINE_COMMAND(EditorObserverDocumentCreated, obs_documentCreated)
NS_DEFINE_COMMAND(EditorObserverDocumentLocationChanged,
obs_documentLocationChanged)
NS_DEFINE_COMMAND(EditorObserverDocumentWillBeDestroyed,
obs_documentWillBeDestroyed)
NS_DEFINE_COMMAND(FormatAbbreviation, cmd_abbr)
NS_DEFINE_COMMAND(FormatAbsolutePosition, cmd_absPos)
NS_DEFINE_COMMAND(FormatAcronym, cmd_acronym)
NS_DEFINE_COMMAND(FormatCitation, cmd_cite)
NS_DEFINE_COMMAND(FormatCode, cmd_code)
Bug 1549661 - part 1: Create `EditorCommand::DoCommandParam(Command aCommand, TextEditor& aTextEditor)` and make it just call `DoCommand()` r=m_kato Most `EditorCommand` classes don't require additional params for executing a command. All of them just calls their `DoCommand()` or returns same result. So, we can create new virtual method, `EditorCommand::DoCommandParam(Command aCommand, TextEditor& aTextEditor)`, which just delegates to `DoCommand()`. This patch adds some undeclared commands but which are handled by `EditorCommand` subclasses, and changes `CommandInt` type from `int8_t` to `uint8_t` since the count of `Command` items becomes over 128. Differential Revision: https://phabricator.services.mozilla.com/D30495 --HG-- extra : moz-landing-system : lando
2019-05-21 10:44:11 +03:00
NS_DEFINE_COMMAND(FormatDecreaseZIndex, cmd_decreaseZIndex)
Bug 1549661 - part 5: Make commands for `MultiStateCommandBase` take both `CString` and `String` r=m_kato Only `MultiStateCommandBase::DoCommandParams()` allows `CString` param and `String` param (the former is preferred). This patch makes `EditorCommand::DoCommandParams()` aware of this case. Differential Revision: https://phabricator.services.mozilla.com/D30499 --HG-- extra : moz-landing-system : lando
2019-05-21 10:47:47 +03:00
NS_DEFINE_COMMAND(FormatDocumentBackgroundColor, cmd_backgroundColor)
Bug 1546839 - part 2: Define commands which are handled by editor r=smaug `NS_DEFINE_COMMAND_WITH_PARAM` macro is special case for `cmd_align`. `cmd_align` can be mapped to multiple `Command` values. It's distinguished with additional parameter, '"left"', '"right"', '"center"' or '"justify"'. Therefore, we cannot map from XUL command to `Command` value simply with hashtable created by the next patch. So, this new macro is necessary for the next patch to ignore this special case. The used commands are listed up from: * [converted from `execCommand`, `cmd_bold` - `cmd_superscript`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2066-2071) * [converted from `execCommand`, `cmd_undo` - `cmd_redo`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2078-2079) * [converted from `execCommand`, `cmd_paragraphState` - `cmd_outdent`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2080-2081,2105-2106) * [converted from `execCommand`, `cmd_align`s](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2095-2098) * [converted from `execCommand`, `cmd_highlight` - `cmd_decreaseFont`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2082-2088) * [converted from `execCommand`, `cmd_insertHR` - `cmd_ul`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2089-2093,2101-2102) * [converted from `execCommand`, `cmd_getContents` - `cmd_enableAbsolutePositionEditing`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2094,2099-2100,2107-2113) * [internal commands, `obs_documentCreated` - `obs_documentWillBeDestroyed`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#26-28) * [internal command, `cmd_abbr`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#68) * [internal command, `cmd_absPos`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#102) * [internal commands, `cmd_acronym` - `cmd_var`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#58,63,65-67,69-72) * [internal commands, `cmd_dd` - `cmd_dt`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#78-79) * [internal commands, `cmd_moveDown` - `cmd_selectUp2`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/EditorController.cpp#97-112) * [internal command, `cmd_setDocumentModified`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#31) Differential Revision: https://phabricator.services.mozilla.com/D29171 --HG-- extra : moz-landing-system : lando
2019-04-30 09:04:01 +03:00
NS_DEFINE_COMMAND(FormatEmphasis, cmd_em)
Bug 1549661 - part 1: Create `EditorCommand::DoCommandParam(Command aCommand, TextEditor& aTextEditor)` and make it just call `DoCommand()` r=m_kato Most `EditorCommand` classes don't require additional params for executing a command. All of them just calls their `DoCommand()` or returns same result. So, we can create new virtual method, `EditorCommand::DoCommandParam(Command aCommand, TextEditor& aTextEditor)`, which just delegates to `DoCommand()`. This patch adds some undeclared commands but which are handled by `EditorCommand` subclasses, and changes `CommandInt` type from `int8_t` to `uint8_t` since the count of `Command` items becomes over 128. Differential Revision: https://phabricator.services.mozilla.com/D30495 --HG-- extra : moz-landing-system : lando
2019-05-21 10:44:11 +03:00
NS_DEFINE_COMMAND(FormatIncreaseZIndex, cmd_increaseZIndex)
Bug 1555227 - Make GetInternalCommand() return new commands when the command is "cmd_align" without params r=m_kato `cmd_align` is always with `nsCommandParams` when it's executed. However, when somebody checks whether the command is enabled or not, or retrieves the state, `GetInternalCommand()` is called without `nsCommandParams`. Therefore, even when `nsCommandParmas` is nullptr for `cmd_align`, `GetInternalCommand()` shouldn't warn it. Additionally, internal command supports to set `align` to empty string. Therefore, `GetInternalCommand()` also needs to support it. This patch adds `Command::FormatJustify` for the former case and `Command::FormatJustifyNone` for the latter case. Note that this does not affect to actual behavior since `AlignCommand` does not refer the result of `GetInternalCommand()`. Differential Revision: https://phabricator.services.mozilla.com/D33604 --HG-- extra : moz-landing-system : lando
2019-06-04 13:01:31 +03:00
NS_DEFINE_COMMAND(FormatJustify, cmd_align) // Only for getting enabled/state
NS_DEFINE_COMMAND(FormatJustifyNone, cmd_align) // with empty string or params
Bug 1546839 - part 2: Define commands which are handled by editor r=smaug `NS_DEFINE_COMMAND_WITH_PARAM` macro is special case for `cmd_align`. `cmd_align` can be mapped to multiple `Command` values. It's distinguished with additional parameter, '"left"', '"right"', '"center"' or '"justify"'. Therefore, we cannot map from XUL command to `Command` value simply with hashtable created by the next patch. So, this new macro is necessary for the next patch to ignore this special case. The used commands are listed up from: * [converted from `execCommand`, `cmd_bold` - `cmd_superscript`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2066-2071) * [converted from `execCommand`, `cmd_undo` - `cmd_redo`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2078-2079) * [converted from `execCommand`, `cmd_paragraphState` - `cmd_outdent`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2080-2081,2105-2106) * [converted from `execCommand`, `cmd_align`s](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2095-2098) * [converted from `execCommand`, `cmd_highlight` - `cmd_decreaseFont`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2082-2088) * [converted from `execCommand`, `cmd_insertHR` - `cmd_ul`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2089-2093,2101-2102) * [converted from `execCommand`, `cmd_getContents` - `cmd_enableAbsolutePositionEditing`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2094,2099-2100,2107-2113) * [internal commands, `obs_documentCreated` - `obs_documentWillBeDestroyed`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#26-28) * [internal command, `cmd_abbr`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#68) * [internal command, `cmd_absPos`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#102) * [internal commands, `cmd_acronym` - `cmd_var`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#58,63,65-67,69-72) * [internal commands, `cmd_dd` - `cmd_dt`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#78-79) * [internal commands, `cmd_moveDown` - `cmd_selectUp2`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/EditorController.cpp#97-112) * [internal command, `cmd_setDocumentModified`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#31) Differential Revision: https://phabricator.services.mozilla.com/D29171 --HG-- extra : moz-landing-system : lando
2019-04-30 09:04:01 +03:00
NS_DEFINE_COMMAND(FormatNoBreak, cmd_nobreak)
Bug 1549661 - part 1: Create `EditorCommand::DoCommandParam(Command aCommand, TextEditor& aTextEditor)` and make it just call `DoCommand()` r=m_kato Most `EditorCommand` classes don't require additional params for executing a command. All of them just calls their `DoCommand()` or returns same result. So, we can create new virtual method, `EditorCommand::DoCommandParam(Command aCommand, TextEditor& aTextEditor)`, which just delegates to `DoCommand()`. This patch adds some undeclared commands but which are handled by `EditorCommand` subclasses, and changes `CommandInt` type from `int8_t` to `uint8_t` since the count of `Command` items becomes over 128. Differential Revision: https://phabricator.services.mozilla.com/D30495 --HG-- extra : moz-landing-system : lando
2019-05-21 10:44:11 +03:00
NS_DEFINE_COMMAND(FormatRemoveList, cmd_removeList)
Bug 1546839 - part 2: Define commands which are handled by editor r=smaug `NS_DEFINE_COMMAND_WITH_PARAM` macro is special case for `cmd_align`. `cmd_align` can be mapped to multiple `Command` values. It's distinguished with additional parameter, '"left"', '"right"', '"center"' or '"justify"'. Therefore, we cannot map from XUL command to `Command` value simply with hashtable created by the next patch. So, this new macro is necessary for the next patch to ignore this special case. The used commands are listed up from: * [converted from `execCommand`, `cmd_bold` - `cmd_superscript`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2066-2071) * [converted from `execCommand`, `cmd_undo` - `cmd_redo`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2078-2079) * [converted from `execCommand`, `cmd_paragraphState` - `cmd_outdent`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2080-2081,2105-2106) * [converted from `execCommand`, `cmd_align`s](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2095-2098) * [converted from `execCommand`, `cmd_highlight` - `cmd_decreaseFont`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2082-2088) * [converted from `execCommand`, `cmd_insertHR` - `cmd_ul`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2089-2093,2101-2102) * [converted from `execCommand`, `cmd_getContents` - `cmd_enableAbsolutePositionEditing`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2094,2099-2100,2107-2113) * [internal commands, `obs_documentCreated` - `obs_documentWillBeDestroyed`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#26-28) * [internal command, `cmd_abbr`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#68) * [internal command, `cmd_absPos`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#102) * [internal commands, `cmd_acronym` - `cmd_var`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#58,63,65-67,69-72) * [internal commands, `cmd_dd` - `cmd_dt`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#78-79) * [internal commands, `cmd_moveDown` - `cmd_selectUp2`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/EditorController.cpp#97-112) * [internal command, `cmd_setDocumentModified`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#31) Differential Revision: https://phabricator.services.mozilla.com/D29171 --HG-- extra : moz-landing-system : lando
2019-04-30 09:04:01 +03:00
NS_DEFINE_COMMAND(FormatSample, cmd_samp)
Bug 1549661 - part 1: Create `EditorCommand::DoCommandParam(Command aCommand, TextEditor& aTextEditor)` and make it just call `DoCommand()` r=m_kato Most `EditorCommand` classes don't require additional params for executing a command. All of them just calls their `DoCommand()` or returns same result. So, we can create new virtual method, `EditorCommand::DoCommandParam(Command aCommand, TextEditor& aTextEditor)`, which just delegates to `DoCommand()`. This patch adds some undeclared commands but which are handled by `EditorCommand` subclasses, and changes `CommandInt` type from `int8_t` to `uint8_t` since the count of `Command` items becomes over 128. Differential Revision: https://phabricator.services.mozilla.com/D30495 --HG-- extra : moz-landing-system : lando
2019-05-21 10:44:11 +03:00
NS_DEFINE_COMMAND(FormatSetBlockTextDirection, cmd_switchTextDirection)
Bug 1546839 - part 2: Define commands which are handled by editor r=smaug `NS_DEFINE_COMMAND_WITH_PARAM` macro is special case for `cmd_align`. `cmd_align` can be mapped to multiple `Command` values. It's distinguished with additional parameter, '"left"', '"right"', '"center"' or '"justify"'. Therefore, we cannot map from XUL command to `Command` value simply with hashtable created by the next patch. So, this new macro is necessary for the next patch to ignore this special case. The used commands are listed up from: * [converted from `execCommand`, `cmd_bold` - `cmd_superscript`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2066-2071) * [converted from `execCommand`, `cmd_undo` - `cmd_redo`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2078-2079) * [converted from `execCommand`, `cmd_paragraphState` - `cmd_outdent`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2080-2081,2105-2106) * [converted from `execCommand`, `cmd_align`s](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2095-2098) * [converted from `execCommand`, `cmd_highlight` - `cmd_decreaseFont`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2082-2088) * [converted from `execCommand`, `cmd_insertHR` - `cmd_ul`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2089-2093,2101-2102) * [converted from `execCommand`, `cmd_getContents` - `cmd_enableAbsolutePositionEditing`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2094,2099-2100,2107-2113) * [internal commands, `obs_documentCreated` - `obs_documentWillBeDestroyed`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#26-28) * [internal command, `cmd_abbr`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#68) * [internal command, `cmd_absPos`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#102) * [internal commands, `cmd_acronym` - `cmd_var`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#58,63,65-67,69-72) * [internal commands, `cmd_dd` - `cmd_dt`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#78-79) * [internal commands, `cmd_moveDown` - `cmd_selectUp2`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/EditorController.cpp#97-112) * [internal command, `cmd_setDocumentModified`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#31) Differential Revision: https://phabricator.services.mozilla.com/D29171 --HG-- extra : moz-landing-system : lando
2019-04-30 09:04:01 +03:00
NS_DEFINE_COMMAND(FormatStrong, cmd_strong)
NS_DEFINE_COMMAND(FormatTeletypeText, cmd_tt)
NS_DEFINE_COMMAND(FormatVariable, cmd_var)
NS_DEFINE_COMMAND(InsertDefinitionDetails, cmd_dd)
NS_DEFINE_COMMAND(InsertDefinitionTerm, cmd_dt)
NS_DEFINE_COMMAND(MoveDown, cmd_moveDown)
NS_DEFINE_COMMAND(MoveDown2, cmd_moveDown2)
NS_DEFINE_COMMAND(MoveLeft, cmd_moveLeft)
NS_DEFINE_COMMAND(MoveLeft2, cmd_moveLeft2)
NS_DEFINE_COMMAND(MoveRight, cmd_moveRight)
NS_DEFINE_COMMAND(MoveRight2, cmd_moveRight2)
NS_DEFINE_COMMAND(MoveUp, cmd_moveUp)
NS_DEFINE_COMMAND(MoveUp2, cmd_moveUp2)
Bug 1244437 - part 1: Make `HTMLEditUtils::IsFormatNode` check same tags as Chromium does r=m_kato I realized that our `HTMLEditUtils::IsFormatNode` is not maintained different from the other browsers. Therefore, only we do not check new elements defined after HTML 4.01. This patch aligns the list of the format elements to the others [1]. Then, this also changes some expectations of `editing/run/formatblock.html` to align common behavior of the browsers. Note that we mapped `formatBlock` of `execCommand` to `cmd_paragraphState`, and the XUL command handles `<blockquote>` in a different path [2] and the behavior is pretty different from the other formatBlock command implementations. Therefore, this patch creates new command for `formatBlock` and makes `HTMLEditor` switch behavior in any places. 1. https://source.chromium.org/chromium/chromium/src/+/ba50f40fc4a203df704dc697d6e72469da8c5019:third_party/WebKit/WebCore/editing/FormatBlockCommand.cpp;l=114-134 2. https://searchfox.org/mozilla-central/rev/6602bdf9fff5020fbc8e248c963ddddf09a77b1b/editor/libeditor/HTMLEditor.cpp#2461-2474 Differential Revision: https://phabricator.services.mozilla.com/D190900
2023-10-26 06:45:17 +03:00
NS_DEFINE_COMMAND(ParagraphState, cmd_paragraphState)
Bug 1549661 - part 1: Create `EditorCommand::DoCommandParam(Command aCommand, TextEditor& aTextEditor)` and make it just call `DoCommand()` r=m_kato Most `EditorCommand` classes don't require additional params for executing a command. All of them just calls their `DoCommand()` or returns same result. So, we can create new virtual method, `EditorCommand::DoCommandParam(Command aCommand, TextEditor& aTextEditor)`, which just delegates to `DoCommand()`. This patch adds some undeclared commands but which are handled by `EditorCommand` subclasses, and changes `CommandInt` type from `int8_t` to `uint8_t` since the count of `Command` items becomes over 128. Differential Revision: https://phabricator.services.mozilla.com/D30495 --HG-- extra : moz-landing-system : lando
2019-05-21 10:44:11 +03:00
NS_DEFINE_COMMAND(PasteAsQuotation, cmd_pasteQuote)
Bug 1549661 - part 6: Create `EditorCommand::DoCommandParam(Command aCommand, nsITransferable* aTransferableParam, TextEditor& aTextEditor)` r=m_kato If `nsIControllerCommand::DoCommandParams()` is called without aParams or `nsITransferable` pointer, this patch sets nullptr to `aTransferableParam` for `DoCommandParam()`. This allows each implementation to choose ignore or return error. Differential Revision: https://phabricator.services.mozilla.com/D30500 --HG-- extra : moz-landing-system : lando
2019-05-21 10:47:49 +03:00
NS_DEFINE_COMMAND(PasteTransferable, cmd_pasteTransferable)
Bug 1549661 - part 1: Create `EditorCommand::DoCommandParam(Command aCommand, TextEditor& aTextEditor)` and make it just call `DoCommand()` r=m_kato Most `EditorCommand` classes don't require additional params for executing a command. All of them just calls their `DoCommand()` or returns same result. So, we can create new virtual method, `EditorCommand::DoCommandParam(Command aCommand, TextEditor& aTextEditor)`, which just delegates to `DoCommand()`. This patch adds some undeclared commands but which are handled by `EditorCommand` subclasses, and changes `CommandInt` type from `int8_t` to `uint8_t` since the count of `Command` items becomes over 128. Differential Revision: https://phabricator.services.mozilla.com/D30495 --HG-- extra : moz-landing-system : lando
2019-05-21 10:44:11 +03:00
NS_DEFINE_COMMAND(PasteWithoutFormat, cmd_pasteNoFormatting)
Bug 1546839 - part 2: Define commands which are handled by editor r=smaug `NS_DEFINE_COMMAND_WITH_PARAM` macro is special case for `cmd_align`. `cmd_align` can be mapped to multiple `Command` values. It's distinguished with additional parameter, '"left"', '"right"', '"center"' or '"justify"'. Therefore, we cannot map from XUL command to `Command` value simply with hashtable created by the next patch. So, this new macro is necessary for the next patch to ignore this special case. The used commands are listed up from: * [converted from `execCommand`, `cmd_bold` - `cmd_superscript`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2066-2071) * [converted from `execCommand`, `cmd_undo` - `cmd_redo`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2078-2079) * [converted from `execCommand`, `cmd_paragraphState` - `cmd_outdent`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2080-2081,2105-2106) * [converted from `execCommand`, `cmd_align`s](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2095-2098) * [converted from `execCommand`, `cmd_highlight` - `cmd_decreaseFont`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2082-2088) * [converted from `execCommand`, `cmd_insertHR` - `cmd_ul`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2089-2093,2101-2102) * [converted from `execCommand`, `cmd_getContents` - `cmd_enableAbsolutePositionEditing`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/dom/html/nsHTMLDocument.cpp#2094,2099-2100,2107-2113) * [internal commands, `obs_documentCreated` - `obs_documentWillBeDestroyed`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#26-28) * [internal command, `cmd_abbr`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#68) * [internal command, `cmd_absPos`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#102) * [internal commands, `cmd_acronym` - `cmd_var`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#58,63,65-67,69-72) * [internal commands, `cmd_dd` - `cmd_dt`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#78-79) * [internal commands, `cmd_moveDown` - `cmd_selectUp2`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/EditorController.cpp#97-112) * [internal command, `cmd_setDocumentModified`](https://searchfox.org/mozilla-central/rev/b756e6d00728dda4121f8278a744381d8643317a/editor/libeditor/HTMLEditorController.cpp#31) Differential Revision: https://phabricator.services.mozilla.com/D29171 --HG-- extra : moz-landing-system : lando
2019-04-30 09:04:01 +03:00
NS_DEFINE_COMMAND(SelectDown, cmd_selectDown)
NS_DEFINE_COMMAND(SelectDown2, cmd_selectDown2)
NS_DEFINE_COMMAND(SelectLeft, cmd_selectLeft)
NS_DEFINE_COMMAND(SelectLeft2, cmd_selectLeft2)
NS_DEFINE_COMMAND(SelectRight, cmd_selectRight)
NS_DEFINE_COMMAND(SelectRight2, cmd_selectRight2)
NS_DEFINE_COMMAND(SelectUp, cmd_selectUp)
NS_DEFINE_COMMAND(SelectUp2, cmd_selectUp2)
NS_DEFINE_COMMAND(SetDocumentModified, cmd_setDocumentModified)