1999-09-06 23:16:25 +04:00
|
|
|
/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*-
|
|
|
|
*
|
1999-11-06 06:43:54 +03:00
|
|
|
* The contents of this file are subject to the Netscape Public
|
|
|
|
* License Version 1.1 (the "License"); you may not use this file
|
|
|
|
* except in compliance with the License. You may obtain a copy of
|
|
|
|
* the License at http://www.mozilla.org/NPL/
|
1999-09-06 23:16:25 +04:00
|
|
|
*
|
1999-11-06 06:43:54 +03:00
|
|
|
* Software distributed under the License is distributed on an "AS
|
|
|
|
* IS" basis, WITHOUT WARRANTY OF ANY KIND, either express or
|
|
|
|
* implied. See the License for the specific language governing
|
|
|
|
* rights and limitations under the License.
|
1999-09-06 23:16:25 +04:00
|
|
|
*
|
1999-11-06 06:43:54 +03:00
|
|
|
* The Original Code is mozilla.org code.
|
|
|
|
*
|
|
|
|
* The Initial Developer of the Original Code is Netscape
|
1999-09-06 23:16:25 +04:00
|
|
|
* Communications Corporation. Portions created by Netscape are
|
1999-11-06 06:43:54 +03:00
|
|
|
* Copyright (C) 1998 Netscape Communications Corporation. All
|
|
|
|
* Rights Reserved.
|
|
|
|
*
|
|
|
|
* Contributor(s):
|
1999-09-06 23:16:25 +04:00
|
|
|
*/
|
|
|
|
|
|
|
|
#include "nsAutoLock.h"
|
|
|
|
|
|
|
|
#ifdef DEBUG
|
|
|
|
|
|
|
|
#include "plhash.h"
|
|
|
|
#include "prprf.h"
|
1999-09-18 03:21:29 +04:00
|
|
|
#include "prlock.h"
|
1999-09-06 23:16:25 +04:00
|
|
|
#include "prthread.h"
|
|
|
|
#include "nsDebug.h"
|
2000-01-19 01:19:52 +03:00
|
|
|
#include "nsVoidArray.h"
|
1999-09-06 23:16:25 +04:00
|
|
|
|
|
|
|
static PRUintn LockStackTPI = (PRUintn)-1;
|
|
|
|
static PLHashTable* OrderTable = 0;
|
1999-09-18 03:21:29 +04:00
|
|
|
static PRLock* OrderTableLock = 0;
|
1999-09-06 23:16:25 +04:00
|
|
|
|
|
|
|
static const char* LockTypeNames[] = {"Lock", "Monitor", "CMonitor"};
|
|
|
|
|
2000-01-19 01:19:52 +03:00
|
|
|
struct nsNamedVector : public nsVoidArray {
|
1999-09-06 23:16:25 +04:00
|
|
|
const char* mName;
|
|
|
|
|
1999-09-18 03:21:29 +04:00
|
|
|
nsNamedVector(const char* name = 0, PRUint32 initialSize = 0)
|
2000-01-19 01:19:52 +03:00
|
|
|
: nsVoidArray(initialSize),
|
1999-09-06 23:16:25 +04:00
|
|
|
mName(name)
|
|
|
|
{
|
|
|
|
}
|
|
|
|
};
|
|
|
|
|
2000-11-02 01:21:28 +03:00
|
|
|
static void * PR_CALLBACK
|
|
|
|
_hash_alloc_table(void *pool, PRSize size)
|
|
|
|
{
|
|
|
|
return operator new(size);
|
|
|
|
}
|
|
|
|
|
|
|
|
static void PR_CALLBACK
|
|
|
|
_hash_free_table(void *pool, void *item)
|
|
|
|
{
|
|
|
|
operator delete(item);
|
|
|
|
}
|
|
|
|
|
|
|
|
static PLHashEntry * PR_CALLBACK
|
|
|
|
_hash_alloc_entry(void *pool, const void *key)
|
|
|
|
{
|
|
|
|
return new PLHashEntry;
|
|
|
|
}
|
|
|
|
|
|
|
|
/*
|
|
|
|
* Because monitors and locks may be associated with an nsAutoLockBase,
|
|
|
|
* without having had their associated nsNamedVector created explicitly in
|
|
|
|
* nsAutoMonitor::NewMonitor/DeleteMonitor, we need to provide a freeEntry
|
|
|
|
* PLHashTable hook, to avoid leaking nsNamedVectors which are replaced by
|
|
|
|
* nsAutoMonitor::NewMonitor.
|
|
|
|
*
|
|
|
|
* There is still a problem with the OrderTable containing orphaned
|
|
|
|
* nsNamedVector entries, for manually created locks wrapped by nsAutoLocks.
|
|
|
|
* (there should be no manually created monitors wrapped by nsAutoMonitors:
|
|
|
|
* you should use nsAutoMonitor::NewMonitor and nsAutoMonitor::DestroyMonitor
|
|
|
|
* instead of PR_NewMonitor and PR_DestroyMonitor). These lock vectors don't
|
|
|
|
* strictly leak, as they are killed on shutdown, but there are unnecessary
|
|
|
|
* named vectors in the hash table that outlive their associated locks.
|
|
|
|
*
|
|
|
|
* XXX so we should have nsLock, nsMonitor, etc. and strongly type their
|
|
|
|
* XXX nsAutoXXX counterparts to take only the non-auto types as inputs
|
|
|
|
*/
|
|
|
|
static void PR_CALLBACK
|
|
|
|
_hash_free_entry(void *pool, PLHashEntry *entry, PRUintn flag)
|
|
|
|
{
|
|
|
|
nsNamedVector* vec = (nsNamedVector*) entry->value;
|
|
|
|
if (vec) {
|
|
|
|
entry->value = 0;
|
|
|
|
delete vec;
|
|
|
|
}
|
|
|
|
if (flag == HT_FREE_ENTRY)
|
|
|
|
delete entry;
|
|
|
|
}
|
|
|
|
|
|
|
|
static PLHashAllocOps _hash_alloc_ops = {
|
|
|
|
_hash_alloc_table, _hash_free_table,
|
|
|
|
_hash_alloc_entry, _hash_free_entry
|
|
|
|
};
|
|
|
|
|
1999-09-18 03:21:29 +04:00
|
|
|
PR_STATIC_CALLBACK(PRIntn)
|
|
|
|
_purge_one(PLHashEntry* he, PRIntn cnt, void* arg)
|
|
|
|
{
|
|
|
|
nsNamedVector* vec = (nsNamedVector*) he->value;
|
|
|
|
|
2000-11-02 01:21:28 +03:00
|
|
|
if (he->key == arg)
|
1999-09-18 03:21:29 +04:00
|
|
|
return HT_ENUMERATE_REMOVE;
|
2000-01-19 01:19:52 +03:00
|
|
|
vec->RemoveElement(arg);
|
1999-09-18 03:21:29 +04:00
|
|
|
return HT_ENUMERATE_NEXT;
|
|
|
|
}
|
|
|
|
|
|
|
|
PR_STATIC_CALLBACK(void)
|
|
|
|
OnMonitorRecycle(void* addr)
|
|
|
|
{
|
|
|
|
PR_Lock(OrderTableLock);
|
|
|
|
PL_HashTableEnumerateEntries(OrderTable, _purge_one, addr);
|
|
|
|
PR_Unlock(OrderTableLock);
|
|
|
|
}
|
|
|
|
|
1999-09-06 23:16:25 +04:00
|
|
|
PR_STATIC_CALLBACK(PLHashNumber)
|
1999-09-18 03:21:29 +04:00
|
|
|
_hash_pointer(const void* key)
|
1999-09-06 23:16:25 +04:00
|
|
|
{
|
|
|
|
return PLHashNumber(key) >> 2;
|
|
|
|
}
|
|
|
|
|
2000-05-15 10:21:49 +04:00
|
|
|
// Must be single-threaded here, early in primordial thread.
|
1999-09-18 03:21:29 +04:00
|
|
|
static void InitAutoLockStatics()
|
|
|
|
{
|
|
|
|
(void) PR_NewThreadPrivateIndex(&LockStackTPI, 0);
|
|
|
|
OrderTable = PL_NewHashTable(64, _hash_pointer,
|
|
|
|
PL_CompareValues, PL_CompareValues,
|
2000-11-02 01:21:28 +03:00
|
|
|
&_hash_alloc_ops, 0);
|
1999-09-18 03:21:29 +04:00
|
|
|
if (OrderTable && !(OrderTableLock = PR_NewLock())) {
|
|
|
|
PL_HashTableDestroy(OrderTable);
|
|
|
|
OrderTable = 0;
|
|
|
|
}
|
|
|
|
PR_CSetOnMonitorRecycle(OnMonitorRecycle);
|
|
|
|
}
|
|
|
|
|
|
|
|
void _FreeAutoLockStatics()
|
|
|
|
{
|
|
|
|
PLHashTable* table = OrderTable;
|
|
|
|
if (!table) return;
|
|
|
|
|
|
|
|
// Called at shutdown, so we don't need to lock.
|
|
|
|
PR_CSetOnMonitorRecycle(0);
|
|
|
|
PR_DestroyLock(OrderTableLock);
|
|
|
|
OrderTableLock = 0;
|
|
|
|
PL_HashTableDestroy(table);
|
|
|
|
OrderTable = 0;
|
|
|
|
}
|
|
|
|
|
1999-09-06 23:16:25 +04:00
|
|
|
static nsNamedVector* GetVector(PLHashTable* table, const void* key)
|
|
|
|
{
|
|
|
|
PLHashNumber hash = _hash_pointer(key);
|
|
|
|
PLHashEntry** hep = PL_HashTableRawLookup(table, hash, key);
|
|
|
|
PLHashEntry* he = *hep;
|
|
|
|
if (he)
|
|
|
|
return (nsNamedVector*) he->value;
|
1999-09-18 03:21:29 +04:00
|
|
|
nsNamedVector* vec = new nsNamedVector();
|
1999-09-06 23:16:25 +04:00
|
|
|
if (vec)
|
|
|
|
PL_HashTableRawAdd(table, hep, hash, key, vec);
|
|
|
|
return vec;
|
|
|
|
}
|
|
|
|
|
1999-09-18 03:21:29 +04:00
|
|
|
// We maintain an acyclic graph in order table, so recursion can't diverge
|
|
|
|
static PRBool Reachable(PLHashTable* table, const void* goal, const void* start)
|
|
|
|
{
|
|
|
|
PR_ASSERT(goal);
|
|
|
|
PR_ASSERT(start);
|
|
|
|
nsNamedVector* vec = GetVector(table, start);
|
2000-01-19 01:19:52 +03:00
|
|
|
for (PRUint32 i = 0, n = vec->Count(); i < n; i++) {
|
|
|
|
void* addr = vec->ElementAt(i);
|
1999-09-18 03:21:29 +04:00
|
|
|
if (addr == goal || Reachable(table, goal, addr))
|
|
|
|
return PR_TRUE;
|
|
|
|
}
|
|
|
|
return PR_FALSE;
|
|
|
|
}
|
|
|
|
|
1999-09-06 23:16:25 +04:00
|
|
|
static PRBool WellOrdered(const void* addr1, const void* addr2,
|
|
|
|
nsNamedVector** vec1p, nsNamedVector** vec2p)
|
|
|
|
{
|
1999-09-18 03:21:29 +04:00
|
|
|
PRBool rv = PR_TRUE;
|
1999-09-06 23:16:25 +04:00
|
|
|
PLHashTable* table = OrderTable;
|
1999-09-18 03:21:29 +04:00
|
|
|
if (!table) return rv;
|
|
|
|
PR_Lock(OrderTableLock);
|
1999-09-06 23:16:25 +04:00
|
|
|
|
1999-09-07 09:40:22 +04:00
|
|
|
PRUint32 i, n;
|
|
|
|
|
1999-09-06 23:16:25 +04:00
|
|
|
// Check whether we've already asserted (addr1 < addr2).
|
|
|
|
nsNamedVector* vec1 = GetVector(table, addr1);
|
1999-09-18 03:21:29 +04:00
|
|
|
if (vec1) {
|
2000-01-19 01:19:52 +03:00
|
|
|
for (i = 0, n = vec1->Count(); i < n; i++)
|
|
|
|
if (vec1->ElementAt(i) == addr2)
|
1999-09-18 03:21:29 +04:00
|
|
|
break;
|
|
|
|
|
|
|
|
if (i == n) {
|
|
|
|
// Now check for (addr2 < addr1) and return false if so.
|
|
|
|
nsNamedVector* vec2 = GetVector(table, addr2);
|
|
|
|
if (vec2) {
|
2000-01-19 01:19:52 +03:00
|
|
|
for (i = 0, n = vec2->Count(); i < n; i++) {
|
|
|
|
void* addri = vec2->ElementAt(i);
|
1999-09-18 03:21:29 +04:00
|
|
|
PR_ASSERT(addri);
|
|
|
|
if (addri == addr1 || Reachable(table, addr1, addri)) {
|
|
|
|
*vec1p = vec1;
|
|
|
|
*vec2p = vec2;
|
|
|
|
rv = PR_FALSE;
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
}
|
1999-09-06 23:16:25 +04:00
|
|
|
|
1999-09-18 03:21:29 +04:00
|
|
|
if (rv) {
|
|
|
|
// Assert (addr1 < addr2) into the order table.
|
|
|
|
// XXX fix plvector/nsVector to use const void*
|
2000-01-19 01:19:52 +03:00
|
|
|
vec1->AppendElement((void*) addr2);
|
1999-09-18 03:21:29 +04:00
|
|
|
}
|
|
|
|
}
|
1999-09-06 23:16:25 +04:00
|
|
|
}
|
1999-09-18 03:21:29 +04:00
|
|
|
}
|
1999-09-06 23:16:25 +04:00
|
|
|
|
1999-09-18 03:21:29 +04:00
|
|
|
PR_Unlock(OrderTableLock);
|
|
|
|
return rv;
|
1999-09-06 23:16:25 +04:00
|
|
|
}
|
|
|
|
|
|
|
|
nsAutoLockBase::nsAutoLockBase(void* addr, nsAutoLockType type)
|
|
|
|
{
|
1999-09-18 03:21:29 +04:00
|
|
|
if (LockStackTPI == PRUintn(-1))
|
|
|
|
InitAutoLockStatics();
|
1999-09-06 23:16:25 +04:00
|
|
|
nsAutoLockBase* stackTop =
|
|
|
|
(nsAutoLockBase*) PR_GetThreadPrivate(LockStackTPI);
|
|
|
|
if (stackTop) {
|
|
|
|
if (stackTop->mAddr == addr) {
|
|
|
|
// Ignore reentry: it's legal for monitors, and NSPR will assert
|
|
|
|
// if you reenter a PRLock.
|
|
|
|
} else {
|
|
|
|
nsNamedVector* vec1;
|
|
|
|
nsNamedVector* vec2;
|
|
|
|
if (!WellOrdered(stackTop->mAddr, addr, &vec1, &vec2)) {
|
1999-09-18 03:21:29 +04:00
|
|
|
char buf[128];
|
1999-09-06 23:16:25 +04:00
|
|
|
PR_snprintf(buf, sizeof buf,
|
|
|
|
"potential deadlock between %s%s@%p and %s%s@%p",
|
|
|
|
vec1->mName ? vec1->mName : "",
|
|
|
|
LockTypeNames[stackTop->mType],
|
|
|
|
stackTop->mAddr,
|
|
|
|
vec2->mName ? vec2->mName : "",
|
|
|
|
LockTypeNames[type],
|
|
|
|
addr);
|
|
|
|
NS_ERROR(buf);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
mAddr = addr;
|
|
|
|
mDown = stackTop;
|
|
|
|
mType = type;
|
|
|
|
(void) PR_SetThreadPrivate(LockStackTPI, this);
|
|
|
|
}
|
|
|
|
|
|
|
|
nsAutoLockBase::~nsAutoLockBase()
|
|
|
|
{
|
|
|
|
(void) PR_SetThreadPrivate(LockStackTPI, mDown);
|
|
|
|
}
|
|
|
|
|
|
|
|
#endif /* DEBUG */
|
|
|
|
|
|
|
|
PRMonitor* nsAutoMonitor::NewMonitor(const char* name)
|
|
|
|
{
|
|
|
|
PRMonitor* mon = PR_NewMonitor();
|
|
|
|
#ifdef DEBUG
|
|
|
|
if (mon && OrderTable) {
|
1999-09-18 03:21:29 +04:00
|
|
|
nsNamedVector* value = new nsNamedVector(name);
|
|
|
|
if (value) {
|
|
|
|
PR_Lock(OrderTableLock);
|
1999-09-06 23:16:25 +04:00
|
|
|
PL_HashTableAdd(OrderTable, mon, value);
|
1999-09-18 03:21:29 +04:00
|
|
|
PR_Unlock(OrderTableLock);
|
|
|
|
}
|
1999-09-06 23:16:25 +04:00
|
|
|
}
|
|
|
|
#endif
|
|
|
|
return mon;
|
|
|
|
}
|
|
|
|
|
|
|
|
void nsAutoMonitor::DestroyMonitor(PRMonitor* mon)
|
|
|
|
{
|
|
|
|
#ifdef DEBUG
|
|
|
|
if (OrderTable)
|
1999-09-18 03:21:29 +04:00
|
|
|
OnMonitorRecycle(mon);
|
1999-09-06 23:16:25 +04:00
|
|
|
#endif
|
|
|
|
PR_DestroyMonitor(mon);
|
|
|
|
}
|
|
|
|
|
|
|
|
void nsAutoMonitor::Enter()
|
|
|
|
{
|
|
|
|
#ifdef DEBUG
|
|
|
|
nsAutoLockBase* stackTop =
|
|
|
|
(nsAutoLockBase*) PR_GetThreadPrivate(LockStackTPI);
|
|
|
|
NS_ASSERTION(stackTop == mDown, "non-LIFO nsAutoMonitor::Enter");
|
|
|
|
mDown = stackTop;
|
|
|
|
(void) PR_SetThreadPrivate(LockStackTPI, this);
|
|
|
|
#endif
|
|
|
|
PR_EnterMonitor(mMonitor);
|
|
|
|
}
|
|
|
|
|
|
|
|
void nsAutoMonitor::Exit()
|
|
|
|
{
|
|
|
|
#ifdef DEBUG
|
|
|
|
(void) PR_SetThreadPrivate(LockStackTPI, mDown);
|
|
|
|
#endif
|
|
|
|
PRStatus status = PR_ExitMonitor(mMonitor);
|
|
|
|
NS_ASSERTION(status == PR_SUCCESS, "PR_ExitMonitor failed");
|
|
|
|
}
|
|
|
|
|
|
|
|
// XXX we don't worry about cached monitors being destroyed behind our back.
|
|
|
|
// XXX current NSPR (mozilla/nsprpub/pr/src/threads/prcmon.c) never destroys
|
|
|
|
// XXX a cached monitor! potential resource pig in conjunction with necko...
|
|
|
|
|
|
|
|
void nsAutoCMonitor::Enter()
|
|
|
|
{
|
|
|
|
#ifdef DEBUG
|
|
|
|
nsAutoLockBase* stackTop =
|
|
|
|
(nsAutoLockBase*) PR_GetThreadPrivate(LockStackTPI);
|
|
|
|
NS_ASSERTION(stackTop == mDown, "non-LIFO nsAutoCMonitor::Enter");
|
|
|
|
mDown = stackTop;
|
|
|
|
(void) PR_SetThreadPrivate(LockStackTPI, this);
|
|
|
|
#endif
|
|
|
|
PR_CEnterMonitor(mLockObject);
|
|
|
|
}
|
|
|
|
|
|
|
|
void nsAutoCMonitor::Exit()
|
|
|
|
{
|
|
|
|
#ifdef DEBUG
|
|
|
|
(void) PR_SetThreadPrivate(LockStackTPI, mDown);
|
|
|
|
#endif
|
|
|
|
PRStatus status = PR_CExitMonitor(mLockObject);
|
|
|
|
NS_ASSERTION(status == PR_SUCCESS, "PR_CExitMonitor failed");
|
|
|
|
}
|