Bug 1670827 - P3: Telemetry tracking YUV color space r=jbauman

Add a telemetry probe tracking the YUV color space of the AVIF images

Differential Revision: https://phabricator.services.mozilla.com/D93708
This commit is contained in:
Chun-Min Chang 2020-11-03 01:54:21 +00:00
Родитель 5f04ddce8a
Коммит 00742cf457
3 изменённых файлов: 41 добавлений и 0 удалений

Просмотреть файл

@ -24,9 +24,16 @@ namespace image {
using Telemetry::LABELS_AVIF_DECODE_RESULT;
using Telemetry::LABELS_AVIF_DECODER;
using Telemetry::LABELS_AVIF_YUV_COLOR_SPACE;
static LazyLogModule sAVIFLog("AVIFDecoder");
static const LABELS_AVIF_YUV_COLOR_SPACE gColorSpaceLabel[static_cast<size_t>(
gfx::YUVColorSpace::_NUM_COLORSPACE)] = {
LABELS_AVIF_YUV_COLOR_SPACE::BT601, LABELS_AVIF_YUV_COLOR_SPACE::BT709,
LABELS_AVIF_YUV_COLOR_SPACE::BT2020, LABELS_AVIF_YUV_COLOR_SPACE::identity,
LABELS_AVIF_YUV_COLOR_SPACE::unknown};
// Wrapper to allow rust to call our read adaptor.
intptr_t nsAVIFDecoder::ReadSource(uint8_t* aDestBuf, uintptr_t aDestBufSize,
void* aUserData) {
@ -519,6 +526,9 @@ nsAVIFDecoder::DecodeResult nsAVIFDecoder::Decode(
return AsVariant(NonDecoderResult::MetadataOk);
}
AccumulateCategorical(
gColorSpaceLabel[static_cast<size_t>(decodedData.mYUVColorSpace)]);
gfx::SurfaceFormat format =
hasAlpha ? SurfaceFormat::OS_RGBA : SurfaceFormat::OS_RGBX;
const IntSize intrinsicSize = Size();

Просмотреть файл

@ -1671,6 +1671,17 @@
"description": "Decoder of AVIF image",
"bug_numbers": [1670827]
},
"AVIF_YUV_COLOR_SPACE": {
"record_in_processes": ["main", "content"],
"products": ["firefox", "geckoview_streaming"],
"alert_emails": ["cchang@mozilla.com", "jbauman@mozilla.com"],
"expires_in_version": "never",
"releaseChannelCollection": "opt-out",
"kind": "categorical",
"labels": ["BT601", "BT709", "BT2020", "identity", "unknown"],
"description": "YUV color space of AVIF image",
"bug_numbers": [1670827]
},
"KEYPRESS_PRESENT_LATENCY": {
"record_in_processes": [ "all" ],
"products": ["firefox", "fennec", "geckoview_streaming"],

Просмотреть файл

@ -835,6 +835,26 @@ avif:
- jbauman@mozilla.com
expires: never
yuv_color_space:
type: labeled_counter
labels:
- bt601
- bt709
- bt2020
- identity
- unknown
gecko_datapoint: AVIF_YUV_COLOR_SPACE
description: >
YUV color space of AVIF image.
bugs:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1670827
data_reviews:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1670827#c9
notification_emails:
- cchang@mozilla.com
- jbauman@mozilla.com
expires: never
network:
cache_hit_time:
type: timing_distribution