diff --git a/webtools/tinderbox2/src/bin/addnote.cgi b/webtools/tinderbox2/src/bin/addnote.cgi index 8685846b4dff..44b0339bb53c 100644 --- a/webtools/tinderbox2/src/bin/addnote.cgi +++ b/webtools/tinderbox2/src/bin/addnote.cgi @@ -6,8 +6,8 @@ # on the tinderbox status page. -# $Revision: 1.7 $ -# $Date: 2001/07/20 19:04:47 $ +# $Revision: 1.8 $ +# $Date: 2001/08/02 20:06:02 $ # $Author: kestes%walrus.com $ # $Source: /home/hwine/cvs_conversion/cvsroot/mozilla/webtools/tinderbox2/src/bin/addnote.cgi,v $ # $Name: $ @@ -197,7 +197,7 @@ sub save_note { "/Notice\.Update\.$time\.$MAILADDR"); $update_file =~ s/\@/\./g; - $update_file = main::extract_filename_chars($update_file); + $update_file = main::extract_safe_filename($update_file); Persistence::save_structure( $record, diff --git a/webtools/tinderbox2/src/bin/processmail_builds b/webtools/tinderbox2/src/bin/processmail_builds index 78c8c3ad4348..541721ff0a8c 100755 --- a/webtools/tinderbox2/src/bin/processmail_builds +++ b/webtools/tinderbox2/src/bin/processmail_builds @@ -12,8 +12,8 @@ # server. No locks are used by the mail processes, data is passed to # the tinderbox server in a maildir like format. -# $Revision: 1.6 $ -# $Date: 2001/07/20 19:04:49 $ +# $Revision: 1.7 $ +# $Date: 2001/08/02 20:06:02 $ # $Author: kestes%walrus.com $ # $Source: /home/hwine/cvs_conversion/cvsroot/mozilla/webtools/tinderbox2/src/bin/processmail_builds,v $ # $Name: $ @@ -605,22 +605,11 @@ sub process_bloat_data { return ; } - - -# create the HTML file headers for both the full and brief log -# files. This must run after the message body has been parsed as some -# of the data comes from there. - -sub log_header { - my ($logtype) = @_; - - my ($out) = ''; - my ($tree) = $TINDERBOX{'tree'}; - - $out .= HTMLPopUp::page_header('title'=>"$logtype Build Log ". - "for tree: $tree "); +sub log_links { + my ($tree, $logtype) = @_; my $notlogtype = ( $logtype eq 'full' ? "brief" : "full"); + my $out; $out .= "\n"; $out .= "\n"; @@ -641,7 +630,24 @@ sub log_header { ); $out .= "\n"; - $out .= "\n"; + + return $out +} + +# create the HTML file headers for both the full and brief log +# files. This must run after the message body has been parsed as some +# of the data comes from there. + +sub log_header { + my ($logtype) = @_; + + my ($out) = ''; + my ($tree) = $TINDERBOX{'tree'}; + + $out .= HTMLPopUp::page_header('title'=>"$logtype Build Log ". + "for tree: $tree "); + + $out .= log_links($tree, $logtype)."\n"; $out .= "
\n"; @@ -659,6 +665,19 @@ sub log_header { } +sub log_footer { + my ($logtype) = @_; + + my ($out) = ''; + my ($tree) = $TINDERBOX{'tree'}; + + $out .= log_links($tree, $logtype)."\n"; + $out .= "