Bug 300116 Extension Manager only checks for updates for the selected extension

patch by zach r=bsmedberg a=bsmedberg

toolkit/mozapps/extensions/content/extensions.js

@@ -894,6 +894,8 @@ var gExtensionsViewController = {
       return !selectedItem && gExtensionsView.children.length > 0 ||
              (selectedItem &&
               selectedItem.getAttribute("updateable") != "false");
+    case "cmd_update_all":
+      return gExtensionsView.children.length > 0;
     case "cmd_reallyEnable":
     // controls whether to show Enable or Disable in extensions' context menu
       return selectedItem && 
@@ -1056,6 +1058,13 @@ var gExtensionsViewController = {
       gExtensionManager.update(items, items.length, false, listener);
     },
 
+    cmd_update_all: function (aSelectedItem)
+    {
+      var items = gExtensionManager.getItemList(gItemType, { });
+      var listener = new UpdateCheckListener();
+      gExtensionManager.update(items, items.length, false, listener);
+    },
+
     cmd_uninstall: function (aSelectedItem)
     {
       // Confirm the uninstall

toolkit/mozapps/extensions/content/extensions.xul

@@ -94,6 +94,7 @@
 #endif
     <command id="cmd_uninstall"/>
     <command id="cmd_update"/>
+    <command id="cmd_update_all"/>
     <command id="cmd_enable"/>
     <command id="cmd_disable"/>
     <command id="cmd_movetop"/>
@@ -270,15 +271,12 @@
         <button id="installButton"
                 label="&cmd.install.label;" accesskey="&cmd.install.accesskey;" tooltiptext="&cmd.install.tooltip;" 
                 command="cmd_install"/>
+        <separator class="commandBarSeparator"/>
 #endif
         <button id="uninstallButton" 
                 label="&cmd.uninstall.label;" accesskey="&cmd.uninstall.accesskey;" tooltiptext="&cmd.uninstall.tooltip;" 
                 command="cmd_uninstall"/>
         <separator class="commandBarSeparator"/>
-        <button id="updateButton" 
-                label="&cmd.update.label;" accesskey="&cmd.update.accesskey;" tooltiptext="&cmd.update.tooltip;"
-                command="cmd_update"/>
-        <separator class="commandBarSeparator"/>
         <button id="optionsButton" command="cmd_options"
 #ifdef XP_WIN
               label="&cmd.options.label;" accesskey="&cmd.options.accesskey;" tooltiptext="&cmd.options.tooltip;"/>
@@ -291,6 +289,11 @@
       </hbox>
       <spacer flex="1"/>
 
+      <separator class="commandBarSeparator"/>
+      <button id="updateButton" 
+              label="&cmd.update.label;" accesskey="&cmd.update.accesskey;" tooltiptext="&cmd.update.tooltip;"
+              command="cmd_update_all"/>
+      <separator class="commandBarSeparator"/>
       <label id="getMore" class="text-link"
              valuethemes="&getMoreThemes.label;"
              valueextensions="&getMoreExtensions.label;"