diff --git a/browser/components/loop/content/shared/js/otSdkDriver.js b/browser/components/loop/content/shared/js/otSdkDriver.js index f6c52a365511..67d10316db67 100644 --- a/browser/components/loop/content/shared/js/otSdkDriver.js +++ b/browser/components/loop/content/shared/js/otSdkDriver.js @@ -789,7 +789,7 @@ loop.OTSdkDriver = (function() { bucket = buckets.MORE_THAN_5M; } - this.mozLoop.telemetryAddValue("LOOP_TWO_WAY_MEDIA_CONN_LENGTH", bucket); + this.mozLoop.telemetryAddValue("LOOP_TWO_WAY_MEDIA_CONN_LENGTH_1", bucket); this._setTwoWayMediaStartTime(this.CONNECTION_START_TIME_ALREADY_NOTED); this._connectionLengthNotedCalls++; @@ -857,7 +857,7 @@ loop.OTSdkDriver = (function() { return; } - this.mozLoop.telemetryAddValue("LOOP_SHARING_STATE_CHANGE", bucket); + this.mozLoop.telemetryAddValue("LOOP_SHARING_STATE_CHANGE_1", bucket); } }; diff --git a/browser/components/loop/test/mochitest/browser_mozLoop_telemetry.js b/browser/components/loop/test/mochitest/browser_mozLoop_telemetry.js index 071cc11a32cc..46cda6b43693 100644 --- a/browser/components/loop/test/mochitest/browser_mozLoop_telemetry.js +++ b/browser/components/loop/test/mochitest/browser_mozLoop_telemetry.js @@ -23,7 +23,7 @@ add_task(function* test_initialize() { * Tests that enumerated bucket histograms exist and can be updated. */ add_task(function* test_mozLoop_telemetryAdd_buckets() { - let histogramId = "LOOP_TWO_WAY_MEDIA_CONN_LENGTH"; + let histogramId = "LOOP_TWO_WAY_MEDIA_CONN_LENGTH_1"; let histogram = Services.telemetry.getHistogramById(histogramId); let CONN_LENGTH = gMozLoopAPI.TWO_WAY_MEDIA_CONN_LENGTH; @@ -49,7 +49,7 @@ add_task(function* test_mozLoop_telemetryAdd_buckets() { }); add_task(function* test_mozLoop_telemetryAdd_sharing_buckets() { - let histogramId = "LOOP_SHARING_STATE_CHANGE"; + let histogramId = "LOOP_SHARING_STATE_CHANGE_1"; let histogram = Services.telemetry.getHistogramById(histogramId); const SHARING_STATES = gMozLoopAPI.SHARING_STATE_CHANGE; diff --git a/browser/components/loop/test/shared/otSdkDriver_test.js b/browser/components/loop/test/shared/otSdkDriver_test.js index 5e2392606e9b..4cfd4a8e9f3d 100644 --- a/browser/components/loop/test/shared/otSdkDriver_test.js +++ b/browser/components/loop/test/shared/otSdkDriver_test.js @@ -473,7 +473,7 @@ describe("loop.OTSdkDriver", function () { sinon.assert.calledOnce(mozLoop.telemetryAddValue); sinon.assert.calledWith(mozLoop.telemetryAddValue, - "LOOP_TWO_WAY_MEDIA_CONN_LENGTH", + "LOOP_TWO_WAY_MEDIA_CONN_LENGTH_1", mozLoop.TWO_WAY_MEDIA_CONN_LENGTH.SHORTER_THAN_10S); }); @@ -485,7 +485,7 @@ describe("loop.OTSdkDriver", function () { sinon.assert.calledOnce(mozLoop.telemetryAddValue); sinon.assert.calledWith(mozLoop.telemetryAddValue, - "LOOP_TWO_WAY_MEDIA_CONN_LENGTH", + "LOOP_TWO_WAY_MEDIA_CONN_LENGTH_1", mozLoop.TWO_WAY_MEDIA_CONN_LENGTH.BETWEEN_10S_AND_30S); }); @@ -497,7 +497,7 @@ describe("loop.OTSdkDriver", function () { sinon.assert.calledOnce(mozLoop.telemetryAddValue); sinon.assert.calledWith(mozLoop.telemetryAddValue, - "LOOP_TWO_WAY_MEDIA_CONN_LENGTH", + "LOOP_TWO_WAY_MEDIA_CONN_LENGTH_1", mozLoop.TWO_WAY_MEDIA_CONN_LENGTH.BETWEEN_30S_AND_5M); }); @@ -508,7 +508,7 @@ describe("loop.OTSdkDriver", function () { sinon.assert.calledOnce(mozLoop.telemetryAddValue); sinon.assert.calledWith(mozLoop.telemetryAddValue, - "LOOP_TWO_WAY_MEDIA_CONN_LENGTH", + "LOOP_TWO_WAY_MEDIA_CONN_LENGTH_1", mozLoop.TWO_WAY_MEDIA_CONN_LENGTH.MORE_THAN_5M); }); @@ -530,7 +530,7 @@ describe("loop.OTSdkDriver", function () { sinon.assert.calledOnce(mozLoop.telemetryAddValue); sinon.assert.calledWithExactly(mozLoop.telemetryAddValue, - "LOOP_SHARING_STATE_CHANGE", + "LOOP_SHARING_STATE_CHANGE_1", mozLoop.SHARING_STATE_CHANGE.WINDOW_ENABLED); }); @@ -539,7 +539,7 @@ describe("loop.OTSdkDriver", function () { sinon.assert.calledOnce(mozLoop.telemetryAddValue); sinon.assert.calledWithExactly(mozLoop.telemetryAddValue, - "LOOP_SHARING_STATE_CHANGE", + "LOOP_SHARING_STATE_CHANGE_1", mozLoop.SHARING_STATE_CHANGE.BROWSER_ENABLED); }); @@ -548,7 +548,7 @@ describe("loop.OTSdkDriver", function () { sinon.assert.calledOnce(mozLoop.telemetryAddValue); sinon.assert.calledWithExactly(mozLoop.telemetryAddValue, - "LOOP_SHARING_STATE_CHANGE", + "LOOP_SHARING_STATE_CHANGE_1", mozLoop.SHARING_STATE_CHANGE.WINDOW_DISABLED); }); @@ -557,7 +557,7 @@ describe("loop.OTSdkDriver", function () { sinon.assert.calledOnce(mozLoop.telemetryAddValue); sinon.assert.calledWithExactly(mozLoop.telemetryAddValue, - "LOOP_SHARING_STATE_CHANGE", + "LOOP_SHARING_STATE_CHANGE_1", mozLoop.SHARING_STATE_CHANGE.BROWSER_DISABLED); }); }); diff --git a/toolkit/components/telemetry/Histograms.json b/toolkit/components/telemetry/Histograms.json index 35337eabbe17..c76951b18bbb 100644 --- a/toolkit/components/telemetry/Histograms.json +++ b/toolkit/components/telemetry/Histograms.json @@ -7490,7 +7490,7 @@ "kind": "boolean", "description": "Stores 1 every time the URL is copied or shared." }, - "LOOP_TWO_WAY_MEDIA_CONN_LENGTH": { + "LOOP_TWO_WAY_MEDIA_CONN_LENGTH_1": { "alert_emails": ["firefox-dev@mozilla.org", "dmose@mozilla.com"], "expires_in_version": "43", "kind": "enumerated", @@ -7498,7 +7498,7 @@ "releaseChannelCollection": "opt-out", "description": "Connection length for bi-directionally connected media (0=SHORTER_THAN_10S, 1=BETWEEN_10S_AND_30S, 2=BETWEEN_30S_AND_5M, 3=MORE_THAN_5M)" }, - "LOOP_SHARING_STATE_CHANGE": { + "LOOP_SHARING_STATE_CHANGE_1": { "alert_emails": ["firefox-dev@mozilla.org", "mdeboer@mozilla.com"], "expires_in_version": "43", "kind": "enumerated",