Bug 1081606: Don't call toArray with zero-size arrays. r=rnewman

* * *
Bug 1081606: Don't call toArray with zero-size arrays. r=rnewman

mobile/android/base/FilePicker.java

@@ -199,7 +199,7 @@ public class FilePicker implements GeckoEventListener {
             title = getFilePickerTitle(mimeType);
         }
         Intent chooser = Intent.createChooser(base, title);
-        chooser.putExtra(Intent.EXTRA_INITIAL_INTENTS, intents.toArray(new Parcelable[]{}));
+        chooser.putExtra(Intent.EXTRA_INITIAL_INTENTS, intents.toArray(new Parcelable[intents.size()]));
         handler.gotIntent(chooser);
     }
 

mobile/android/base/fxa/activities/FxAccountAbstractSetupActivity.java

@@ -379,7 +379,7 @@ abstract public class FxAccountAbstractSetupActivity extends FxAccountAbstractAc
     }
 
     // And then sorted in alphabetical order.
-    final String[] sortedEmails = emails.toArray(new String[0]);
+    final String[] sortedEmails = emails.toArray(new String[emails.size()]);
     Arrays.sort(sortedEmails);
 
     final ArrayAdapter<String> adapter = new ArrayAdapter<String>(this, android.R.layout.simple_dropdown_item_1line, sortedEmails);

mobile/android/base/fxa/activities/FxAccountCreateAccountActivity.java

@@ -176,7 +176,7 @@ public class FxAccountCreateAccountActivity extends FxAccountAbstractSetupActivi
     for (int i = 1991; i <= year - 5; i++) {
       years.add(Integer.toString(i));
     }
-    return years.toArray(new String[0]);
+    return years.toArray(new String[years.size()]);
   }
 
   protected void createYearEdit() {

mobile/android/base/sync/repositories/android/FormHistoryRepositorySession.java

@@ -173,7 +173,7 @@ public class FormHistoryRepositorySession extends
           }
         }
 
-        String guidsArray[] = guids.toArray(new String[0]);
+        String guidsArray[] = guids.toArray(new String[guids.size()]);
         delegate.onGuidsSinceSucceeded(guidsArray);
       }
     };
@@ -466,7 +466,7 @@ public class FormHistoryRepositorySession extends
   protected void flushInsertQueue() throws RemoteException {
     synchronized (recordsBufferMonitor) {
       if (recordsBuffer.size() > 0) {
-        final ContentValues[] outgoing = recordsBuffer.toArray(new ContentValues[0]);
+        final ContentValues[] outgoing = recordsBuffer.toArray(new ContentValues[recordsBuffer.size()]);
         recordsBuffer = new ArrayList<ContentValues>();
 
         if (outgoing == null || outgoing.length == 0) {