Backed out changeset c5b7d3456ec9 (bug 1696253) for causing bc failures in browser_HomePage_add_button.js

CLOSED TREE

browser/base/content/test/performance/browser_preferences_usage.js

@@ -125,7 +125,7 @@ add_task(async function startup() {
     },
     "browser.proton.enabled": {
       min: 0,
-      max: 100, // Bug 1698132
+      max: 50, // Bug 1698132
     },
   };
 

browser/components/customizableui/CustomizableUI.jsm

@@ -48,7 +48,7 @@ XPCOMUtils.defineLazyPreferenceGetter(
 XPCOMUtils.defineLazyPreferenceGetter(
   this,
   "gProtonToolbarEnabled",
-  "browser.proton.enabled",
+  "browser.proton.toolbar.enabled",
   false
 );
 

browser/components/customizableui/test/browser_proton_toolbar_hide_toolbarbuttons.js

@@ -15,7 +15,7 @@ ChromeUtils.defineModuleGetter(
   "resource:///modules/HomePage.jsm"
 );
 
-const kPrefProtonToolbarEnabled = "browser.proton.enabled";
+const kPrefProtonToolbarEnabled = "browser.proton.toolbar.enabled";
 const kPrefProtonToolbarVersion = "browser.proton.toolbar.version";
 const kPrefHomeButtonUsed = "browser.engagement.home-button.has-used";
 const kPrefLibraryButtonUsed = "browser.engagement.library-button.has-used";

browser/modules/HomePage.jsm

@@ -27,7 +27,7 @@ const kExtensionControllerPref =
 const kHomePageIgnoreListId = "homepage-urls";
 const kWidgetId = "home-button";
 const kWidgetRemovedPref = "browser.engagement.home-button.has-removed";
-const kProtonToolbarEnabledPref = "browser.proton.enabled";
+const kProtonToolbarEnabledPref = "browser.proton.toolbar.enabled";
 
 function getHomepagePref(useDefault) {
   let homePage;

browser/modules/test/browser/browser_HomePage_add_button.js

@@ -12,7 +12,7 @@ ChromeUtils.defineModuleGetter(
 const kPrefHomePage = "browser.startup.homepage";
 const kPrefExtensionControlled =
   "browser.startup.homepage_override.extensionControlled";
-const kPrefProtonToolbarEnabled = "browser.proton.enabled";
+const kPrefProtonToolbarEnabled = "browser.proton.toolbar.enabled";
 const kPrefHomeButtonRemoved = "browser.engagement.home-button.has-removed";
 const kHomeButtonId = "home-button";
 const kUrlbarWidgetId = "urlbar-container";

browser/themes/osx/browser.css

@@ -205,7 +205,7 @@
   border: none;
 }
 
-@supports not -moz-bool-pref("browser.proton.enabled") {
+@supports not -moz-bool-pref("browser.proton.toolbar.enabled") {
 /* On Mac, native buttons keep their full opacity when they become disabled
  * and only the glyph or text on top of them becomes less opaque. */
 :root:not([customizing]) #back-button[disabled="true"] {

browser/themes/shared/browser.inc.css

@@ -149,7 +149,7 @@
   border-bottom-style: none;
 }
 
-@supports -moz-bool-pref("browser.proton.enabled") {
+@supports -moz-bool-pref("browser.proton.toolbar.enabled") {
 /* Add space to beginning of toolbar and make that space click the first <toolbarbutton> */
 #nav-bar-customization-target > :is(toolbarbutton, toolbaritem):first-child,
 #nav-bar-customization-target > toolbarpaletteitem:first-child > :is(toolbarbutton, toolbaritem) {
@@ -172,13 +172,13 @@
   max-height: 4em;
 }
 
-@supports not -moz-bool-pref("browser.proton.enabled") {
+@supports not -moz-bool-pref("browser.proton.toolbar.enabled") {
 #PersonalToolbar {
   padding: 2px 6px;
 }
 } /*** END !proton ***/
 
-@supports -moz-bool-pref("browser.proton.enabled") {
+@supports -moz-bool-pref("browser.proton.toolbar.enabled") {
 #PersonalToolbar {
   padding-inline: 6px;
 }

browser/themes/shared/customizableui/panelUI.inc.css

@@ -68,7 +68,7 @@
 
 } /*** END proton ***/
 
-@supports not -moz-bool-pref("browser.proton.enabled") {
+@supports not -moz-bool-pref("browser.proton.toolbar.enabled") {
 :root:not([uidensity=compact], [chromehidden~="toolbar"]) #PanelUI-button {
   margin-inline-start: 3px;
   border-inline-start: 1px solid;
@@ -933,7 +933,7 @@ toolbarbutton[constrain-size="true"][cui-areatype="menu-panel"] > .toolbarbutton
 }
 
 /* Hide the FxA toolbar button when its in the nav-bar, until in use */
-@supports -moz-bool-pref("browser.proton.enabled") {
+@supports -moz-bool-pref("browser.proton.toolbar.enabled") {
   :root[fxastatus="not_configured"] #nav-bar-customization-target > #fxa-toolbar-menu-button {
     display: none;
   }

browser/themes/shared/toolbarbuttons.inc.css

@@ -41,13 +41,14 @@
   --toolbarbutton-focus-outline: var(--focus-outline);
 }
 } /*** END proton ***/
+
 :root[uidensity=compact] {
   --toolbarbutton-outer-padding: 3px;
   --toolbarbutton-inner-padding: 6px;
   --bookmark-block-padding: 1px;
 }
 
-@supports not -moz-bool-pref("browser.proton.enabled") {
+@supports not -moz-bool-pref("browser.proton.toolbar.enabled") {
 :root {
   --toolbarbutton-outer-padding: 2px;
   --toolbarbutton-inner-padding: 6px;
@@ -146,7 +147,7 @@ toolbar .toolbarbutton-1 {
   -moz-box-pack: center;
 }
 
-@supports not -moz-bool-pref("browser.proton.enabled") {
+@supports not -moz-bool-pref("browser.proton.toolbar.enabled") {
 :root:not([uidensity=compact]) #PanelUI-button {
   padding-inline-start: 5px;
 }
@@ -155,7 +156,7 @@ toolbar .toolbarbutton-1 {
   padding-inline-end: 5px;
 }
 } /*** END !proton ***/
-@supports -moz-bool-pref("browser.proton.enabled") {
+@supports -moz-bool-pref("browser.proton.toolbar.enabled") {
 /*** Adds padding to end of toolbar while making that space click the first button ***/
 #PanelUI-menu-button {
   padding-inline-end: var(--toolbar-start-end-padding);
@@ -289,7 +290,7 @@ toolbar .toolbarbutton-1:-moz-focusring {
   outline: none;
 }
 
-@supports not -moz-bool-pref("browser.proton.enabled") {
+@supports not -moz-bool-pref("browser.proton.toolbar.enabled") {
 :root:not([uidensity=compact]) #back-button {
   padding-block: 3px;
   padding-inline: 3px 0;
@@ -365,7 +366,7 @@ toolbar .toolbarbutton-1:-moz-focusring {
 
 /* ::::: bookmark buttons ::::: */
 
-@supports not -moz-bool-pref("browser.proton.enabled") {
+@supports not -moz-bool-pref("browser.proton.toolbar.enabled") {
   #PersonalToolbar .toolbarbutton-1,
   #personal-toolbar-empty-description,
   toolbarbutton.bookmark-item:not(.subviewbutton) {
@@ -407,7 +408,7 @@ toolbar .toolbarbutton-1:-moz-focusring {
   }
 } /** END !proton **/
 
-@supports -moz-bool-pref("browser.proton.enabled") {
+@supports -moz-bool-pref("browser.proton.toolbar.enabled") {
   #PersonalToolbar .toolbarbutton-1,
   #personal-toolbar-empty-description,
   toolbarbutton.bookmark-item:not(.subviewbutton) {

browser/themes/shared/urlbar-searchbar.inc.css

@@ -45,7 +45,7 @@
   color: FieldText;
 }
 
-@supports not -moz-bool-pref("browser.proton.enabled") {
+@supports not -moz-bool-pref("browser.proton.toolbar.enabled") {
 #urlbar-container,
 #search-container {
   padding-block: 3px;

browser/themes/windows/browser.css

@@ -28,7 +28,7 @@
   --chrome-content-separator-color: ThreeDShadow;
 }
 
-@supports not -moz-bool-pref("browser.proton.enabled") {
+@supports not -moz-bool-pref("browser.proton.toolbar.enabled") {
 :root {
   --toolbarbutton-border-radius: 2px;
 }