зеркало из https://github.com/mozilla/gecko-dev.git
Bug 1882146 [wpt PR 44791] - Revert "[FedCM] Allow button flow to replace widget flow", a=testonly
Automatic update from web-platform-tests Revert "[FedCM] Allow button flow to replace widget flow" This reverts commit a2783105732c27a57dd0c3e1100730cc4aec32e0. Reason for revert: Suspected of causing failures on WebKit Linux Leak: https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20Leak/60801/overview (and other runs since) Original change's description: > [FedCM] Allow button flow to replace widget flow > > Since button flow implies stronger user login intention of, it should > take precedence over the widget flow. In particular: > 1. If there's an in-flight button request, reject any coming widget request > 2. If there's an in-flight widget request, replace it with the button request > > This patch also fixes an issue where we persisted the rp_mode_ after a > button flow. > > Bug: 41483050 > Change-Id: Ic75ba4ab359a9247f4c41b75ad84f7a3cabeb0c9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5321982 > Commit-Queue: Yi Gu <yigu@chromium.org> > Reviewed-by: Christian Biesinger <cbiesinger@chromium.org> > Cr-Commit-Position: refs/heads/main@{#1265238} Bug: 41483050 Change-Id: I82728a8ea02194f46eed086015473975a4017dc4 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5317868 Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/main@{#1265306} -- wpt-commits: 4e124bd215d00032c69d87b499d4e04fa97595b3 wpt-pr: 44791
This commit is contained in:
Родитель
2ce0a3e7c3
Коммит
0659def0cb
|
@ -30,32 +30,4 @@ fedcm_test(async t => {
|
|||
});
|
||||
}, "Test that the button mode requires user activation.");
|
||||
|
||||
fedcm_test(async t => {
|
||||
let widget_test_options = request_options_with_mediation_required("manifest_with_rp_mode.json");
|
||||
let button_test_options = request_options_with_mediation_required("manifest_with_rp_mode.json");
|
||||
button_test_options.identity.mode = "button";
|
||||
|
||||
let first_cred = navigator.credentials.get(widget_test_options);
|
||||
let rej = promise_rejects_dom(t, 'NetworkError', first_cred);
|
||||
|
||||
test_driver.bless('initiate FedCM request', async function() {
|
||||
let second_cred = await fedcm_get_and_select_first_account(t, button_test_options);
|
||||
assert_equals(second_cred.token, "mode=button");
|
||||
});
|
||||
return rej;
|
||||
}, "Test that the button mode can replace widget mode.");
|
||||
|
||||
fedcm_test(async t => {
|
||||
let widget_test_options = request_options_with_mediation_required("manifest_with_rp_mode.json");
|
||||
let button_test_options = request_options_with_mediation_required("manifest_with_rp_mode.json");
|
||||
button_test_options.identity.mode = "button";
|
||||
|
||||
test_driver.bless('initiate FedCM request', async function() {
|
||||
let first_cred = await fedcm_get_and_select_first_account(t, button_test_options);
|
||||
assert_equals(first_cred.token, "mode=button");
|
||||
let second_cred = await fedcm_get_and_select_first_account(t, widget_test_options);
|
||||
assert_equals(second_cred.token, "mode=widget");
|
||||
});
|
||||
}, "Test that the widget mode can succeed after the button mode.");
|
||||
|
||||
</script>
|
||||
|
|
Загрузка…
Ссылка в новой задаче