Making extensive corrections. Testcase had not conformed to ECMA-262 Final Edition.

js/tests/ecma_3/String/regress-83293.js

@@ -17,18 +17,38 @@
 * Rights Reserved.
 *
 * Contributor(s): pschwartau@netscape.com, jim@jibbering.com
-* Date: 30 May 2001
+* Creation Date:   30 May 2001
+* Correction Date: 14 Aug 2001
 *
 * SUMMARY:  Regression test for bug 83293
 * See http://bugzilla.mozilla.org/show_bug.cgi?id=83293
 * and http://bugzilla.mozilla.org/show_bug.cgi?id=92942
 *
-* str.replace(strA, strB) == str.replace(new RegExp(strA),strB)
-* See ECMA-262 Section 15.5.4.11 String.prototype.replace
+* ********************   CORRECTION !!!  *****************************
+*
+* When I originally wrote this test, I thought this was true:
+* str.replace(strA, strB) == str.replace(new RegExp(strA),strB).
+* See ECMA-262 Final Draft, 15.5.4.11 String.prototype.replace
+*
+* However, in http://bugzilla.mozilla.org/show_bug.cgi?id=83293
+* Jim Ley points out the ECMA-262 Final Edition changed on this.
+* String.prototype.replace (searchValue, replaceValue), if provided
+* a searchValue that is not a RegExp, is NO LONGER to replace it with
+*
+*                  new RegExp(searchValue)
+* but rather:
+*                  String(searchValue)
+*
+* This puts the replace() method at variance with search() and match(),
+* which continue to follow the RegExp conversion of the Final Draft.
+* It also makes most of this testcase, as originally written, invalid.
+**********************************************************************
 */
 //-----------------------------------------------------------------------------
 var bug = 83293;
-var summary = 'Testing str.replace(strA, strB) == str.replace(new RegExp(strA),strB)';
+var summ_OLD = 'Testing str.replace(strA, strB) == str.replace(new RegExp(strA),strB)';
+var summ_NEW = 'Testing String.prototype.replace(x,y) when x is a string';
+var summary = summ_NEW;
 var status = '';
 var actual = '';
 var expect= '';
@@ -57,6 +77,7 @@ function test()
   printBugNumber (bug);
   printStatus (summary);
 
+/*******************  THESE WERE INCORRECT; SEE ABOVE  ************************
   status = 'Section A of test';
   strA = 'a';
   actual = str.replace(strA, strB);
@@ -82,13 +103,13 @@ function test()
   reportCompare(expect, actual, status);
 
 
- /* This example is from jim@jibbering.com (see Bugzilla bug 92942)
+  * This example is from jim@jibbering.com (see Bugzilla bug 92942)
   * It is a variation on the example below.
   *
   * Namely, we are using the regexp /$/ instead of the regexp //.
   * The regexp /$/ means we should match the "empty string" at the 
   * end-boundary of the word, instead of the one at the beginning.
-  */
+  *
   status = 'Section E of test';
   var strJim = 'aa$aa';
   strA = '$';
@@ -97,13 +118,13 @@ function test()
   reportCompare(expect, actual, status);
 
 
- /*
+  *
   * Note: 'Zabc' is the result we expect for 'abc'.replace('', 'Z').
   *
   * The string '' is supposed to be equivalent to new RegExp('') = //.
   * The regexp // means we should match the "empty string" conceived of
   * at the beginning boundary of the word, before the first character.
-  */
+  *
   status = 'Section F of test';
   strA = cnEmptyString;
   actual = str.replace(strA, strB);
@@ -116,5 +137,55 @@ function test()
   expect = str.replace(new RegExp(strA), strB);
   reportCompare(expect, actual, status);
 
+*************************  END OF INCORRECT CASES ****************************/
+
+
+//////////////////////////  OK, LET'S START OVER //////////////////////////////
+
+  status = 'Section 1 of test';
+  actual = 'abc'.replace('a', 'Z');
+  expect = 'Zbc';
+  reportCompare(expect, actual, status);
+
+  status = 'Section 2 of test';
+  actual = 'abc'.replace('b', 'Z');
+  expect = 'aZc';
+  reportCompare(expect, actual, status);
+
+  status = 'Section 3 of test';
+  actual = 'abc'.replace(undefined, 'Z');
+  expect = 'abc'; // String(undefined) == 'undefined'; no replacement possible
+  reportCompare(expect, actual, status);
+
+  status = 'Section 4 of test';
+  actual = 'abc'.replace(null, 'Z');
+  expect = 'abc'; // String(null) == 'null'; no replacement possible
+  reportCompare(expect, actual, status);
+
+  status = 'Section 5 of test';
+  actual = 'abc'.replace(true, 'Z');
+  expect = 'abc'; // String(true) == 'true'; no replacement possible
+  reportCompare(expect, actual, status);
+
+  status = 'Section 6 of test';
+  actual = 'abc'.replace(false, 'Z');
+  expect = 'abc'; // String(false) == 'false'; no replacement possible
+  reportCompare(expect, actual, status);
+
+  status = 'Section 7 of test';
+  actual = 'aa$aa'.replace('$', 'Z');
+  expect = 'aaZaa'; // NOT 'aa$aaZ' as in ECMA Final Draft; see above
+  reportCompare(expect, actual, status);
+
+  status = 'Section 8 of test';
+  actual = 'abc'.replace('.*', 'Z');
+  expect = 'abc';  // not 'Z' as in EMCA Final Draft
+  reportCompare(expect, actual, status);
+
+  status = 'Section 9 of test';
+  actual = 'abc'.replace('', 'Z');
+  expect = 'Zabc';  // Still expect 'Zabc' for this
+  reportCompare(expect, actual, status);
+
   exitFunc ('test');
 }