Bug 575657 - [e10s] TabChild should use NS_NOTREACHED in addition to NS_ERROR_NOT_IMPLEMENTED r=doug.turner a=approval2.0

dom/ipc/TabChild.cpp

@@ -161,18 +161,24 @@ NS_IMPL_RELEASE(TabChild)
 NS_IMETHODIMP
 TabChild::SetStatus(PRUint32 aStatusType, const PRUnichar* aStatus)
 {
+  NS_NOTREACHED("TabChild::SetStatus not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::GetWebBrowser(nsIWebBrowser** aWebBrowser)
 {
+  NS_NOTREACHED("TabChild::GetWebBrowser not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::SetWebBrowser(nsIWebBrowser* aWebBrowser)
 {
+  NS_NOTREACHED("TabChild::SetWebBrowser not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
@@ -186,25 +192,32 @@ TabChild::GetChromeFlags(PRUint32* aChromeFlags)
 NS_IMETHODIMP
 TabChild::SetChromeFlags(PRUint32 aChromeFlags)
 {
-  NS_ERROR("trying to SetChromeFlags from content process?");
+  NS_NOTREACHED("trying to SetChromeFlags from content process?");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::DestroyBrowserWindow()
 {
+  NS_NOTREACHED("TabChild::SetWebBrowser not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::SizeBrowserTo(PRInt32 aCX, PRInt32 aCY)
 {
+  NS_NOTREACHED("TabChild::SizeBrowserTo not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::ShowAsModal()
 {
+  NS_NOTREACHED("TabChild::ShowAsModal not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
@@ -218,6 +231,8 @@ TabChild::IsWindowModal(PRBool* aRetVal)
 NS_IMETHODIMP
 TabChild::ExitModalEventLoop(nsresult aStatus)
 {
+  NS_NOTREACHED("TabChild::ExitModalEventLoop not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
@@ -226,6 +241,8 @@ TabChild::SetStatusWithContext(PRUint32 aStatusType,
                                     const nsAString& aStatusText,
                                     nsISupports* aStatusContext)
 {
+  NS_NOTREACHED("TabChild::SetStatusWithContext not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
@@ -233,6 +250,8 @@ NS_IMETHODIMP
 TabChild::SetDimensions(PRUint32 aFlags, PRInt32 aX, PRInt32 aY,
                              PRInt32 aCx, PRInt32 aCy)
 {
+  NS_NOTREACHED("TabChild::SetDimensions not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
@@ -240,12 +259,16 @@ NS_IMETHODIMP
 TabChild::GetDimensions(PRUint32 aFlags, PRInt32* aX,
                              PRInt32* aY, PRInt32* aCx, PRInt32* aCy)
 {
+  NS_NOTREACHED("TabChild::GetDimensions not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::SetFocus()
 {
+  NS_NOTREACHED("TabChild::SetFocus not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
@@ -259,30 +282,40 @@ TabChild::GetVisibility(PRBool* aVisibility)
 NS_IMETHODIMP
 TabChild::SetVisibility(PRBool aVisibility)
 {
+  NS_NOTREACHED("TabChild::SetVisibility not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::GetTitle(PRUnichar** aTitle)
 {
+  NS_NOTREACHED("TabChild::GetTitle not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::SetTitle(const PRUnichar* aTitle)
 {
+  NS_NOTREACHED("TabChild::SetTitle not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::GetSiteWindow(void** aSiteWindow)
 {
+  NS_NOTREACHED("TabChild::GetSiteWindow not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }
 
 NS_IMETHODIMP
 TabChild::Blur()
 {
+  NS_NOTREACHED("TabChild::Blur not supported in TabChild");
+
   return NS_ERROR_NOT_IMPLEMENTED;
 }