From 071f758a3753687ef4a934fc0eabbdf110235bcf Mon Sep 17 00:00:00 2001
From: Edouard Oger <eoger@fastmail.com>
Date: Mon, 29 Jan 2018 17:11:16 -0500
Subject: [PATCH] Bug 1434078 - Devices actions links touch-ups. r=markh

MozReview-Commit-ID: I0q915ku8o8

--HG--
extra : rebase_source : 1e3b54262c8eba4f30732eba41affaf63903809e
---
 browser/components/preferences/in-content/sync.js      |  5 +++--
 browser/components/preferences/in-content/sync.xul     | 10 ++++++----
 .../themes/shared/incontentprefs/preferences.inc.css   |  6 +++++-
 3 files changed, 14 insertions(+), 7 deletions(-)

diff --git a/browser/components/preferences/in-content/sync.js b/browser/components/preferences/in-content/sync.js
index 15fd91ee77cc..98186978a683 100644
--- a/browser/components/preferences/in-content/sync.js
+++ b/browser/components/preferences/in-content/sync.js
@@ -329,10 +329,11 @@ var gSyncPane = {
     fxAccounts.promiseAccountsManageURI(this._getEntryPoint()).then(accountsManageURI => {
       document.getElementById("verifiedManage").setAttribute("href", accountsManageURI);
     });
+    let isUnverified = state.status == UIState.STATUS_NOT_VERIFIED;
     // The mobile promo links - which one is shown depends on the number of devices.
     let isMultiDevice = Weave.Service.clientsEngine.stats.numClients > 1;
-    document.getElementById("mobilePromo-singledevice").hidden = isMultiDevice;
-    document.getElementById("mobilePromo-multidevice").hidden = !isMultiDevice;
+    document.getElementById("mobilePromo-singledevice").hidden = isUnverified || isMultiDevice;
+    document.getElementById("mobilePromo-multidevice").hidden = isUnverified || !isMultiDevice;
   },
 
   _getEntryPoint() {
diff --git a/browser/components/preferences/in-content/sync.xul b/browser/components/preferences/in-content/sync.xul
index 892df96de814..8fffd3489ec9 100755
--- a/browser/components/preferences/in-content/sync.xul
+++ b/browser/components/preferences/in-content/sync.xul
@@ -205,10 +205,12 @@
                 hidden="true"/>
       </hbox>
     </groupbox>
-    <label id="mobilePromo-singledevice"
-           class="text-link fxaMobilePromo">&mobilepromo.singledevice;</label>
-    <label id="mobilePromo-multidevice"
-           class="text-link fxaMobilePromo">&mobilepromo.multidevice;</label>
+    <vbox align="start">
+      <label id="mobilePromo-singledevice"
+             class="text-link fxaMobilePromo">&mobilepromo.singledevice;</label>
+      <label id="mobilePromo-multidevice"
+             class="text-link fxaMobilePromo">&mobilepromo.multidevice;</label>
+    </vbox>
     <vbox id="tosPP-small" align="start">
       <label id="tosPP-small-ToS" class="text-link">
         &prefs.tosLink.label;
diff --git a/browser/themes/shared/incontentprefs/preferences.inc.css b/browser/themes/shared/incontentprefs/preferences.inc.css
index 9d7c81a0ddbc..288e1c602508 100644
--- a/browser/themes/shared/incontentprefs/preferences.inc.css
+++ b/browser/themes/shared/incontentprefs/preferences.inc.css
@@ -548,6 +548,10 @@ button > hbox > label {
   margin-bottom: 4px;
 }
 
+#tosPP-small {
+  margin-top: 32px;
+}
+
 #tosPP-small-ToS {
   margin-bottom: 14px;
 }
@@ -608,7 +612,7 @@ button > hbox > label {
 }
 
 .fxaMobilePromo {
-  margin: 2px 0 32px 0 !important;
+  margin-top: 2px !important;
 }
 
 .androidLink {