Bug 1644780 - Removed diagnostic assertion when db::IncrementalVacuum fails. r=dom-workers-and-storage-reviewers,janv

Differential Revision: https://phabricator.services.mozilla.com/D82551

dom/cache/Connection.cpp

@@ -38,16 +38,8 @@ Connection::Close() {
   mClosed = true;
 
   // If we are closing here, then Cache must not have a transaction
-  // open anywhere else.  This should be guaranteed to succeed.
-  nsresult rv = db::IncrementalVacuum(this);
-  if (NS_WARN_IF(NS_FAILED(rv))) {
-    // In non-diagnostic builds, just ignore that vacuuming failed, and continue
-    // to close the connection.
-#if defined(MOZ_DIAGNOSTIC_ASSERT_ENABLED)
-    MOZ_CRASH_UNSAFE_PRINTF("db::IncrementalVacuum failed with result 0x%08x",
-                            static_cast<uint32_t>(rv));
-#endif
-  }
+  // open anywhere else.  This may fail if storage is corrupted.
+  Unused << NS_WARN_IF(NS_FAILED(db::IncrementalVacuum(this)));
 
   return mBase->Close();
 }