Bug 1399031 - Add a Tls{Get,Set}Value-based ThreadLocal implementation for Windows. r=froydnj

--HG--
extra : rebase_source : 13a407d35973ba2ed6da29195f5ce8a2c0f7cff4

mfbt/ThreadLocal.h

@@ -68,26 +68,59 @@ namespace detail {
  * // Get the TLS value
  * int value = tlsKey.get();
  */
-#ifndef XP_WIN
+
+// Integral types narrower than void* must be extended to avoid
+// warnings from valgrind on some platforms.  This helper type
+// achieves that without penalizing the common case of ThreadLocals
+// instantiated using a pointer type.
+template<typename S>
+struct Helper
+{
+  typedef uintptr_t Type;
+};
+
+template<typename S>
+struct Helper<S *>
+{
+  typedef S *Type;
+};
+
+#ifdef XP_WIN
+/* Despite not being used for MOZ_THREAD_LOCAL, we expose an implementation for
+ * Windows for cases where it's not desirable to use thread_local */
 template<typename T>
 class ThreadLocalKeyStorage
 {
-  // Integral types narrower than void* must be extended to avoid
+public:
-  // warnings from valgrind on some platforms.  This helper type
+  ThreadLocalKeyStorage()
-  // achieves that without penalizing the common case of ThreadLocals
+    : mKey(TLS_OUT_OF_INDEXES)
-  // instantiated using a pointer type.
+  {}
-  template<typename S>
-  struct Helper
-  {
-    typedef uintptr_t Type;
-  };
 
-  template<typename S>
+  inline bool initialized() const {
-  struct Helper<S *>
+    return mKey != TLS_OUT_OF_INDEXES;
-  {
+  }
-    typedef S *Type;
-  };
 
+  inline void init() {
+    mKey = TlsAlloc();
+  }
+
+  inline T get() const {
+    void* h = TlsGetValue(mKey);
+    return static_cast<T>(reinterpret_cast<typename Helper<T>::Type>(h));
+  }
+
+  inline bool set(const T aValue) {
+    void* h = reinterpret_cast<void*>(static_cast<typename Helper<T>::Type>(aValue));
+    return TlsSetValue(mKey, h);
+  }
+
+private:
+  unsigned long mKey;
+};
+#else
+template<typename T>
+class ThreadLocalKeyStorage
+{
 public:
   ThreadLocalKeyStorage()
     : mKey(0), mInited(false)