Bug 1613985 - Use default for equivalent-to-default constructors/destructors in dom/xul. r=smaug

Differential Revision: https://phabricator.services.mozilla.com/D63172

--HG--
extra : moz-landing-system : lando

dom/xul/ChromeObserver.cpp

@@ -27,7 +27,7 @@ NS_IMPL_ISUPPORTS(ChromeObserver, nsIMutationObserver)
 ChromeObserver::ChromeObserver(Document* aDocument)
     : nsStubMutationObserver(), mDocument(aDocument) {}
 
-ChromeObserver::~ChromeObserver() {}
+ChromeObserver::~ChromeObserver() = default;
 
 void ChromeObserver::Init() {
   mDocument->AddMutationObserver(this);

dom/xul/XULBroadcastManager.cpp

@@ -26,10 +26,9 @@ struct BroadcasterMapEntry : public PLDHashEntryHdr {
 struct nsAttrNameInfo {
   nsAttrNameInfo(int32_t aNamespaceID, nsAtom* aName, nsAtom* aPrefix)
       : mNamespaceID(aNamespaceID), mName(aName), mPrefix(aPrefix) {}
-  nsAttrNameInfo(const nsAttrNameInfo& aOther)
-      : mNamespaceID(aOther.mNamespaceID),
-        mName(aOther.mName),
-        mPrefix(aOther.mPrefix) {}
+  nsAttrNameInfo(const nsAttrNameInfo& aOther) = delete;
+  nsAttrNameInfo(nsAttrNameInfo&& aOther) = default;
+
   int32_t mNamespaceID;
   RefPtr<nsAtom> mName;
   RefPtr<nsAtom> mPrefix;
@@ -95,8 +94,7 @@ void XULBroadcastManager::SynchronizeBroadcastListener(Element* aBroadcaster,
                                                        Element* aListener,
                                                        const nsAString& aAttr) {
   if (!nsContentUtils::IsSafeToRunScript()) {
-    nsDelayedBroadcastUpdate delayedUpdate(aBroadcaster, aListener, aAttr);
-    mDelayedBroadcasters.AppendElement(delayedUpdate);
+    mDelayedBroadcasters.EmplaceBack(aBroadcaster, aListener, aAttr);
     MaybeBroadcast();
     return;
   }
@@ -351,7 +349,8 @@ void XULBroadcastManager::AttributeChanged(Element* aElement,
               mDelayedAttrChangeBroadcasts.RemoveElementAt(index);
             }
 
-            mDelayedAttrChangeBroadcasts.AppendElement(delayedUpdate);
+            mDelayedAttrChangeBroadcasts.AppendElement(
+                std::move(delayedUpdate));
           }
         }
       }

dom/xul/XULBroadcastManager.h

@@ -87,13 +87,8 @@ class XULBroadcastManager final {
           mSetAttr(aSetAttr),
           mNeedsAttrChange(aNeedsAttrChange) {}
 
-    nsDelayedBroadcastUpdate(const nsDelayedBroadcastUpdate& aOther)
-        : mBroadcaster(aOther.mBroadcaster),
-          mListener(aOther.mListener),
-          mAttr(aOther.mAttr),
-          mAttrName(aOther.mAttrName),
-          mSetAttr(aOther.mSetAttr),
-          mNeedsAttrChange(aOther.mNeedsAttrChange) {}
+    nsDelayedBroadcastUpdate(const nsDelayedBroadcastUpdate& aOther) = delete;
+    nsDelayedBroadcastUpdate(nsDelayedBroadcastUpdate&& aOther) = default;
 
     nsCOMPtr<Element> mBroadcaster;
     nsCOMPtr<Element> mListener;

dom/xul/XULFrameElement.h

@@ -69,7 +69,7 @@ class XULFrameElement final : public nsXULElement, public nsFrameLoaderOwner {
                                              nsGkAtoms::editor))
 
  protected:
-  virtual ~XULFrameElement() {}
+  virtual ~XULFrameElement() = default;
 
   RefPtr<BrowsingContext> mOpener;
 

dom/xul/XULMenuElement.h

@@ -25,7 +25,7 @@ class XULMenuElement final : public nsXULElement {
   MOZ_CAN_RUN_SCRIPT bool OpenedWithKey();
 
  private:
-  virtual ~XULMenuElement() {}
+  virtual ~XULMenuElement() = default;
   JSObject* WrapNode(JSContext* aCx, JS::Handle<JSObject*> aGivenProto) final;
 
   nsIFrame* GetFrame();

dom/xul/XULPersist.cpp

@@ -45,7 +45,7 @@ NS_IMPL_ISUPPORTS(XULPersist, nsIDocumentObserver)
 XULPersist::XULPersist(Document* aDocument)
     : nsStubDocumentObserver(), mDocument(aDocument) {}
 
-XULPersist::~XULPersist() {}
+XULPersist::~XULPersist() = default;
 
 void XULPersist::Init() {
   ApplyPersistentAttributes();

dom/xul/XULPopupElement.h

@@ -90,7 +90,7 @@ class XULPopupElement : public nsXULElement {
   void SetConstraintRect(DOMRectReadOnly& aRect);
 
  protected:
-  virtual ~XULPopupElement() {}
+  virtual ~XULPopupElement() = default;
 
   JSObject* WrapNode(JSContext* aCx,
                      JS::Handle<JSObject*> aGivenProto) override;

dom/xul/XULTextElement.h

@@ -35,7 +35,7 @@ class XULTextElement final : public nsXULElement {
   }
 
  protected:
-  virtual ~XULTextElement() {}
+  virtual ~XULTextElement() = default;
   JSObject* WrapNode(JSContext* aCx, JS::Handle<JSObject*> aGivenProto) final;
 };
 

dom/xul/XULTooltipElement.h

@@ -30,7 +30,7 @@ class XULTooltipElement final : public XULPopupElement {
   virtual nsresult PostHandleEvent(EventChainPostVisitor& aVisitor) override;
 
  protected:
-  virtual ~XULTooltipElement() {}
+  virtual ~XULTooltipElement() = default;
 };
 
 }  // namespace dom

dom/xul/XULTreeElement.h

@@ -116,7 +116,7 @@ class XULTreeElement final : public nsXULElement {
   nsTreeBodyFrame* mTreeBody;
   nsCOMPtr<nsITreeView> mView;
 
-  virtual ~XULTreeElement() {}
+  virtual ~XULTreeElement() = default;
 
   JSObject* WrapNode(JSContext* aCx,
                      JS::Handle<JSObject*> aGivenProto) override;

dom/xul/nsXULControllers.h

@@ -23,7 +23,7 @@ class nsXULControllerData final {
   nsXULControllerData(uint32_t inControllerID, nsIController* inController)
       : mControllerID(inControllerID), mController(inController) {}
 
-  ~nsXULControllerData() {}
+  ~nsXULControllerData() = default;
 
   uint32_t GetControllerID() { return mControllerID; }
 

dom/xul/nsXULElement.cpp

@@ -103,7 +103,7 @@ nsXULElement::nsXULElement(already_AddRefed<mozilla::dom::NodeInfo>&& aNodeInfo)
   XUL_PROTOTYPE_ATTRIBUTE_METER(gNumElements);
 }
 
-nsXULElement::~nsXULElement() {}
+nsXULElement::~nsXULElement() = default;
 
 void nsXULElement::MaybeUpdatePrivateLifetime() {
   if (AttrValueIs(kNameSpaceID_None, nsGkAtoms::windowtype,

dom/xul/nsXULElement.h

@@ -126,7 +126,7 @@ class nsXULPrototypeNode {
 
  protected:
   explicit nsXULPrototypeNode(Type aType) : mType(aType) {}
-  virtual ~nsXULPrototypeNode() {}
+  virtual ~nsXULPrototypeNode() = default;
 };
 
 class nsXULPrototypeElement : public nsXULPrototypeNode {
@@ -239,7 +239,7 @@ class nsXULPrototypeText : public nsXULPrototypeNode {
   nsXULPrototypeText() : nsXULPrototypeNode(eType_Text) {}
 
  private:
-  virtual ~nsXULPrototypeText() {}
+  virtual ~nsXULPrototypeText() = default;
 
  public:
   virtual nsresult Serialize(
@@ -258,7 +258,7 @@ class nsXULPrototypePI : public nsXULPrototypeNode {
   nsXULPrototypePI() : nsXULPrototypeNode(eType_PI) {}
 
  private:
-  virtual ~nsXULPrototypePI() {}
+  virtual ~nsXULPrototypePI() = default;
 
  public:
   virtual nsresult Serialize(

dom/xul/nsXULPrototypeCache.cpp

@@ -68,7 +68,7 @@ static void DisableXULCacheChangedCallback(const char* aPref, void* aClosure) {
 
 nsXULPrototypeCache* nsXULPrototypeCache::sInstance = nullptr;
 
-nsXULPrototypeCache::nsXULPrototypeCache() {}
+nsXULPrototypeCache::nsXULPrototypeCache() = default;
 
 nsXULPrototypeCache::~nsXULPrototypeCache() { FlushScripts(); }