From 096bfd3558f2222383c63c05ecd9701fd7c6aadf Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Wed, 19 Jan 2022 16:43:34 +0000 Subject: [PATCH] Bug 1747934 - Apply line-height to ::marker. r=layout-reviewers,jfkthame Differential Revision: https://phabricator.services.mozilla.com/D136313 --- layout/style/test/property_database.js | 1 + servo/components/style/properties/data.py | 1 + .../meta/css/css-pseudo/marker-line-height.html.ini | 2 -- .../css-pseudo/parsing/marker-supported-properties.html.ini | 6 ------ 4 files changed, 2 insertions(+), 8 deletions(-) delete mode 100644 testing/web-platform/meta/css/css-pseudo/marker-line-height.html.ini diff --git a/layout/style/test/property_database.js b/layout/style/test/property_database.js index ef6f67b40969..f6d3f603f2e0 100644 --- a/layout/style/test/property_database.js +++ b/layout/style/test/property_database.js @@ -6126,6 +6126,7 @@ var gCSSProperties = { domProp: "lineHeight", inherited: true, type: CSS_TYPE_LONGHAND, + applies_to_marker: true, applies_to_first_letter: true, applies_to_first_line: true, applies_to_placeholder: true, diff --git a/servo/components/style/properties/data.py b/servo/components/style/properties/data.py index 740815bcb380..17d398b0aaad 100644 --- a/servo/components/style/properties/data.py +++ b/servo/components/style/properties/data.py @@ -889,6 +889,7 @@ class PropertyRestrictions: "unicode-bidi", "direction", "content", + "line-height", "-moz-osx-font-smoothing", ] + PropertyRestrictions.spec(data, "css-fonts") diff --git a/testing/web-platform/meta/css/css-pseudo/marker-line-height.html.ini b/testing/web-platform/meta/css/css-pseudo/marker-line-height.html.ini deleted file mode 100644 index 0099d3c81509..000000000000 --- a/testing/web-platform/meta/css/css-pseudo/marker-line-height.html.ini +++ /dev/null @@ -1,2 +0,0 @@ -[marker-line-height.html] - expected: FAIL diff --git a/testing/web-platform/meta/css/css-pseudo/parsing/marker-supported-properties.html.ini b/testing/web-platform/meta/css/css-pseudo/parsing/marker-supported-properties.html.ini index 90722b0c7057..e8d8d1fdbbef 100644 --- a/testing/web-platform/meta/css/css-pseudo/parsing/marker-supported-properties.html.ini +++ b/testing/web-platform/meta/css/css-pseudo/parsing/marker-supported-properties.html.ini @@ -2,9 +2,6 @@ [Property list-style value 'inside url('foo') decimal' in ::marker] expected: FAIL - [Property font value 'italic small-caps 900 expanded 25px / 50px Ahem' in ::marker] - expected: FAIL - [Property text-shadow value 'rgb(0, 255, 0) 1px 2px 3px' in ::marker] expected: FAIL @@ -38,9 +35,6 @@ [Property word-break value 'break-word' in ::marker] expected: FAIL - [Property line-height value '50px' in ::marker] - expected: FAIL - [Property font-synthesis-small-caps value 'none' in ::marker] expected: FAIL