From 0b706ae8af570933a4d7917178736e3d50088485 Mon Sep 17 00:00:00 2001
From: Vivien Nicolas <21@vingtetun.org>
Date: Thu, 4 Nov 2010 18:17:31 +0100
Subject: [PATCH] Bug 608957 - Go To Page button in the addons section are
 clickable when there is no addon homepage available [r=mfinkle]

---
 mobile/chrome/content/bindings/extensions.xml | 11 ++++++++++-
 mobile/chrome/content/extensions.js           |  7 ++++---
 2 files changed, 14 insertions(+), 4 deletions(-)

diff --git a/mobile/chrome/content/bindings/extensions.xml b/mobile/chrome/content/bindings/extensions.xml
index 677e7bc8697c..67bb53d2706c 100644
--- a/mobile/chrome/content/bindings/extensions.xml
+++ b/mobile/chrome/content/bindings/extensions.xml
@@ -173,6 +173,15 @@
   </binding>
 
   <binding id="extension-search" extends="chrome://browser/content/bindings.xml#richlistitem">
+    <implementation>
+      <field name="_showPageButton">document.getAnonymousElementByAttribute(this, "anonid", "show-page");</field>
+      <constructor>
+        <![CDATA[
+          if (!this.hasAttribute("homepageURL"))
+            this._showPageButton.setAttribute("disabled", "true");
+        ]]>
+      </constructor>
+    </implementation>
     <content orient="vertical">
       <xul:hbox align="start">
         <xul:image xbl:inherits="src=iconURL"/>
@@ -192,7 +201,7 @@
       </xul:hbox>
       <xul:vbox flex="1">
         <xul:hbox class="show-on-select">
-          <xul:button class="addon-install hide-on-install hide-on-restart" label="&addonShowPage.label;"
+          <xul:button anonid="show-page" class="addon-install hide-on-install hide-on-restart" label="&addonShowPage.label;"
                       oncommand="ExtensionsView.showPage(document.getBindingParent(this));"/>
           <xul:spacer flex="1"/>
           <xul:button class="addon-install hide-on-install hide-on-restart" label="&addonInstall2.label;"
diff --git a/mobile/chrome/content/extensions.js b/mobile/chrome/content/extensions.js
index b11949739358..85215599afeb 100644
--- a/mobile/chrome/content/extensions.js
+++ b/mobile/chrome/content/extensions.js
@@ -490,8 +490,8 @@ var ExtensionsView = {
   },
 
   appendSearchResults: function(aAddons, aShowRating) {
-    var urlproperties = [ "iconURL", "homepageURL" ];
-    var foundItem = false;
+    let urlproperties = [ "iconURL", "homepageURL" ];
+    let foundItem = false;
     for (let i = 0; i < aAddons.length; i++) {
       let addon = aAddons[i];
 
@@ -514,7 +514,8 @@ var ExtensionsView = {
 
       let listitem = this._createItem(addon, "search");
       listitem.setAttribute("description", addon.description);
-      listitem.setAttribute("homepageURL", addon.homepageURL);
+      if (addon.homepageURL)
+        listitem.setAttribute("homepageURL", addon.homepageURL);
       listitem.install = addon.install;
       listitem.setAttribute("sourceURL", addon.install.sourceURI.spec);
       if (aShowRating)