Bug 758992 - Make the classes which use the XPCOM nsISupports implementation macros final, to avoid the warning about deleting using a pointer to a base class with virtual functions and no virtual dtor (more toolkit parts); blanket-r=bzbarsky

--HG--
extra : rebase_source : 98c2cd6dce6c45173693a11a618cc7b94fb69595

toolkit/components/filepicker/nsFileView.cpp

@@ -25,6 +25,7 @@
 #include "nsAutoPtr.h"
 #include "nsIMutableArray.h"
 #include "nsTArray.h"
+#include "mozilla/Attributes.h"
 
 #include "nsWildCard.h"
 
@@ -34,7 +35,7 @@ class nsIDOMDataTransfer;
                             { 0x91, 0x10, 0x81, 0x46, 0x61, 0x4c, 0xa7, 0xf0 } }
 #define NS_FILECOMPLETE_CONTRACTID "@mozilla.org/autocomplete/search;1?name=file"
 
-class nsFileResult : public nsIAutoCompleteResult
+class nsFileResult MOZ_FINAL : public nsIAutoCompleteResult
 {
 public:
   // aSearchString is the text typed into the autocomplete widget
@@ -169,7 +170,7 @@ NS_IMETHODIMP nsFileResult::RemoveValueAt(PRInt32 rowIndex, bool removeFromDb)
   return NS_OK;
 }
 
-class nsFileComplete : public nsIAutoCompleteSearch
+class nsFileComplete MOZ_FINAL : public nsIAutoCompleteSearch
 {
 public:
   NS_DECL_ISUPPORTS

toolkit/components/remote/nsGTKRemoteService.h

@@ -14,8 +14,9 @@
 
 #include "nsInterfaceHashtable.h"
 #include "nsXRemoteService.h"
+#include "mozilla/Attributes.h"
 
-class nsGTKRemoteService : public nsXRemoteService
+class nsGTKRemoteService MOZ_FINAL : public nsXRemoteService
 {
 public:
   // We will be a static singleton, so don't use the ordinary methods.

toolkit/system/unixproxy/nsUnixSystemProxySettings.cpp

@@ -17,8 +17,9 @@
 #include "nsISupportsPrimitives.h"
 #include "nsIGSettingsService.h"
 #include "nsInterfaceHashtable.h"
+#include "mozilla/Attributes.h"
 
-class nsUnixSystemProxySettings : public nsISystemProxySettings {
+class nsUnixSystemProxySettings MOZ_FINAL : public nsISystemProxySettings {
 public:
   NS_DECL_ISUPPORTS
   NS_DECL_NSISYSTEMPROXYSETTINGS