From 0d11f0c9ee31cf8f971a3c571e3b156df4d23571 Mon Sep 17 00:00:00 2001 From: Morten Stenshorne Date: Wed, 15 Aug 2018 09:54:59 +0000 Subject: [PATCH] Bug 1482432 [wpt PR 12412] - [LayoutNG] Flip for writing mode when calculating inline bounding box., a=testonly MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Automatic update from web-platform-tests[LayoutNG] Flip for writing mode when calculating inline bounding box. LayoutInline::LinesVisualOverflowBoundingBox() is expected to return coordinates with a logical block coordinate. So we need to flip for writing-mode vertical-rl. Discovered while investigating why wpt/css/css-position/position-sticky-writing-modes.html fails. It had some weird repaint issues (that I discovered when picking the test apart) that this CL fixes. That's not enough to fix the test, though. Cq-Include-Trybots: luci.chromium.try​:linux_layout_tests_layout_ng Change-Id: I9a8930cc6de01991592282491677327e3406acfb Reviewed-on: https://chromium-review.googlesource.com/1170835 Reviewed-by: Aleks Totic Commit-Queue: Morten Stenshorne Cr-Commit-Position: refs/heads/master@{#582222} -- wpt-commits: c960c4cf4c4849ee5207d9235bb4da7939a53d58 wpt-pr: 12412 --- testing/web-platform/meta/MANIFEST.json | 16 ++++++++++++++++ .../relpos-inline-overflowing-block-vrl.html | 12 ++++++++++++ 2 files changed, 28 insertions(+) create mode 100644 testing/web-platform/tests/css/css-writing-modes/relpos-inline-overflowing-block-vrl.html diff --git a/testing/web-platform/meta/MANIFEST.json b/testing/web-platform/meta/MANIFEST.json index 872fed331df3..c983e499cd11 100644 --- a/testing/web-platform/meta/MANIFEST.json +++ b/testing/web-platform/meta/MANIFEST.json @@ -160937,6 +160937,18 @@ {} ] ], + "css/css-writing-modes/relpos-inline-overflowing-block-vrl.html": [ + [ + "/css/css-writing-modes/relpos-inline-overflowing-block-vrl.html", + [ + [ + "/css/reference/ref-filled-green-100px-square.xht", + "==" + ] + ], + {} + ] + ], "css/css-writing-modes/row-progression-slr-023.xht": [ [ "/css/css-writing-modes/row-progression-slr-023.xht", @@ -562875,6 +562887,10 @@ "5dccf5071e82905297c33bde6e019ad4b9c019cd", "support" ], + "css/css-writing-modes/relpos-inline-overflowing-block-vrl.html": [ + "ea075c3f95e176c4fd4935fb2d305fc5bcf277da", + "reftest" + ], "css/css-writing-modes/replaced-content-image-002.xht": [ "ef650ee1bd4d4e27dccbbede2e3eaf5dfb8bd635", "visual" diff --git a/testing/web-platform/tests/css/css-writing-modes/relpos-inline-overflowing-block-vrl.html b/testing/web-platform/tests/css/css-writing-modes/relpos-inline-overflowing-block-vrl.html new file mode 100644 index 000000000000..ea075c3f95e1 --- /dev/null +++ b/testing/web-platform/tests/css/css-writing-modes/relpos-inline-overflowing-block-vrl.html @@ -0,0 +1,12 @@ + +vertical-rl, relatively positioned inline in block that overflows smaller parent + + + +

Test passes if there is a filled green square and no red.

+
+
+
+ XXX +
+