From 0d33e4db2dbdeb544679a81fe140124f8dc58b14 Mon Sep 17 00:00:00 2001 From: Henrik Skupin Date: Mon, 21 Dec 2020 12:50:44 +0000 Subject: [PATCH] Bug 1606604 - [remote] Disable experimental SameSite=Lax by default. r=remote-protocol-reviewers,jgraham Differential Revision: https://phabricator.services.mozilla.com/D100168 --- remote/puppeteer-expected.json | 6 +++--- remote/test/puppeteer/src/node/Launcher.ts | 3 +++ 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/remote/puppeteer-expected.json b/remote/puppeteer-expected.json index 16714849a3d1..812566c89a47 100644 --- a/remote/puppeteer-expected.json +++ b/remote/puppeteer-expected.json @@ -183,7 +183,7 @@ "PASS" ], "Cookie specs Page.cookies should get a cookie (cookies.spec.ts)": [ - "FAIL" + "PASS" ], "Cookie specs Page.cookies should properly report httpOnly cookie (cookies.spec.ts)": [ "PASS" @@ -195,7 +195,7 @@ "PASS" ], "Cookie specs Page.cookies should get multiple cookies (cookies.spec.ts)": [ - "FAIL" + "PASS" ], "Cookie specs Page.cookies should get cookies from multiple urls (cookies.spec.ts)": [ "FAIL" @@ -246,7 +246,7 @@ "FAIL" ], "DefaultBrowserContext page.cookies() should work (defaultbrowsercontext.spec.ts)": [ - "FAIL" + "PASS" ], "DefaultBrowserContext page.setCookie() should work (defaultbrowsercontext.spec.ts)": [ "FAIL" diff --git a/remote/test/puppeteer/src/node/Launcher.ts b/remote/test/puppeteer/src/node/Launcher.ts index 6d05021078fc..8ca62db389cc 100644 --- a/remote/test/puppeteer/src/node/Launcher.ts +++ b/remote/test/puppeteer/src/node/Launcher.ts @@ -517,6 +517,9 @@ class FirefoxLauncher implements ProductLauncher { // jest-puppeteer asserts that no error message is emitted by the console 'network.cookie.cookieBehavior': 0, + // Disable experimental feature that is only available in Nightly + 'network.cookie.sameSite.laxByDefault': false, + // Do not prompt for temporary redirects 'network.http.prompt-temp-redirect': false,