From 0d5925b408e5dc0e0ba3e1c5e1f87fbd73571498 Mon Sep 17 00:00:00 2001 From: Trevor Saunders Date: Fri, 20 Jan 2017 14:30:40 -0500 Subject: [PATCH] bug 1332690 - return failure from DocAccessibleParent::RecvShow() when appropriate r=yzen --- accessible/ipc/DocAccessibleParent.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/accessible/ipc/DocAccessibleParent.cpp b/accessible/ipc/DocAccessibleParent.cpp index d133293dea78..da1ad5f1ecab 100644 --- a/accessible/ipc/DocAccessibleParent.cpp +++ b/accessible/ipc/DocAccessibleParent.cpp @@ -35,13 +35,13 @@ DocAccessibleParent::RecvShowEvent(const ShowEventData& aData, // required show events. if (!parent) { NS_ERROR("adding child to unknown accessible"); - return IPC_OK(); + return IPC_FAIL(this, "unknown parent accessible"); } uint32_t newChildIdx = aData.Idx(); if (newChildIdx > parent->ChildrenCount()) { NS_ERROR("invalid index to add child at"); - return IPC_OK(); + return IPC_FAIL(this, "invalid index"); } uint32_t consumed = AddSubtree(parent, aData.NewTree(), 0, newChildIdx); @@ -50,7 +50,7 @@ DocAccessibleParent::RecvShowEvent(const ShowEventData& aData, // XXX This shouldn't happen, but if we failed to add children then the below // is pointless and can crash. if (!consumed) { - return IPC_OK(); + return IPC_FAIL(this, "failed to add children"); } #ifdef DEBUG