Backed out changeset e511290b39cc (bug 1784432) for causing browser-chrome failures in browser/components/extensions/test/browser/browser_ext_menus_events.js CLOSED TREE

browser/base/content/browser-allTabsMenu.js

@@ -139,10 +139,6 @@ var gTabsPanel = {
   },
 
   showAllTabsPanel(event) {
-    // Only space and enter should open the popup, ignore other keypresses:
-    if (event.type == "keypress" && event.key != "Enter" && event.key != " ") {
-      return;
-    }
     this.init();
     if (this.canOpen) {
       PanelUI.showSubView(

browser/base/content/navigator-toolbox.inc.xhtml

@@ -92,7 +92,6 @@
           <toolbarbutton id="alltabs-button"
                          class="toolbarbutton-1 chromeclass-toolbar-additional tabs-alltabs-button"
                          badged="true"
-                         onkeypress="gTabsPanel.showAllTabsPanel(event);"
                          onmousedown="gTabsPanel.showAllTabsPanel(event);"
                          data-l10n-id="tabs-toolbar-list-all-tabs"
                          removable="false"/>

browser/base/content/test/tabs/browser.ini

@@ -59,7 +59,6 @@ support-files = tab_that_closes.html
 [browser_multiselect_tabs_move_to_another_window_drag.js]
 [browser_multiselect_tabs_move_to_new_window_contextmenu.js]
 https_first_disabled = true
-[browser_tab_manager_keyboard_access.js]
 [browser_tab_play.js]
 [browser_multiselect_tabs_move.js]
 [browser_multiselect_tabs_mute_unmute.js]

browser/base/content/test/tabs/browser_tab_manager_keyboard_access.js

@@ -1,37 +0,0 @@
-/* Any copyright is dedicated to the Public Domain.
-   http://creativecommons.org/publicdomain/zero/1.0/ */
-
-"use strict";
-
-/**
- * Check we can open the tab manager using the keyboard.
- * Note that navigation to buttons in the toolbar is covered
- * by other tests.
- */
-add_task(async function test_open_tabmanager_keyboard() {
-  await SpecialPowers.pushPrefEnv({
-    set: [["browser.tabs.tabmanager.enabled", true]],
-  });
-  let newWindow = await BrowserTestUtils.openNewWindowWithFlushedCacheForMozSupports();
-  let elem = newWindow.document.getElementById("alltabs-button");
-
-  // Borrowed from forceFocus() in the keyboard directory head.js
-  elem.setAttribute("tabindex", "-1");
-  elem.focus();
-  elem.removeAttribute("tabindex");
-
-  let focused = BrowserTestUtils.waitForEvent(newWindow, "focus", true);
-  EventUtils.synthesizeKey(" ", {}, newWindow);
-  let event = await focused;
-  ok(
-    event.originalTarget.closest("#allTabsMenu-allTabsView"),
-    "Focus inside all tabs menu after toolbar button pressed"
-  );
-  let hidden = BrowserTestUtils.waitForEvent(
-    event.target.closest("panel"),
-    "popuphidden"
-  );
-  EventUtils.synthesizeKey("KEY_Escape", { shiftKey: false }, newWindow);
-  await hidden;
-  await BrowserTestUtils.closeWindow(newWindow);
-});