Bug 1662795 - Use extension to decide whether to offer view internally. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D90006

toolkit/mozapps/downloads/HelperAppDlg.jsm

@@ -1326,7 +1326,8 @@ nsUnknownContentTypeDialog.prototype = {
         false
       ) &&
       DownloadIntegration.shouldViewDownloadInternally(
-        this.mLauncher.MIMEInfo.MIMEType
+        this.mLauncher.MIMEInfo.MIMEType,
+        primaryExtension
       )
     );
   },

uriloader/exthandler/tests/mochitest/browser.ini

@@ -21,6 +21,8 @@ support-files =
   file_pdf_binary_octet_stream.pdf^headers^
   file_txt_attachment_test.txt
   file_txt_attachment_test.txt^headers^
+  file_xml_attachment_binary_octet_stream.xml
+  file_xml_attachment_binary_octet_stream.xml^headers^
   file_xml_attachment_test.xml
   file_xml_attachment_test.xml^headers^
 [browser_download_urlescape.js]

uriloader/exthandler/tests/mochitest/browser_download_open_with_internal_handler.js

@@ -451,30 +451,39 @@ add_task(async function test_check_open_with_external_then_internal() {
  */
 add_task(
   async function test_internal_handler_hidden_with_viewable_internally_type() {
-    let dialogWindowPromise = BrowserTestUtils.domWindowOpenedAndLoaded();
-    let loadingTab = await BrowserTestUtils.openNewForegroundTab(
-      gBrowser,
-      TEST_PATH + "file_xml_attachment_test.xml"
-    );
-    let dialogWindow = await dialogWindowPromise;
-    is(
-      dialogWindow.location.href,
-      "chrome://mozapps/content/downloads/unknownContentType.xhtml",
-      "Should have seen the unknown content dialogWindow."
-    );
-    let doc = dialogWindow.document;
-    let internalHandlerRadio = doc.querySelector("#handleInternally");
+    for (let [file, checkDefault] of [
+      // The default for binary/octet-stream is changed by the PDF tests above,
+      // this may change given bug 1659008, so I'm just ignoring the default for now.
+      ["file_xml_attachment_binary_octet_stream.xml", false],
+      ["file_xml_attachment_test.xml", true],
+    ]) {
+      let dialogWindowPromise = BrowserTestUtils.domWindowOpenedAndLoaded();
+      let loadingTab = await BrowserTestUtils.openNewForegroundTab(
+        gBrowser,
+        TEST_PATH + file
+      );
+      let dialogWindow = await dialogWindowPromise;
+      is(
+        dialogWindow.location.href,
+        "chrome://mozapps/content/downloads/unknownContentType.xhtml",
+        "Should have seen the unknown content dialogWindow."
+      );
+      let doc = dialogWindow.document;
+      let internalHandlerRadio = doc.querySelector("#handleInternally");
 
-    // Prevent racing with initialization of the dialog and make sure that
-    // the final state of the dialog has the correct visibility of the internal-handler option.
-    await waitForAcceptButtonToGetEnabled(doc);
+      // Prevent racing with initialization of the dialog and make sure that
+      // the final state of the dialog has the correct visibility of the internal-handler option.
+      await waitForAcceptButtonToGetEnabled(doc);
 
-    ok(!internalHandlerRadio.hidden, "The option should be visible for XML");
-    ok(internalHandlerRadio.selected, "The option should be selected");
+      ok(!internalHandlerRadio.hidden, "The option should be visible for XML");
+      if (checkDefault) {
+        ok(internalHandlerRadio.selected, "The option should be selected");
+      }
 
-    let dialog = doc.querySelector("#unknownContentType");
-    dialog.cancelDialog();
-    BrowserTestUtils.removeTab(loadingTab);
+      let dialog = doc.querySelector("#unknownContentType");
+      dialog.cancelDialog();
+      BrowserTestUtils.removeTab(loadingTab);
+    }
   }
 );
 

uriloader/exthandler/tests/mochitest/file_xml_attachment_binary_octet_stream.xml

@@ -0,0 +1,4 @@
+<?xml version = "1.0" encoding = "utf-8"?>
+
+<something>
+</something>

uriloader/exthandler/tests/mochitest/file_xml_attachment_binary_octet_stream.xml^headers^

@@ -0,0 +1,2 @@
+Content-Disposition: attachment
+Content-Type: binary/octet-stream