Bug 1582512 - Disable the javascript filename load restriction on specific tests r=jdescottes

Certain tests load data: URIs, blob: URIs, or otherwise do unusual things
that mean we need to disable the restriction for them.

Differential Revision: https://phabricator.services.mozilla.com/D46501

--HG--
extra : moz-landing-system : lando

devtools/client/shared/sourceeditor/test/browser_codemirror.js

@@ -29,6 +29,8 @@ async function test() {
     "privacy.resistFingerprinting.reduceTimerPrecision.microseconds",
     2000
   );
+  // Needed for a loadFrameScript(data:) call in helper_codemirror_runner.js
+  await pushPref("security.allow_parent_unrestricted_js_loads", true);
 
   const tab = await addTab(URI);
   runCodeMirrorTest(tab.linkedBrowser);

devtools/client/shared/sourceeditor/test/browser_vimemacs.js

@@ -8,11 +8,13 @@ const URI =
   "/shared/sourceeditor/test/codemirror/vimemacs.html";
 loadHelperScript("helper_codemirror_runner.js");
 
-function test() {
+async function test() {
   requestLongerTimeout(4);
   waitForExplicitFinish();
 
-  addTab(URI).then(function(tab) {
-    runCodeMirrorTest(tab.linkedBrowser);
-  });
+  // Needed for a loadFrameScript(data:) call in helper_codemirror_runner.js
+  await pushPref("security.allow_parent_unrestricted_js_loads", true);
+
+  const tab = await addTab(URI);
+  runCodeMirrorTest(tab.linkedBrowser);
 }

devtools/client/webconsole/test/browser/browser_console.js

@@ -21,6 +21,8 @@ const TEST_IMAGE =
   "test/test-image.png";
 
 add_task(async function() {
+  // Needed for the execute() function below
+  await pushPref("security.allow_parent_unrestricted_js_loads", true);
   await pushPref("devtools.browserconsole.contentMessages", true);
   await addTab(TEST_URI);
 

devtools/client/webconsole/test/browser/browser_console_chrome_context_message.js

@@ -7,6 +7,9 @@
 "use strict";
 
 add_task(async function() {
+  // Needed for the execute() function below
+  await pushPref("security.allow_parent_unrestricted_js_loads", true);
+
   // Show the content messages
   await pushPref("devtools.browserconsole.contentMessages", true);
 

devtools/client/webconsole/test/browser/browser_console_cpow.js

@@ -12,6 +12,9 @@ const {
 } = require("devtools/client/framework/devtools-browser");
 
 add_task(async function() {
+  // Needed for the execute() function below
+  await pushPref("security.allow_parent_unrestricted_js_loads", true);
+
   await addTab("about:blank");
 
   const hud = await BrowserConsoleManager.openBrowserConsoleOrFocus();

devtools/client/webconsole/test/browser/browser_console_dead_objects.js

@@ -13,6 +13,9 @@
 "use strict";
 
 add_task(async function() {
+  // Needed for the execute() function below
+  await pushPref("security.allow_parent_unrestricted_js_loads", true);
+
   const hud = await BrowserConsoleManager.toggleBrowserConsole();
   ok(hud, "browser console opened");
 

devtools/client/webconsole/test/browser/browser_console_jsterm_await.js

@@ -10,6 +10,8 @@ const TEST_URI =
   "data:text/html;charset=utf-8,Top-level await Browser Console test";
 
 add_task(async function() {
+  // Needed for the execute() function below
+  await pushPref("security.allow_parent_unrestricted_js_loads", true);
   // Enable await mapping.
   await pushPref("devtools.debugger.features.map-await-expression", true);
 

devtools/client/webconsole/test/browser/browser_jsterm_await_error.js

@@ -9,6 +9,9 @@ const TEST_URI =
   "data:text/html;charset=utf-8,Web Console test failing top-level await";
 
 add_task(async function() {
+  // Needed for the execute() function below
+  await pushPref("security.allow_parent_unrestricted_js_loads", true);
+
   // Enable await mapping.
   await pushPref("devtools.debugger.features.map-await-expression", true);
   const hud = await openNewTabAndConsole(TEST_URI);

devtools/client/webconsole/test/browser/browser_jsterm_hide_when_devtools_chrome_enabled_false.js

@@ -26,6 +26,9 @@ requestLongerTimeout(2);
 add_task(async function() {
   let browserConsole, webConsole, objInspector;
 
+  // Needed for the execute() function below
+  await pushPref("security.allow_parent_unrestricted_js_loads", true);
+
   // We don't use `pushPref()` because we need to revert the same pref later
   // in the test.
   Services.prefs.setBoolPref("devtools.chrome.enabled", true);

devtools/client/webconsole/test/browser/browser_toolbox_console_new_process.js

@@ -26,6 +26,8 @@ Services.scriptloader.loadSubScript(
 
 add_task(async function() {
   await pushPref("devtools.browsertoolbox.fission", true);
+  // Needed for the invokeInTab() function below
+  await pushPref("security.allow_parent_unrestricted_js_loads", true);
 
   await addTab(TEST_URI);
   const ToolboxTask = await initBrowserToolboxTask();

devtools/shared/test-helpers/browser_allocation_tracker.js

@@ -37,7 +37,8 @@ add_task(async function() {
     global,
     undefined,
     "test-file.js",
-    1
+    1,
+    /* enforceFilenameRestrictions */ false
   );
   /* eslint-enable no-undef */
 
@@ -58,7 +59,14 @@ add_task(async function() {
       ` + ${afterCreation - before} -> ${afterCreation})`
   );
 
-  Cu.evalInSandbox("list = null;", global, undefined, "test-file.js", 7);
+  Cu.evalInSandbox(
+    "list = null;",
+    global,
+    undefined,
+    "test-file.js",
+    7,
+    /* enforceFilenameRestrictions */ false
+  );
 
   Cu.forceGC();
   Cu.forceCC();

devtools/shared/worker/tests/browser/browser_worker-01.js

@@ -20,6 +20,10 @@ const WORKER_DATA = (function() {
 const INTERVAL = 100;
 const DURATION = 1000;
 
+registerCleanupFunction(function() {
+  Services.prefs.clearUserPref("security.allow_parent_unrestricted_js_loads");
+});
+
 add_task(async function() {
   // Test both CJS and JSM versions
 
@@ -31,6 +35,11 @@ add_task(async function() {
 });
 
 async function testWorker(context, workerFactory) {
+  // Needed for blob:null
+  Services.prefs.setBoolPref(
+    "security.allow_parent_unrestricted_js_loads",
+    true
+  );
   const { DevToolsWorker, workerify } = workerFactory();
   const worker = new DevToolsWorker(WORKER_URL);
   const results = await worker.performTask("plotTimestampsGraph", {
@@ -52,6 +61,10 @@ async function testWorker(context, workerFactory) {
 }
 
 async function testTransfer() {
+  Services.prefs.setBoolPref(
+    "security.allow_parent_unrestricted_js_loads",
+    true
+  );
   const { workerify } = ChromeUtils.import(
     "resource://devtools/shared/worker/worker.js"
   );

devtools/shared/worker/tests/browser/browser_worker-03.js

@@ -25,7 +25,16 @@ function squarePromiseReject(x) {
   return new Promise((_, reject) => reject("Nope"));
 }
 
+registerCleanupFunction(function() {
+  Services.prefs.clearUserPref("security.allow_parent_unrestricted_js_loads");
+});
+
 add_task(async function() {
+  // Needed for blob:null
+  Services.prefs.setBoolPref(
+    "security.allow_parent_unrestricted_js_loads",
+    true
+  );
   let fn = workerify(square);
   is(await fn(5), 25, "return primitives successful");
   fn.destroy();