Bug 1545768 - Re-enable good text bounds for webrender. r=kats

This just reverts commit 580a7e38c60491123f3e7bba82904008ab0262d1.

Differential Revision: https://phabricator.services.mozilla.com/D30161

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Alexis Beingessner 2019-05-07 11:20:34 +00:00
Родитель 6ca164fa73
Коммит 0feadff33f
4 изменённых файлов: 5 добавлений и 11 удалений

Просмотреть файл

@ -5858,7 +5858,7 @@ void nsTextFrame::PaintOneShadow(const PaintShadowParams& aParams,
// Gecko already inflates the bounding rect of text shadows,
// so tell WR not to inflate again.
wrShadow.should_inflate = false;
wrShadow.should_inflate = true;
wrShadow.offset = {
PresContext()->AppUnitsToFloatDevPixels(aShadowDetails->mXOffset),

Просмотреть файл

@ -8985,16 +8985,10 @@ bool nsDisplayText::CreateWebRenderCommands(
auto* f = static_cast<nsTextFrame*>(mFrame);
auto appUnitsPerDevPixel = f->PresContext()->AppUnitsPerDevPixel();
// FIXME: the webrender backend is having a lot of snapping issues, and
// having it do inflation for us is causing problems. For now, we pass
// down the wrong bounds. Try to turn this back on when things are in
// better shape.
//
// nsRect bounds = f->WebRenderBounds() + ToReferenceFrame();
nsRect bounds = f->WebRenderBounds() + ToReferenceFrame();
// Bug 748228
// bounds.Inflate(appUnitsPerDevPixel);
bounds.Inflate(appUnitsPerDevPixel);
nsRect bounds = mBounds;
if (bounds.IsEmpty()) {
return true;
}

Просмотреть файл

@ -2102,7 +2102,7 @@ pref(layout.css.supports-selector.enabled,true) == 1499386.html 1499386-ref.html
pref(layout.css.supports-selector.enabled,false) != 1499386.html 1499386-ref.html
== 1509425-1.html 1509425-1-ref.html
== 1511570.html 1511570-ref.html
fuzzy-if(!webrender,1-5,66-547) fails-if(webrender) == 1529992-1.html 1529992-1-ref.html
fuzzy-if(!webrender,1-5,66-547) == 1529992-1.html 1529992-1-ref.html
fuzzy-if(!webrender,0-6,0-34) fails-if(webrender) == 1529992-2.html 1529992-2-ref.html
== 1535040-1.html 1535040-1-ref.html
== 1545360-1.xhtml 1545360-1-ref.xhtml

Просмотреть файл

@ -5,7 +5,7 @@ random-if(Android) == basic-negcoord.xul basic-negcoord-ref.xul
!= blur.xul blur-notref.xul
== color-inherit.xul color-inherit-ref.xul
== multiple-noblur.xul multiple-noblur-ref.xul
== blur-opacity.html blur-opacity-ref.html
fuzzy-if(webrender&&gtkWidget,128-128,160-160) == blur-opacity.html blur-opacity-ref.html
== basic.html basic-ref.html
== basic-negcoord.html basic-negcoord-ref.html