Bug 1659452 - Restore basic function names in GDB. r=froydnj

Differential Revision: https://phabricator.services.mozilla.com/D87283

browser/config/mozconfigs/linux32/debug

@@ -11,6 +11,9 @@ export MOZILLA_OFFICIAL=1
 # Package js shell.
 export MOZ_PACKAGE_JSSHELL=1
 
+# Keep basic GDB symbols around in debug builds
+ac_add_options STRIP_FLAGS=--strip-debug
+
 ac_add_options --with-branding=browser/branding/nightly
 
 . "$topsrcdir/build/mozconfig.common.override"

browser/config/mozconfigs/linux32/nightly

@@ -2,4 +2,10 @@
 
 ac_add_options --with-branding=browser/branding/nightly
 
+# STRIP_FLAGS is only valid for builds that strip; valgrind builds disable stripping
+if [ -z "$USE_VALGRIND" ]; then
+  # Keep basic GDB symbols around in Nightly builds
+  ac_add_options STRIP_FLAGS=--strip-debug
+fi
+
 . "$topsrcdir/build/mozconfig.common.override"

browser/config/mozconfigs/linux32/valgrind

@@ -1,3 +1,5 @@
+USE_VALGRIND=1
+
 . $topsrcdir/browser/config/mozconfigs/linux32/nightly
 
 ac_add_options --enable-valgrind

browser/config/mozconfigs/linux64/code-coverage

@@ -1,3 +1,6 @@
+# Avoid setting any incompatible strip flags in the nightly config
+NOSTRIP_BUILD=1
+
 . "$topsrcdir/browser/config/mozconfigs/linux64/nightly"
 
 TOOLTOOL_DIR=${TOOLTOOL_DIR:-$topsrcdir}

browser/config/mozconfigs/linux64/debug

@@ -12,4 +12,7 @@ export MOZ_PACKAGE_JSSHELL=1
 
 ac_add_options --with-branding=browser/branding/nightly
 
+# Keep basic GDB symbols around in debug builds
+ac_add_options STRIP_FLAGS=--strip-debug
+
 . "$topsrcdir/build/mozconfig.common.override"

browser/config/mozconfigs/linux64/nightly

@@ -2,4 +2,11 @@
 
 ac_add_options --with-branding=browser/branding/nightly
 
+# STRIP_FLAGS is only valid for builds that strip;
+# Some builds like valgrind or code coverage disable stripping.
+if [ -z "$NOSTRIP_BUILD" ]; then
+  # Keep basic GDB symbols around in Nightly builds
+  ac_add_options STRIP_FLAGS=--strip-debug
+fi
+
 . "$topsrcdir/build/mozconfig.common.override"

browser/config/mozconfigs/linux64/valgrind

@@ -1,5 +1,8 @@
 MOZ_AUTOMATION_CHECK=0
 
+# Avoid setting any incompatible strip flags in the nightly config
+NOSTRIP_BUILD=1
+
 . $topsrcdir/browser/config/mozconfigs/linux64/nightly
 
 ac_add_options --enable-valgrind