From 10b5ed8b35ae33446ee30622120d375ea3e4945a Mon Sep 17 00:00:00 2001 From: Greg Tatum Date: Tue, 25 Feb 2020 16:47:19 +0000 Subject: [PATCH] Bug 1597378 - Create new UI for the profiler popup; r=julienw This commit implements the actual UI changes. A follow-up commit adds the tests for the changes. The CSS is a little bit awkard since it uses lots of ID selectors rather than class selectors. I wanted to be able to write quick selects, since it's selecting across the entire browser document. I feel a little conflicted with the approach, as I would prefer to use classes in general. The panel.jsm.js file collects all of the UI handling changes rather than having everything in menu-button.jsm.js, as the latter can get loaded at startup. I'm not sure if it's completely worth the trouble of having two files, as most of it should be pretty light. This commit does not handle localization for the panel, as we should be moving to Fluent. Rather than solve that here, I will follow-up with it in Bug 1599774. Differential Revision: https://phabricator.services.mozilla.com/D62914 --HG-- extra : moz-landing-system : lando --- .../customizableui/content/panelUI.inc.xhtml | 82 ++++- .../shared/customizableui/panelUI.inc.css | 281 +++++++++++++- devtools/client/jar.mn | 1 + .../client/performance-new/@types/gecko.d.ts | 35 +- .../client/performance-new/@types/perf.d.ts | 5 + .../performance-new/popup/menu-button.jsm.js | 131 +++---- .../client/performance-new/popup/moz.build | 1 + .../client/performance-new/popup/panel.jsm.js | 342 ++++++++++++++++++ .../images/performance-new-popup-backdrop.png | Bin 0 -> 8455 bytes modules/libpref/init/all.js | 2 + 10 files changed, 804 insertions(+), 76 deletions(-) create mode 100644 devtools/client/performance-new/popup/panel.jsm.js create mode 100644 devtools/client/themes/images/performance-new-popup-backdrop.png diff --git a/browser/components/customizableui/content/panelUI.inc.xhtml b/browser/components/customizableui/content/panelUI.inc.xhtml index 3ce9282f287a..1a1e40af0e37 100644 --- a/browser/components/customizableui/content/panelUI.inc.xhtml +++ b/browser/components/customizableui/content/panelUI.inc.xhtml @@ -644,7 +644,87 @@ - + + + + + + + + + + + + + + + + + + +