From 10d7e8d01bb3cf4aeca470ebec5a89798484b4d2 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Mon, 1 Feb 2021 00:36:18 +0000 Subject: [PATCH] Bug 1456052 - Change overflow-clip-box of textarea to be consistent with text inputs and match other browsers. r=dholbert Differential Revision: https://phabricator.services.mozilla.com/D38794 --- .../textarea/padding-scrollbar-placement-ref.html | 10 +--------- .../textarea/padding-text-overflow-notref.html | 12 ++++++++++++ .../forms/textarea/padding-text-overflow.html | 13 +++++++++++++ layout/reftests/forms/textarea/reftest.list | 1 + layout/style/res/forms.css | 2 +- 5 files changed, 28 insertions(+), 10 deletions(-) create mode 100644 layout/reftests/forms/textarea/padding-text-overflow-notref.html create mode 100644 layout/reftests/forms/textarea/padding-text-overflow.html diff --git a/layout/reftests/forms/textarea/padding-scrollbar-placement-ref.html b/layout/reftests/forms/textarea/padding-scrollbar-placement-ref.html index 30928bbd7de7..40a639eb9416 100644 --- a/layout/reftests/forms/textarea/padding-scrollbar-placement-ref.html +++ b/layout/reftests/forms/textarea/padding-scrollbar-placement-ref.html @@ -28,14 +28,6 @@ height: 300px; background: black; } - #cover2 { /* corresponds to the bottom padding inside the textarea */ - position: absolute; - left: 0px; - bottom: 0px; - width: 100%; - height: 50px; - background: white; - } @@ -44,7 +36,7 @@ for (var i = 0; i < 1000; ++i) { ss.push(i); } - document.write("
" + ss.join(" ") + "
"); + document.write("
" + ss.join(" ") + "
");
diff --git a/layout/reftests/forms/textarea/padding-text-overflow-notref.html b/layout/reftests/forms/textarea/padding-text-overflow-notref.html new file mode 100644 index 000000000000..78edebcad78c --- /dev/null +++ b/layout/reftests/forms/textarea/padding-text-overflow-notref.html @@ -0,0 +1,12 @@ + + + diff --git a/layout/reftests/forms/textarea/padding-text-overflow.html b/layout/reftests/forms/textarea/padding-text-overflow.html new file mode 100644 index 000000000000..92cc4f38ecee --- /dev/null +++ b/layout/reftests/forms/textarea/padding-text-overflow.html @@ -0,0 +1,13 @@ + + + + diff --git a/layout/reftests/forms/textarea/reftest.list b/layout/reftests/forms/textarea/reftest.list index b1ed1e885ea9..42408be991c3 100644 --- a/layout/reftests/forms/textarea/reftest.list +++ b/layout/reftests/forms/textarea/reftest.list @@ -15,3 +15,4 @@ fuzzy-if(skiaContent,0-1,0-1) == rtl.html rtl-dynamic-style.html fuzzy-if(asyncPan&&!layersGPUAccelerated,0-102,0-4168) random-if(/^Windows\x20NT\x206\.1/.test(http.oscpu)) == padding-scrollbar-placement.html padding-scrollbar-placement-ref.html # Bug 1392106 == various-cols.html various-cols-ref.html == appearance-background-change.html appearance-background-change-ref.html +!= padding-text-overflow.html padding-text-overflow-notref.html diff --git a/layout/style/res/forms.css b/layout/style/res/forms.css index 3fb80e66841b..804ad87be6d3 100644 --- a/layout/style/res/forms.css +++ b/layout/style/res/forms.css @@ -123,7 +123,7 @@ textarea { resize: both; white-space: pre-wrap; word-wrap: break-word; - overflow-clip-box: content-box; + overflow-clip-box: padding-box content-box; } /* A few properties that we don't want to inherit by default: */