Bug 1857522 - Don't ignore pseudo-classes in max-nesting-depth limit. r=Gijs

As that allows you to get around the lint with :is() trivially.

Differential Revision: https://phabricator.services.mozilla.com/D190311

.stylelintrc.js

@@ -56,7 +56,7 @@ module.exports = {
     "max-nesting-depth": [
       3,
       {
-        ignore: ["blockless-at-rules", "pseudo-classes"],
+        ignore: ["blockless-at-rules"],
       },
     ],
 

browser/components/newtab/content-src/asrouter/templates/SimpleBelowSearchSnippet/_SimpleBelowSearchSnippet.scss

@@ -1,3 +1,4 @@
+/* stylelint-disable max-nesting-depth */
 
 .below-search-snippet {
   margin: 0 auto 16px;

browser/components/newtab/content-src/asrouter/templates/SubmitFormSnippet/_SubmitFormSnippet.scss

@@ -1,3 +1,5 @@
+/* stylelint-disable max-nesting-depth */
+
 .SubmitFormSnippet {
   flex-direction: column;
   flex: 1 1 100%;

browser/components/pocket/content/panels/js/components/PopularTopics/PopularTopics.scss

@@ -1,3 +1,5 @@
+/* stylelint-disable max-nesting-depth */
+
 .stp_popular_topics {
   padding: 0;
 

browser/themes/shared/tabs.css

@@ -325,11 +325,7 @@
       stroke: transparent;
 
       &:is([pinned], [sharing]):hover {
-        background-color: var(--tab-icon-overlay-stroke, white);
-
-        #TabsToolbar[brighttext] & {
-          background-color: var(--tab-icon-overlay-stroke, black);
-        }
+        background-color: var(--tab-icon-overlay-stroke, light-dark(white, black));
       }
     }