Bug 1482170 - Remove <Add/Remove>BroadcastListenerFor on XULDocument webidl. r=bz

These methods are only ever used in tests and no longer need to be exposed.
In test_bug445177.xul I tried to preserve more of the test, but everything
after the call to addBroadcastListenerFor is dependent on that.

MozReview-Commit-ID: C4vAxNir4O8

devtools/shared/webconsole/test/test_bug819670_getter_throws.html

@@ -50,14 +50,14 @@ function onInspect(aState, aResponse)
   ok(!aResponse.error, "no response error");
 
   let expectedProps = {
-    "addBroadcastListenerFor": { value: { type: "object" } },
+    "constructor": { value: { type: "object" } },
   };
 
   let props = aResponse.ownProperties;
   ok(props, "response properties available");
 
   if (props) {
-    ok(Object.keys(props).length > Object.keys(expectedProps).length,
+    ok(Object.keys(props).length == Object.keys(expectedProps).length,
        "number of enumerable properties");
     checkObject(props, expectedProps);
   }

dom/webidl/XULDocument.webidl

@@ -10,9 +10,4 @@ interface MozObserver;
 [Func="IsChromeOrXBL"]
 interface XULDocument : Document {
 
-  [Throws]
-  void addBroadcastListenerFor(Element broadcaster, Element observer,
-                               DOMString attr);
-  void removeBroadcastListenerFor(Element broadcaster, Element observer,
-                                  DOMString attr);
 };

dom/xul/XULDocument.h

@@ -134,9 +134,6 @@ public:
 
     void TraceProtos(JSTracer* aTrc);
 
-    // WebIDL API
-    void AddBroadcastListenerFor(Element& aBroadcaster, Element& aListener,
-                                 const nsAString& aAttr, ErrorResult& aRv);
     void RemoveBroadcastListenerFor(Element& aBroadcaster, Element& aListener,
                                     const nsAString& aAttr);
 
@@ -173,6 +170,9 @@ protected:
     nsresult
     AddElementToDocumentPost(Element* aElement);
 
+    void AddBroadcastListenerFor(Element& aBroadcaster, Element& aListener,
+                                 const nsAString& aAttr, ErrorResult& aRv);
+
     nsresult
     ExecuteOnBroadcastHandlerFor(Element* aBroadcaster,
                                  Element* aListener,

dom/xul/test/test_bug445177.xul

@@ -55,25 +55,6 @@ https://bugzilla.mozilla.org/show_bug.cgi?id=445177
     b1.parentNode.appendChild(o1);
     isnot(o1.getAttribute("value"), b1.getAttribute("value"), "Wrong value (8)");
 
-    document.addBroadcastListenerFor(b1, o1, "value");
-    is(o1.getAttribute("value"), b1.getAttribute("value"), "Wrong value (9)");
-
-    o1.remove();
-    b1.setAttribute("value", "foobar");
-    is(o1.getAttribute("value"), b1.getAttribute("value"), "Wrong value (10)");
-
-    b1.parentNode.appendChild(o1);
-    is(o1.getAttribute("value"), b1.getAttribute("value"), "Wrong value (11)");
-
-    o1.setAttribute("observes", "b1");
-    is(o1.getAttribute("value"), b1.getAttribute("value"), "Wrong value (12)");
-
-    // When broadcaster isn't in document, changes to its attributes aren't
-    // reflected to listener.
-    b1.remove();
-    b1.setAttribute("value", "foo");
-    isnot(o1.getAttribute("value"), b1.getAttribute("value"), "Wrong value (13)");
-
     SimpleTest.finish();
   }