From 116871312e7b9456bec9d3a007e40629f3156ae8 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Nicol=C3=A1s=20Pe=C3=B1a=20Moreno?= Date: Mon, 22 Jul 2019 11:08:32 +0000 Subject: [PATCH] Bug 1566462 [wpt PR 17852] - Rename render timestamp in ElementTiming and LargestContentfulPaint, a=testonly MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Automatic update from web-platform-tests Rename render timestamp in ElementTiming and LargestContentfulPaint Currently, the rendering timestamp is exposed in startTime. This may not be ideal because analytics providers may be using certain default filters which could sort by startTime, but the timestamp is 0 for cross origin images. Also, 'renderTime' is more indicative of the timestamp being exposed. Bug: 879270, 942033, 965505 Change-Id: Iee283426173facd1e67343fd376e344517540423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703480 Reviewed-by: Yoav Weiss Reviewed-by: Timothy Dresser Commit-Queue: Nicolás Peña Moreno Cr-Commit-Position: refs/heads/master@{#677814} -- wpt-commits: 47df9efd6ad1b9bf18345b3ace6790a5d41f6334 wpt-pr: 17852 --- .../tests/element-timing/cross-origin-element.sub.html | 6 +++--- .../web-platform/tests/element-timing/image-TAO.sub.html | 4 ++-- .../element-timing/resources/element-timing-helpers.js | 7 ++++--- .../largest-contentful-paint/cross-origin-image.sub.html | 7 ++++--- .../tests/largest-contentful-paint/observe-image.html | 5 +++-- .../tests/largest-contentful-paint/observe-text.html | 5 +++-- 6 files changed, 19 insertions(+), 15 deletions(-) diff --git a/testing/web-platform/tests/element-timing/cross-origin-element.sub.html b/testing/web-platform/tests/element-timing/cross-origin-element.sub.html index 40a97056c2bf..eef69a1d423a 100644 --- a/testing/web-platform/tests/element-timing/cross-origin-element.sub.html +++ b/testing/web-platform/tests/element-timing/cross-origin-element.sub.html @@ -1,6 +1,6 @@ -Element Timing: observe cross-origin images but without startTime +Element Timing: observe cross-origin images but without renderTime