Bug 1735024 - [devtools] Fix the leaks from firefox data provider r=ochameau

Fixes the leaks of the cached stacktrace info in stackTraceInfoByActorID.
Prior to this fix, the stacktrace info in the cache is only removed when the stacktrace
details panel is opened, meaning if the details panel is never opened the
info is never cleared and leaks.
This fixes the netmonitor and the webconsole as they both use the data provider

### Leak Info

####  Netmonitor
Before: 151 leaked objects (14611 with missing allocation site) in the parent process
After: -111 leaked objects (14150 with missing allocation site) in the parent process

#### Webconsole
Before: 271 leaked objects (13996 with missing allocation site) in the parent process
After: 1 leaked objects (13810 with missing allocation site) in the parent process

Differential Revision: https://phabricator.services.mozilla.com/D128015

devtools/client/netmonitor/src/connector/firefox-data-provider.js

@@ -76,6 +76,18 @@ class FirefoxDataProvider {
     this.onEventReceived = this.onEventReceived.bind(this);
     this.setEventStreamFlag = this.setEventStreamFlag.bind(this);
   }
+  /*
+   * Cleans up all the internal states, this usually done before navigation
+   * (without the persist flag on), or just before the data provider is
+   * nulled out.
+   */
+
+  destroy() {
+    this.stackTraces.clear();
+    this.pendingRequests.clear();
+    this.lazyRequestData.clear();
+    this.stackTraceRequestInfoByActorID.clear();
+  }
 
   /**
    * Enable/disable firing redux actions (enabled by default).

devtools/client/netmonitor/src/connector/index.js

@@ -171,6 +171,8 @@ class Connector {
     }
 
     this.webConsoleFront = null;
+
+    this.dataProvider.destroy();
     this.dataProvider = null;
   }
 
@@ -296,6 +298,8 @@ class Connector {
       if (!Services.prefs.getBoolPref(DEVTOOLS_ENABLE_PERSISTENT_LOG_PREF)) {
         this.actions.batchReset();
         this.actions.clearRequests();
+        // clean up all the dataProvider internal state
+        this.dataProvider.destroy();
       } else {
         // If the log is persistent, just clear all accumulated timing markers.
         this.actions.clearTimingMarkers();

devtools/client/webconsole/enhancers/message-cache-clearing.js

@@ -18,6 +18,10 @@ function enableMessagesCacheClearing(webConsoleUI) {
 
       if (webConsoleUI && action.type === MESSAGES_CLEAR) {
         webConsoleUI.clearMessagesCache();
+
+        // cleans up all the network data provider internal state
+        webConsoleUI.networkDataProvider?.destroy();
+
         if (webConsoleUI.hud?.toolbox) {
           webConsoleUI.hud.toolbox.setErrorCount(0);
         }

devtools/client/webconsole/webconsole-ui.js

@@ -240,6 +240,9 @@ class WebConsoleUI {
     this.proxy = null;
     this.additionalProxies = null;
 
+    this.networkDataProvider.destroy();
+    this.networkDataProvider = null;
+
     // Nullify `hud` last as it nullify also target which is used on destroy
     this.window = this.hud = this.wrapper = null;
   }