Bug 1190148 - Fix warnings in toolkit/crashreporter/client and mark as FAIL_ON_WARNINGS. r=ted

toolkit/crashreporter/client/crashreporter_gtk_common.cpp

@@ -409,17 +409,15 @@ bool UIMoveFile(const string& file, const string& newfile)
   }
   if (pID == 0) {
     char* const args[4] = {
-      "mv",
+      const_cast<char*>("mv"),
       strdup(file.c_str()),
       strdup(newfile.c_str()),
       0
     };
     if (args[1] && args[2])
       execve("/bin/mv", args, 0);
-    if (args[1])
-      free(args[1]);
-    if (args[2])
-      free(args[2]);
+    free(args[1]);
+    free(args[2]);
     exit(-1);
   }
   int status;

toolkit/crashreporter/client/crashreporter_osx.mm

@@ -279,7 +279,7 @@ static bool RestartApplication()
    modalDelegate:nil didEndSelector:nil contextInfo:nil];
 }
 
-- (IBAction)viewReportOkClicked:(id)sender;
+- (IBAction)viewReportOkClicked:(id)sender
 {
   [mViewReportWindow orderOut:nil];
   [NSApp endSheet:mViewReportWindow];

toolkit/crashreporter/client/moz.build

@@ -73,3 +73,5 @@ RCINCLUDE = 'crashreporter.rc'
 DISABLE_STL_WRAPPING = True
 
 include('/toolkit/crashreporter/crashreporter.mozbuild')
+
+FAIL_ON_WARNINGS = True