Bug 1530441 - Enable eslint locally. r=davidwalsh

Differential Revision: https://phabricator.services.mozilla.com/D21544

--HG--
extra : moz-landing-system : lando

devtools/client/debugger/new/.eslintignore

@@ -0,0 +1,10 @@
+assets/*
+src/test/examples/**
+src/test/integration/**
+src/test/unit-sources/**
+src/**/fixtures/**
+src/test/mochitest/**
+bin/
+packages/**/fixtures/**
+node_modules
+out

devtools/client/debugger/new/.eslintrc

@@ -0,0 +1,449 @@
+{
+  "parser": "babel-eslint",
+  "plugins": [
+    "react",
+    "mozilla",
+    "flowtype",
+    "babel",
+    "prettier",
+    "import",
+    "file-header"
+  ],
+  "globals": {
+    "atob": true,
+    "btoa": true,
+    "Cc": true,
+    "Ci": true,
+    "Components": true,
+    "console": true,
+    "Cr": true,
+    "Cu": true,
+    "devtools": true,
+    "dump": true,
+    "EventEmitter": true,
+    "isWorker": true,
+    "loader": true,
+    "reportError": true,
+    "Services": true,
+    "Task": true,
+    "XPCNativeWrapper": true,
+    "XPCOMUtils": true,
+    "_Iterator": true,
+    "__dirname": true,
+    "process": true,
+    "global": true,
+    "L10N": true
+  },
+  "extends": [
+    "prettier",
+    "prettier/flowtype",
+    "prettier/react",
+    "plugin:jest/recommended"
+  ],
+  "parserOptions": {
+    "ecmaVersion": 2016,
+    "sourceType": "module",
+    "ecmaFeatures": { "jsx": true }
+  },
+  "env": {
+    "es6": true,
+    "browser": true,
+    "commonjs": true,
+    "jest": true
+  },
+  "rules": {
+    // These are the rules that have been configured so far to match the
+    // devtools coding style.
+
+    // Rules from the mozilla plugin
+    "mozilla/mark-test-function-used": 1,
+    "mozilla/no-aArgs": 1,
+    // See bug 1224289.
+    "mozilla/reject-importGlobalProperties": 1,
+    "mozilla/var-only-at-top-level": 1,
+
+    // Rules from the React plugin
+    "react/jsx-uses-react": [2],
+    "react/jsx-uses-vars": [2],
+    "react/no-danger": 1,
+    "react/no-did-mount-set-state": 1,
+    "react/no-did-update-set-state": 1,
+    "react/no-direct-mutation-state": 1,
+    "react/no-unknown-property": 1,
+    "react/prop-types": 1,
+    "react/sort-comp": [
+      1,
+      {
+        order: ["propTypes", "everything-else", "render"]
+      }
+    ],
+
+    // Check for import errors.
+    "import/no-duplicates": "error",
+    "import/named": "error",
+    "import/export": "error",
+
+    // Enforce the spacing around the * in generator functions.
+    "generator-star-spacing": [2, "after"],
+
+    "flowtype/define-flow-type": 1,
+    "flowtype/use-flow-type": 1,
+
+    // Disallow flow control that escapes from "finally".
+    "no-unsafe-finally": "error",
+
+    // Disallow using variables outside the blocks they are defined (especially
+    // since only let and const are used, see "no-var").
+    "block-scoped-var": 2,
+    // Require camel case names
+    "camelcase": 2,
+    // Allow trailing commas for easy list extension.  Having them does not
+    // impair readability, but also not required either.
+    "comma-dangle": 0,
+    // Warn about cyclomatic complexity in functions.
+    "complexity": ["error", { "max": 22 }],
+    // Don't warn for inconsistent naming when capturing this (not so important
+    // with auto-binding fat arrow functions).
+    "consistent-this": 0,
+    // Enforce curly brace conventions for all control statements.
+    "curly": 2,
+    // Don't require a default case in switch statements. Avoid being forced to
+    // add a bogus default when you know all possible cases are handled.
+    "default-case": 0,
+    // Encourage the use of dot notation whenever possible.
+    "dot-notation": 2,
+    // Allow using == instead of ===, in the interest of landing something since
+    // the devtools codebase is split on convention here.
+    "eqeqeq": 0,
+    // Don't require function expressions to have a name.
+    // This makes the code more verbose and hard to read. Our engine already
+    // does a fantastic job assigning a name to the function, which includes
+    // the enclosing function name, and worst case you have a line number that
+    // you can just look up.
+    "func-names": 0,
+    // Allow use of function declarations and expressions.
+    "func-style": 0,
+    // Deprecated, will be removed in 1.0.
+    "generator-star": 0,
+    // Deprecated, will be removed in 1.0.
+    "global-strict": 0,
+    // Only useful in a node environment.
+    "handle-callback-err": 0,
+    // Allow mixed 'LF' and 'CRLF' as linebreaks.
+    "linebreak-style": 0,
+    // Don't enforce the maximum depth that blocks can be nested. The complexity
+    // rule is a better rule to check this.
+    "max-depth": 0,
+    // Maximum length of a line.
+    "max-len": [
+      2,
+      80,
+      2,
+      {
+        "ignoreUrls": true,
+        "ignorePattern": "\\s*require\\s*\\(|^\\s*loader\\.lazy|-\\*-"
+      }
+    ],
+    // Maximum depth callbacks can be nested.
+    "max-nested-callbacks": [2, 4],
+    // Don't limit the number of parameters that can be used in a function.
+    "max-params": 0,
+    // Don't limit the maximum number of statement allowed in a function. We
+    // already have the complexity rule that's a better measurement.
+    "max-statements": 0,
+    // Require a capital letter for constructors, only check if all new
+    // operators are followed by a capital letter. Don't warn when capitalized
+    // functions are used without the new operator.
+    "new-cap": [2, { "capIsNew": false }],
+    // Disallow use of the Array constructor.
+    "no-array-constructor": 2,
+    // Allow use of bitwise operators.
+    "no-bitwise": 0,
+    // Disallow use of arguments.caller or arguments.callee.
+    "no-caller": 2,
+    // Disallow the catch clause parameter name being the same as a variable in
+    // the outer scope, to avoid confusion.
+    "no-catch-shadow": 2,
+    // Deprecated, will be removed in 1.0.
+    "no-comma-dangle": 0,
+    // Disallow assignment in conditional expressions.
+    "no-cond-assign": 2,
+    // Allow using the console API.
+    "no-console": 0,
+    // Allow using constant expressions in conditions like while (true)
+    "no-constant-condition": 0,
+    // Allow use of the continue statement.
+    "no-continue": 0,
+    // Disallow control characters in regular expressions.
+    "no-control-regex": 2,
+    // Disallow use of debugger.
+    "no-debugger": 2,
+    // Disallow deletion of variables (deleting properties is fine).
+    "no-delete-var": 2,
+    // Allow division operators explicitly at beginning of regular expression.
+    "no-div-regex": 0,
+    // Disallow duplicate arguments in functions.
+    "no-dupe-args": 2,
+    // Disallow duplicate keys when creating object literals.
+    "no-dupe-keys": 2,
+    // Disallow a duplicate case label.
+    "no-duplicate-case": 2,
+    // Disallow else after a return in an if. The else around the second return
+    // here is useless:
+    // if (something) { return false; } else { return true; }
+    "no-else-return": 2,
+    // Disallow empty statements. This will report an error for:
+    // try { something(); } catch (e) {}
+    // but will not report it for:
+    // try { something(); } catch (e) { /* Silencing the error because ...*/ }
+    // which is a valid use case.
+    "no-empty": 2,
+    // Disallow the use of empty character classes in regular expressions.
+    "no-empty-character-class": 2,
+    // Disallow use of labels for anything other then loops and switches.
+    "no-labels": 2,
+    // Disallow use of eval(). We have other APIs to evaluate code in content.
+    "no-eval": 2,
+    // Disallow assigning to the exception in a catch block.
+    "no-ex-assign": 2,
+    // Disallow adding to native types
+    "no-extend-native": 2,
+    // Disallow unnecessary function binding.
+    "no-extra-bind": 2,
+    // Disallow double-negation boolean casts in a boolean context.
+    "no-extra-boolean-cast": 2,
+    // Allow unnecessary parentheses, as they may make the code more readable.
+    "no-extra-parens": 0,
+    // Deprecated, will be removed in 1.0.
+    "no-extra-strict": 0,
+    // Disallow fallthrough of case statements, except if there is a comment.
+    "no-fallthrough": 2,
+    // Allow the use of leading or trailing decimal points in numeric literals.
+    "no-floating-decimal": 0,
+    // Disallow comments inline after code.
+    "no-inline-comments": 2,
+    // Disallow if as the only statement in an else block.
+    "no-lonely-if": 2,
+    // Allow mixing regular variable and require declarations (not a node env).
+    "no-mixed-requires": 0,
+    // Disallow use of multiline strings (use template strings instead).
+    "no-multi-str": 2,
+    "prefer-template": "error",
+    "prefer-const": [
+      "error",
+      {
+        "destructuring": "all",
+        "ignoreReadBeforeAssign": false
+      }
+    ],
+    // Disallow reassignments of native objects.
+    "no-native-reassign": 2,
+    // Disallow nested ternary expressions, they make the code hard to read.
+    "no-nested-ternary": 2,
+    // Allow use of new operator with the require function.
+    "no-new-require": 0,
+    // Disallow use of octal literals.
+    "no-octal": 2,
+    // Allow reassignment of function parameters.
+    "no-param-reassign": 0,
+    // Allow string concatenation with __dirname and __filename (not a node env).
+    "no-path-concat": 0,
+    // Allow use of unary operators, ++ and --.
+    "no-plusplus": 0,
+    // Allow using process.env (not a node environment).
+    "no-process-env": 0,
+    // Allow using process.exit (not a node environment).
+    "no-process-exit": 0,
+    // Disallow usage of __proto__ property.
+    "no-proto": 2,
+    // Disallow declaring the same variable more than once (we use let anyway).
+    "no-redeclare": 2,
+    // Disallow multiple spaces in a regular expression literal.
+    "no-regex-spaces": 2,
+    // Allow reserved words being used as object literal keys.
+    "no-reserved-keys": 0,
+    // Don't restrict usage of specified node modules (not a node environment).
+    "no-restricted-modules": 0,
+    // Disallow use of assignment in return statement. It is preferable for a
+    // single line of code to have only one easily predictable effect.
+    "no-return-assign": 2,
+    // Allow use of javascript: urls.
+    "no-script-url": 0,
+    // Disallow comparisons where both sides are exactly the same.
+    "no-self-compare": 2,
+    // Disallow use of comma operator.
+    "no-sequences": 2,
+    // Warn about declaration of variables already declared in the outer scope.
+    // This isn't an error because it sometimes is useful to use the same name
+    // in a small helper function rather than having to come up with another
+    // random name.
+    // Still, making this a warning can help people avoid being confused.
+    "no-shadow": 2,
+    // Disallow shadowing of names such as arguments.
+    "no-shadow-restricted-names": 2,
+    // Deprecated, will be removed in 1.0.
+    "no-space-before-semi": 0,
+    // Disallow sparse arrays, eg. let arr = [,,2].
+    // Array destructuring is fine though:
+    // for (let [, breakpointPromise] of aPromises)
+    "no-sparse-arrays": 2,
+    // Allow use of synchronous methods (not a node environment).
+    "no-sync": 0,
+    // Allow the use of ternary operators.
+    "no-ternary": 0,
+    // Disallow throwing literals (eg. throw "error" instead of
+    // throw new Error("error")).
+    "no-throw-literal": 2,
+    // Disallow use of undeclared variables unless mentioned in a /*global */
+    // block. Note that globals from head.js are automatically imported in tests
+    // by the import-headjs-globals rule form the mozilla eslint plugin.
+    "no-undef": 2,
+    // Allow dangling underscores in identifiers (for privates).
+    "no-underscore-dangle": 0,
+    // Allow use of undefined variable.
+    "no-undefined": 0,
+    // Disallow the use of Boolean literals in conditional expressions.
+    "no-unneeded-ternary": 2,
+    // Disallow unreachable statements after a return, throw, continue, or break
+    // statement.
+    "no-unreachable": 2,
+    // Disallow global and local variables that arent used, but allow unused function arguments.
+    "no-unused-vars": [2, { "vars": "all", "args": "none" }],
+    // Allow using variables before they are defined.
+    "no-use-before-define": 0,
+    // We use var-only-at-top-level instead of no-var as we allow top level
+    // vars.
+    "no-var": 0,
+    // Allow using TODO/FIXME comments.
+    "no-warning-comments": 0,
+    // Disallow use of the with statement.
+    "no-with": 2,
+    // Dont require method and property shorthand syntax for object literals.
+    // We use this in the code a lot, but not consistently, and this seems more
+    // like something to check at code review time.
+    "object-shorthand": 0,
+    // Allow more than one variable declaration per function.
+    "one-var": 0,
+    // Disallow padding within blocks.
+    //"padded-blocks": [2, "never"],
+    // Dont require quotes around object literal property names.
+    "quote-props": 0,
+    // Double quotes should be used.
+    "quotes": [2, "double", "avoid-escape"],
+    // Require use of the second argument for parseInt().
+    "radix": 2,
+    // Dont require to sort variables within the same declaration block.
+    // Anyway, one-var is disabled.
+    "sort-vars": 0,
+    // Deprecated, will be removed in 1.0.
+    "space-after-function-name": 0,
+    // Deprecated, will be removed in 1.0.
+    "space-before-function-parentheses": 0,
+    // Disallow space before function opening parenthesis.
+    //"space-before-function-paren": [2, "never"],
+    // Disable the rule that checks if spaces inside {} and [] are there or not.
+    // Our code is split on conventions, and itd be nice to have 2 rules
+    // instead, one for [] and one for {}. So, disabling until we write them.
+    "space-in-brackets": 0,
+    // Deprecated, will be removed in 1.0.
+    "space-unary-word-ops": 0,
+    // Require a space immediately following the // in a line comment.
+    "spaced-comment": [2, "always"],
+    // Require "use strict" to be defined globally in the script.
+    "strict": [2, "global"],
+    // Disallow comparisons with the value NaN.
+    "use-isnan": 2,
+    // Warn about invalid JSDoc comments.
+    // Disabled for now because of https://github.com/eslint/eslint/issues/2270
+    // The rule fails on some jsdoc comments like in:
+    // devtools/client/webconsole/console-output.js
+    "valid-jsdoc": 0,
+    // Ensure that the results of typeof are compared against a valid string.
+    "valid-typeof": 2,
+    // Allow vars to be declared anywhere in the scope.
+    "vars-on-top": 0,
+    // Dont require immediate function invocation to be wrapped in parentheses.
+    "wrap-iife": 0,
+    // Don't require regex literals to be wrapped in parentheses (which
+    // supposedly prevent them from being mistaken for division operators).
+    "wrap-regex": 0,
+    // Disallow Yoda conditions (where literal value comes first).
+    "yoda": 2,
+
+    // And these are the rules that haven't been discussed so far, and that are
+    // disabled for now until we introduce them, one at a time.
+
+    // Require for-in loops to have an if statement.
+    "guard-for-in": 0,
+    // allow/disallow an empty newline after var statement
+    "newline-after-var": 0,
+    // disallow the use of alert, confirm, and prompt
+    "no-alert": 0,
+    // disallow comparisons to null without a type-checking operator
+    "no-eq-null": 0,
+    // disallow overwriting functions written as function declarations
+    "no-func-assign": 0,
+    // disallow use of eval()-like methods
+    "no-implied-eval": 0,
+    // disallow function or variable declarations in nested blocks
+    "no-inner-declarations": 0,
+    // disallow invalid regular expression strings in the RegExp constructor
+    "no-invalid-regexp": 0,
+    // disallow irregular whitespace outside of strings and comments
+    "no-irregular-whitespace": 0,
+    // disallow usage of __iterator__ property
+    "no-iterator": 0,
+    // disallow labels that share a name with a variable
+    "no-label-var": 0,
+    // disallow unnecessary nested blocks
+    "no-lone-blocks": 0,
+    // disallow creation of functions within loops
+    "no-loop-func": 0,
+    // disallow negation of the left operand of an in expression
+    "no-negated-in-lhs": 0,
+    // disallow use of new operator when not part of the assignment or
+    // comparison
+    "no-new": 0,
+    // disallow use of new operator for Function object
+    "no-new-func": 0,
+    // disallow use of the Object constructor
+    "no-new-object": 0,
+    // disallows creating new instances of String,Number, and Boolean
+    "no-new-wrappers": 0,
+    // disallow the use of object properties of the global object (Math and
+    // JSON) as functions
+    "no-obj-calls": 0,
+    // disallow use of octal escape sequences in string literals, such as
+    // var foo = "Copyright \251";
+    "no-octal-escape": 0,
+    // disallow use of undefined when initializing variables
+    "no-undef-init": 0,
+    // disallow usage of expressions in statement position
+    "no-unused-expressions": 0,
+    // disallow use of void operator
+    "no-void": 0,
+    // disallow wrapping of non-IIFE statements in parens
+    "no-wrap-func": 0,
+    // require assignment operator shorthand where possible or prohibit it
+    // entirely
+    "operator-assignment": 0,
+    // enforce operators to be placed before or after line breaks
+    "operator-linebreak": 0,
+
+    // Rules from the prettier plugin
+    "prettier/prettier": "error",
+
+    "file-header/file-header": [
+      "error",
+      [
+        "This Source Code Form is subject to the terms of the Mozilla Public",
+        "License, v. 2.0. If a copy of the MPL was not distributed with this",
+        "file, You can obtain one at <http://mozilla.org/MPL/2.0/>."
+      ],
+      "block",
+      ["-\\*-(.*)-\\*-", "eslint(.*)", "vim(.*)"]
+    ],
+    "consistent-return": "off",
+
+  }
+}

devtools/client/debugger/new/.eslintrc.jsx-a11y

@@ -0,0 +1,75 @@
+{
+  "plugins": [
+    "jsx-a11y" // require("eslint-plugin-jsx-a11y")
+  ],
+  "extends": [
+    "plugin:jsx-a11y/recommended", // require("eslint-plugin-jsx-a11y")
+  ],
+  "rules": {
+    // TODO: these rules should eventually be removed in favour of the
+    // plugin:jsx-a11y/recommended set (which they override) that has different severity
+    // levels.
+    "jsx-a11y/accessible-emoji": "warn",
+    "jsx-a11y/alt-text": "error",
+    "jsx-a11y/anchor-has-content": "warn",
+    "jsx-a11y/anchor-is-valid": "error",
+    "jsx-a11y/aria-activedescendant-has-tabindex": "warn",
+    "jsx-a11y/aria-props": "warn",
+    "jsx-a11y/aria-proptypes": "warn",
+    "jsx-a11y/aria-role": "warn",
+    "jsx-a11y/aria-unsupported-elements": "warn",
+    "jsx-a11y/click-events-have-key-events": "warn",
+    "jsx-a11y/heading-has-content": "warn",
+    "jsx-a11y/html-has-lang": "warn",
+    "jsx-a11y/iframe-has-title": "warn",
+    "jsx-a11y/img-redundant-alt": "warn",
+    "jsx-a11y/interactive-supports-focus": ["warn", {
+      "tabbable": ["button", "checkbox", "link", "searchbox", "spinbutton", "switch", "textbox"]
+    }],
+    "jsx-a11y/label-has-for": ["error", {
+      "required": {
+        "some": [ "nesting", "id" ]
+      }
+    }],
+    "jsx-a11y/label-has-associated-control": ["error", {
+      "required": {
+        "some": [ "nesting", "id" ]
+      }
+    }],
+    "jsx-a11y/media-has-caption": "warn",
+    "jsx-a11y/mouse-events-have-key-events": "warn",
+    "jsx-a11y/no-access-key": "warn",
+    "jsx-a11y/no-autofocus": "error",
+    "jsx-a11y/no-distracting-elements": "warn",
+
+    "jsx-a11y/no-interactive-element-to-noninteractive-role": ["warn", {
+      "tr": ["none", "presentation"]
+    }],
+    "jsx-a11y/no-noninteractive-element-interactions": ["warn", {
+      "handlers": ["onClick", "onError", "onLoad", "onMouseDown", "onMouseUp", "onKeyPress", "onKeyDown", "onKeyUp"],
+      "body": ["onError", "onLoad"],
+      "iframe": ["onError", "onLoad"],
+      "img": ["onError", "onLoad"]
+    }],
+    "jsx-a11y/no-noninteractive-element-to-interactive-role": ["warn", {
+      "ul": ["listbox", "menu", "menubar", "radiogroup", "tablist", "tree", "treegrid"],
+      "ol": ["listbox", "menu", "menubar", "radiogroup", "tablist", "tree", "treegrid"],
+      "li": ["menuitem", "option", "row", "tab", "treeitem"],
+      "table": ["grid"],
+      "td": ["gridcell"]
+    }],
+    "jsx-a11y/no-noninteractive-tabindex": ["warn", {
+      "tags": [],
+      "roles": ["tabpanel"]
+    }],
+    "jsx-a11y/no-onchange": "warn",
+    "jsx-a11y/no-redundant-roles": "error",
+    "jsx-a11y/no-static-element-interactions": ["warn", {
+      "handlers": ["onClick", "onMouseDown", "onMouseUp", "onKeyPress", "onKeyDown", "onKeyUp"]
+    }],
+    "jsx-a11y/role-has-required-aria-props": "warn",
+    "jsx-a11y/role-supports-aria-props": "warn",
+    "jsx-a11y/scope": "warn",
+    "jsx-a11y/tabindex-no-positive": "warn"
+  }
+}

devtools/client/debugger/new/.prettierignore

@@ -0,0 +1,8 @@
+src/workers/parser/tests/fixtures/functionNames.js
+src/workers/parser/tests/fixtures/scopes/*.js
+src/workers/parser/tests/fixtures/pause/*.js
+src/test/mochitest/examples/babel/polyfill-bundle.js
+src/test/mochitest/examples/babel/fixtures/*/input.js
+src/test/mochitest/examples/babel/fixtures/*/output.js
+src/test/mochitest/examples/babel/fixtures/*/output.js.map
+src/test/mochitest/examples/ember/quickstart

devtools/client/debugger/new/.remarkignore

@@ -0,0 +1,2 @@
+src/utils/pause/mapScopes/README.md
+src/test/mochitest/examples/sourcemapped/README.md

devtools/client/debugger/new/.remarkrc

@@ -0,0 +1,17 @@
+{
+  "plugins": [
+    "preset-lint-recommended",
+    ["lint-list-item-bullet-indent", false],
+    ["lint-list-item-indent", false],
+    ["lint-ordered-list-marker-style", false],
+    ["lint-no-unused-definitions", false],
+    ["lint-no-shortcut-reference-link", false],
+    ["lint-no-shortcut-reference-image", false],
+    ["lint-no-table-indentation", true],
+    ["lint-table-cell-padding", "consistent"],
+    ["lint-table-pipes", false],
+    ["validate-links", {
+      "repository": ""
+    }]
+  ]
+}

devtools/client/debugger/new/.stylelintignore

@@ -0,0 +1,3 @@
+src/components/Editor/codemirror-mozilla.css
+src/components/shared/SplitBox.css
+src/components/shared/reps.css

devtools/client/debugger/new/.stylelintrc

@@ -0,0 +1,55 @@
+{
+  "rules": {
+    "at-rule-semicolon-newline-after": "always",
+    "block-closing-brace-newline-after": "always",
+    "block-closing-brace-newline-before": "always-multi-line",
+    "block-closing-brace-space-before": "always-single-line",
+    "block-no-empty": true,
+    "block-opening-brace-newline-after": "always-multi-line",
+    "block-opening-brace-space-after": "always-single-line",
+    "block-opening-brace-space-before": "always",
+    "color-hex-case": "lower",
+    "color-hex-length": "long",
+    "color-no-invalid-hex": true,
+    "declaration-bang-space-after": "never",
+    "declaration-bang-space-before": "always",
+    "declaration-block-no-shorthand-property-overrides": true,
+    "declaration-block-semicolon-newline-after": "always-multi-line",
+    "declaration-block-semicolon-space-after": "always-single-line",
+    "declaration-block-semicolon-space-before": "never",
+    "declaration-block-single-line-max-declarations": 1,
+    "declaration-block-trailing-semicolon": "always",
+    "declaration-colon-space-after": "always-single-line",
+    "declaration-colon-space-before": "never",
+    "function-calc-no-unspaced-operator": true,
+    "function-comma-newline-after": "always-multi-line",
+    "function-comma-space-after": "always-single-line",
+    "function-comma-space-before": "never",
+    "function-linear-gradient-no-nonstandard-direction": true,
+    "function-parentheses-newline-inside": "always-multi-line",
+    "function-parentheses-space-inside": "never-single-line",
+    "function-whitespace-after": "always",
+    "max-empty-lines": 1,
+    "media-feature-colon-space-after": "always",
+    "media-feature-colon-space-before": "never",
+    "media-feature-range-operator-space-after": "always",
+    "media-feature-range-operator-space-before": "always",
+    "media-query-list-comma-newline-after": "always-multi-line",
+    "media-query-list-comma-space-after": "always-single-line",
+    "media-query-list-comma-space-before": "never",
+    "media-feature-parentheses-space-inside": "never",
+    "no-eol-whitespace": true,
+    "no-invalid-double-slash-comments": true,
+    "no-missing-end-of-source-newline": true,
+    "number-leading-zero": "always",
+    "number-no-trailing-zeros": true,
+    "selector-combinator-space-after": "always",
+    "selector-list-comma-space-before": "never",
+    "selector-pseudo-element-colon-notation": "double",
+    "selector-type-case": "lower",
+    "string-no-newline": true,
+    "value-list-comma-newline-after": "always-multi-line",
+    "value-list-comma-space-after": "always-single-line",
+    "value-list-comma-space-before": "never",
+  },
+}

devtools/client/debugger/new/assets/dictionary.txt

@@ -207,4 +207,10 @@ eval
 asyncStore
 CPG
 TodoMVC
-pseudocode
+pseudocode
+Amit
+Zur's
+TravisCI
+Homebrew
+30-60minutes
+myScriptFunction

devtools/client/debugger/new/package.json

@@ -1,15 +1,15 @@
 {
-  "name": "debugger.html",
+  "name": "debugger",
   "version": "0.6.0",
   "license": "MPL-2.0",
   "repository": {
-    "url": "git://github.com/firefox-devtools/debugger.html.git",
+    "url": "git://github.com/firefox-devtools/debugger.git",
     "type": "git"
   },
   "bugs": {
-    "url": "https://github.com/firefox-devtools/debugger.html/issues"
+    "url": "https://github.com/firefox-devtools/debugger/issues"
   },
-  "homepage": "https://github.com/firefox-devtools/debugger.html#readme",
+  "homepage": "https://github.com/firefox-devtools/debugger#readme",
   "engineStrict": true,
   "scripts": {
     "start": "node bin/dev-server",
@@ -23,7 +23,7 @@
     "lint:css": "stylelint \"src/components/**/*.css\"",
     "lint:js": "eslint *.js \"src/**/*.js\" \"packages/*/src/**/*.js\" --fix",
     "lint:jsx-a11y": "eslint *.js \"src/**/*.js\" \"packages/*/src/**/*.js\" --plugin=jsx-a11y --config=.eslintrc.jsx-a11y",
-    "lint:md": "remark -u devtools-linters/markdown/preset -qf *.md src configs docs",
+    "lint:md": "remark -u devtools-linters/markdown/preset -qf *.md src",
     "mochi": "mochii --mc ./firefox --interactive --default-test-path devtools/client/debugger/new",
     "mochid": "yarn mochi -- --jsdebugger --",
     "mochir": "yarn mochi -- --repeat 10 --",

devtools/client/debugger/new/packages/devtools-components/src/tree.js

@@ -829,7 +829,6 @@ class Tree extends Component {
         if (this.treeRef.current !== document.activeElement) {
           this.treeRef.current.focus();
         }
-        return;
     }
   }
 

devtools/client/debugger/new/packages/devtools-reps/src/launchpad/components/Result.js

@@ -32,6 +32,7 @@ class Result extends Component {
     e.stopPropagation();
 
     const textField = document.createElement("textarea");
+    // eslint-disable-next-line no-unsanitized/property
     textField.innerHTML = JSON.stringify(packet, null, "  ");
     document.body.appendChild(textField);
     textField.select();

devtools/client/debugger/new/packages/devtools-reps/src/object-inspector/components/ObjectInspector.js

@@ -98,7 +98,6 @@ class ObjectInspector extends Component<Props> {
       if (this.props.rootsChanged) {
         this.props.rootsChanged();
       }
-      return;
     }
   }
 

devtools/client/debugger/new/packages/devtools-source-map/src/tests/helpers.js

@@ -35,7 +35,7 @@ async function setupBundleFixture(name) {
     return { content };
   });
 
-  return await getOriginalURLs(source);
+  return getOriginalURLs(source);
 }
 
 module.exports = {

devtools/client/debugger/new/panel.js

@@ -2,14 +2,10 @@
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at <http://mozilla.org/MPL/2.0/>. */
 
-const { Task } = require("devtools/shared/task");
 const { LocalizationHelper } = require("devtools/shared/l10n");
-const { gDevTools } = require("devtools/client/framework/devtools");
 const {
   gDevToolsBrowser
 } = require("devtools/client/framework/devtools-browser");
-const { TargetFactory } = require("devtools/client/framework/target");
-const { Toolbox } = require("devtools/client/framework/toolbox");
 loader.lazyRequireGetter(
   this,
   "openContentLink",

devtools/client/debugger/new/src/actions/pause/commands.js

@@ -22,7 +22,7 @@ import type { ThunkArgs } from "../types";
 import type { Command } from "../../reducers/types";
 
 export function selectThread(thread: string) {
-  return { type: "SELECT_THREAD", thread }
+  return { type: "SELECT_THREAD", thread };
 }
 
 /**

devtools/client/debugger/new/src/actions/sources/newSources.js

@@ -219,18 +219,17 @@ export function newSource(source: Source) {
 
 export function newSources(sources: Source[]) {
   return async ({ dispatch, getState }: ThunkArgs) => {
-
-    const newSources = sources.filter(
+    const _newSources = sources.filter(
       source => !getSource(getState(), source.id)
     );
 
     dispatch({ type: "ADD_SOURCES", sources });
 
-    for (const source of newSources) {
+    for (const source of _newSources) {
       dispatch(checkSelectedSource(source.id));
     }
 
-    dispatch(restoreBlackBoxedSources(newSources));
-    dispatch(loadSourceMaps(newSources));
+    dispatch(restoreBlackBoxedSources(_newSources));
+    dispatch(loadSourceMaps(_newSources));
   };
 }

devtools/client/debugger/new/src/actions/sources/select.js

@@ -87,11 +87,13 @@ export function selectSourceURL(
  * @memberof actions/sources
  * @static
  */
-export function selectSource(sourceId: string,
-                             options: PartialPosition = { line: 1 }) {
+export function selectSource(
+  sourceId: string,
+  options: PartialPosition = { line: 1 }
+) {
   return async ({ dispatch }: ThunkArgs) => {
     const location = createLocation({ ...options, sourceId });
-    return await dispatch(selectSpecificLocation(location));
+    return dispatch(selectSpecificLocation(location));
   };
 }
 

devtools/client/debugger/new/src/components/App.js

@@ -191,7 +191,6 @@ class App extends Component<Props, State> {
       return;
     }
     openQuickOpen();
-    return;
   };
 
   onLayoutChange = () => {

devtools/client/debugger/new/src/main.development.js

@@ -6,17 +6,7 @@
 
 import React from "react";
 import ReactDOM from "react-dom";
-
-import { isFirefoxPanel } from "devtools-environment";
-
 import { onConnect } from "./client";
-import { teardownWorkers } from "./utils/bootstrap";
-import sourceQueue from "./utils/source-queue";
-
-function unmountRoot() {
-  const mount = document.querySelector("#mount .launchpad-root");
-  ReactDOM.unmountComponentAtNode(mount);
-}
 
 const { bootstrap, L10N } = require("devtools-launchpad");
 
@@ -25,16 +15,15 @@ window.L10N = L10N;
 window.L10N.setBundle(require("../../../locales/en-us/debugger.properties"));
 
 bootstrap(React, ReactDOM).then(connection => {
-onConnect(connection, require("devtools-source-map"), {
-  emit: eventName => console.log(`emitted: ${eventName}`),
-  openLink: url => {
-    const win = window.open(url, "_blank");
-    win.focus();
-  },
-  openWorkerToolbox: worker => alert(worker.url),
-  openElementInInspector: grip =>
-    alert(`Opening node in Inspector: ${grip.class}`),
-  openConsoleAndEvaluate: input => alert(`console.log: ${input}`)
+  onConnect(connection, require("devtools-source-map"), {
+    emit: eventName => console.log(`emitted: ${eventName}`),
+    openLink: url => {
+      const win = window.open(url, "_blank");
+      win.focus();
+    },
+    openWorkerToolbox: worker => alert(worker.url),
+    openElementInInspector: grip =>
+      alert(`Opening node in Inspector: ${grip.class}`),
+    openConsoleAndEvaluate: input => alert(`console.log: ${input}`)
+  });
 });
-});
-

devtools/client/debugger/new/src/main.js

@@ -4,9 +4,7 @@
 
 // @flow
 
-import React from "react";
 import ReactDOM from "react-dom";
-
 import { onConnect } from "./client";
 import { teardownWorkers } from "./utils/bootstrap";
 import sourceQueue from "./utils/source-queue";
@@ -23,19 +21,19 @@ module.exports = {
     debuggerClient,
     sourceMaps,
     panel
-  }: any) => 
-  onConnect(
-    {
-      tab: { clientType: "firefox" },
-      tabConnection: {
-        tabTarget,
-        threadClient,
-        debuggerClient
-      }
-    },
-    sourceMaps,
-    panel
-  ),
+  }: any) =>
+    onConnect(
+      {
+        tab: { clientType: "firefox" },
+        tabConnection: {
+          tabTarget,
+          threadClient,
+          debuggerClient
+        }
+      },
+      sourceMaps,
+      panel
+    ),
   destroy: () => {
     unmountRoot();
     sourceQueue.clear();

devtools/client/debugger/new/src/reducers/sources.js

@@ -22,13 +22,7 @@ import {
 import { originalToGeneratedId } from "devtools-source-map";
 import { prefs } from "../utils/prefs";
 
-import type {
-  Source,
-  SourceId,
-  SourceLocation,
-  ThreadId,
-  WorkerList
-} from "../types";
+import type { Source, SourceId, SourceLocation, ThreadId } from "../types";
 import type { PendingSelectedLocation, Selector } from "./types";
 import type { Action, DonePromiseAction, FocusItem } from "../actions/types";
 import type { LoadSourceAction } from "../actions/types/SourceAction";

devtools/client/debugger/new/src/reducers/tests/sources.spec.js

@@ -8,21 +8,16 @@ declare var it: (desc: string, func: () => void) => void;
 declare var expect: (value: any) => any;
 
 import update, { initialSourcesState, getDisplayedSources } from "../sources";
-import { foobar } from "../../test/fixtures";
 import type { Source } from "../../types";
 import { prefs } from "../../utils/prefs";
 import { makeMockSource } from "../../utils/test-mockup";
 
-
-
-const fakeSources = foobar.sources.sources;
-
 const extensionSource = {
   ...makeMockSource(),
   id: "extensionId",
   url: "http://example.com/script.js",
   actors: [{ actor: "extensionId-actor", source: "extensionId", thread: "foo" }]
-}
+};
 
 const firefoxExtensionSource = {
   ...makeMockSource(),

devtools/client/debugger/new/src/selectors/getCallStackFrames.js

@@ -63,6 +63,7 @@ export function formatCallStackFrames(
   return annotateFrames(formattedFrames);
 }
 
+// eslint-disable-next-line
 export const getCallStackFrames: State => Frame[] = (createSelector: any)(
   getFrames,
   getSources,

devtools/client/debugger/new/src/utils/build-query.js

@@ -42,8 +42,6 @@ function buildFlags(caseSensitive: boolean, isGlobal: boolean): ?RegExp$flags {
   if (!caseSensitive && !isGlobal) {
     return "i";
   }
-
-  return;
 }
 
 export default function buildQuery(

devtools/client/debugger/new/src/utils/path.js

@@ -14,7 +14,7 @@ export function dirname(path: string) {
 }
 
 export function isURL(str: string) {
-  return str.indexOf("://") !== -1;
+  return str.includes("://");
 }
 
 export function isAbsolute(str: string) {

devtools/client/debugger/new/src/utils/sources-tree/utils.js

@@ -64,7 +64,7 @@ export function isNotJavaScript(source: Source): boolean {
 
 export function isInvalidUrl(url: Object, source: Source) {
   return (
-    IGNORED_URLS.indexOf(url) != -1 ||
+    IGNORED_URLS.includes(url) ||
     !source.url ||
     !url.group ||
     isPretty(source) ||

devtools/client/debugger/new/src/utils/tests/telemetry.spec.js

@@ -27,6 +27,7 @@ describe("telemetry.recordEvent()", () => {
       "debugger",
       null,
       {
+        // eslint-disable-next-line camelcase
         session_id: -1,
         bar: 1
       }

devtools/client/debugger/new/src/workers/pretty-print/index.js

@@ -26,7 +26,7 @@ export async function prettyPrint({ source, url }: PrettyPrintOpts) {
 
   assert(isJavaScript(source), "Can't prettify non-javascript files.");
 
-  return await _prettyPrint({
+  return _prettyPrint({
     url,
     indent,
     sourceText: source.text

devtools/client/debugger/new/webpack.config.js

@@ -28,7 +28,9 @@ const webpackConfig = {
   entry: {
     // We always generate the debugger bundle, but we will only copy the CSS
     // artifact over to mozilla-central.
-    debugger: getEntry(isProduction ? "src/main.js" : "src/main.development.js"),
+    debugger: getEntry(
+      isProduction ? "src/main.js" : "src/main.development.js"
+    ),
     "parser-worker": getEntry("src/workers/parser/worker.js"),
     "pretty-print-worker": getEntry("src/workers/pretty-print/worker.js"),
     "search-worker": getEntry("src/workers/search/worker.js"),