mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

Bug 1677401 - Part 3: Move alignas to JSAtom scope data. r=nbp 

Stencil's *Scope::Data doesn't contain pointer and doesn't have to be aligned
to pointer size.
This removed extra padding between scope data items in vector.

Differential Revision: https://phabricator.services.mozilla.com/D99746
This commit is contained in:
Tooru Fujisawa 2021-01-04 22:41:11 +00:00
Родитель ee3729bdd4
Коммит 143eb368df
1 изменённых файлов: 17 добавлений и 9 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

26
js/src/vm/Scope.h
Просмотреть файл

@ -218,7 +218,7 @@ const size_t ScopeDataAlignBytes = size_t(1) << gc::CellFlagBitsReservedForGC;
* suitably aligned to allow storing GC flags in the low bits. * suitably aligned to allow storing GC flags in the low bits.
*/ */
template <typename NameT> template <typename NameT>
class alignas(ScopeDataAlignBytes) AbstractBaseScopeData { class AbstractBaseScopeData {
public: public:
using NameType = NameT; using NameType = NameT;
}; };
@ -504,7 +504,8 @@ class LexicalScope : public Scope {
uint32_t length = 0; uint32_t length = 0;
}; };
struct Data : public AbstractBaseScopeData<JSAtom> { struct alignas(ScopeDataAlignBytes) Data
: public AbstractBaseScopeData<JSAtom> {
SlotInfo slotInfo; SlotInfo slotInfo;
AbstractTrailingNamesArray<JSAtom> trailingNames; AbstractTrailingNamesArray<JSAtom> trailingNames;
@ -634,7 +635,8 @@ class FunctionScope : public Scope {
uint32_t length = 0; uint32_t length = 0;
}; };
struct Data : public AbstractBaseScopeData<JSAtom> { struct alignas(ScopeDataAlignBytes) Data
: public AbstractBaseScopeData<JSAtom> {
// The canonical function of the scope, as during a scope walk we // The canonical function of the scope, as during a scope walk we
// often query properties of the JSFunction (e.g., is the function an // often query properties of the JSFunction (e.g., is the function an
// arrow). // arrow).
@ -734,7 +736,8 @@ class VarScope : public Scope {
uint32_t length = 0; uint32_t length = 0;
}; };
struct Data : public AbstractBaseScopeData<JSAtom> { struct alignas(ScopeDataAlignBytes) Data
: public AbstractBaseScopeData<JSAtom> {
SlotInfo slotInfo; SlotInfo slotInfo;
AbstractTrailingNamesArray<JSAtom> trailingNames; AbstractTrailingNamesArray<JSAtom> trailingNames;
@ -825,7 +828,8 @@ class GlobalScope : public Scope {
uint32_t length = 0; uint32_t length = 0;
}; };
struct Data : public AbstractBaseScopeData<JSAtom> { struct alignas(ScopeDataAlignBytes) Data
: public AbstractBaseScopeData<JSAtom> {
SlotInfo slotInfo; SlotInfo slotInfo;
AbstractTrailingNamesArray<JSAtom> trailingNames; AbstractTrailingNamesArray<JSAtom> trailingNames;
@ -932,7 +936,8 @@ class EvalScope : public Scope {
uint32_t length = 0; uint32_t length = 0;
}; };
struct Data : public AbstractBaseScopeData<JSAtom> { struct alignas(ScopeDataAlignBytes) Data
: public AbstractBaseScopeData<JSAtom> {
SlotInfo slotInfo; SlotInfo slotInfo;
AbstractTrailingNamesArray<JSAtom> trailingNames; AbstractTrailingNamesArray<JSAtom> trailingNames;
@ -1033,7 +1038,8 @@ class ModuleScope : public Scope {
uint32_t length = 0; uint32_t length = 0;
}; };
struct Data : public AbstractBaseScopeData<JSAtom> { struct alignas(ScopeDataAlignBytes) Data
: public AbstractBaseScopeData<JSAtom> {
// The module of the scope. // The module of the scope.
HeapPtr<ModuleObject*> module = {}; HeapPtr<ModuleObject*> module = {};
SlotInfo slotInfo; SlotInfo slotInfo;
@ -1109,7 +1115,8 @@ class WasmInstanceScope : public Scope {
uint32_t length = 0; uint32_t length = 0;
}; };
struct Data : public AbstractBaseScopeData<JSAtom> { struct alignas(ScopeDataAlignBytes) Data
: public AbstractBaseScopeData<JSAtom> {
// The wasm instance of the scope. // The wasm instance of the scope.
HeapPtr<WasmInstanceObject*> instance = {}; HeapPtr<WasmInstanceObject*> instance = {};
SlotInfo slotInfo; SlotInfo slotInfo;
@ -1174,7 +1181,8 @@ class WasmFunctionScope : public Scope {
uint32_t length = 0; uint32_t length = 0;
}; };
struct Data : public AbstractBaseScopeData<JSAtom> { struct alignas(ScopeDataAlignBytes) Data
: public AbstractBaseScopeData<JSAtom> {
SlotInfo slotInfo; SlotInfo slotInfo;
AbstractTrailingNamesArray<JSAtom> trailingNames; AbstractTrailingNamesArray<JSAtom> trailingNames;