mozilla
/
gecko-dev
зеркало из https://github.com/mozilla/gecko-dev.git
1
0
Форкнуть 0
Код Задачи Пакеты Проекты Релизы Вики Активность

Bug 1578265 - Remove security.ui.identitypopup event telemetry. r=nhnt11 

Differential Revision: https://phabricator.services.mozilla.com/D46752

--HG--
extra : moz-landing-system : lando
This commit is contained in:
Johann Hofmann 2019-09-23 12:26:03 +00:00
Родитель 0fe378d851
Коммит 1489dc82e4
7 изменённых файлов: 2 добавлений и 139 удалений
Показать статистику Скачать Patch файл Скачать Diff файл Показать все файлы Свернуть все файлы

14
browser/base/content/browser-siteIdentity.js
Просмотреть файл

@ -407,14 +407,6 @@ var gIdentityHandler = {
openPreferences("privacy-permissions");
},
recordClick(object) {
Services.telemetry.recordEvent(
"security.ui.identitypopup",
"click",
object
);
},
/**
* Handler for mouseclicks on the "More Information" button in the
* "identity-popup" panel.
@ -1240,12 +1232,6 @@ var gIdentityHandler = {
if (event.target == this._identityPopup) {
window.addEventListener("focus", this, true);
}
Services.telemetry.recordEvent(
"security.ui.identitypopup",
"open",
"identity_popup"
);
},
onPopupHidden(event) {

1
browser/base/content/test/siteIdentity/browser.ini
Просмотреть файл

@ -61,7 +61,6 @@ support-files =
skip-if = fission || (os == "linux" && bits == 64) # Bug 1577395
[browser_identityPopup_custom_roots.js]
[browser_identityPopup_focus.js]
[browser_identityPopup_telemetry.js]
[browser_insecureLoginForms.js]
support-files =
insecure_opener.html

22
browser/base/content/test/siteIdentity/browser_identityPopup_clearSiteData.js
Просмотреть файл

@ -18,15 +18,6 @@ ChromeUtils.defineModuleGetter(
"resource://testing-common/SiteDataTestUtils.jsm"
);
add_task(async function setup() {
let oldCanRecord = Services.telemetry.canRecordExtended;
Services.telemetry.canRecordExtended = true;
registerCleanupFunction(() => {
Services.telemetry.canRecordExtended = oldCanRecord;
});
});
async function testClearing(
testQuota,
testCookies,
@ -95,8 +86,6 @@ async function testClearing(
]);
}
Services.telemetry.clearEvents();
// Click the "Clear data" button.
let siteDataUpdated = TestUtils.topicObserved(
"sitedatamanager:sites-updated"
@ -113,17 +102,6 @@ async function testClearing(
await hideEvent;
await removeDialogPromise;
let events = Services.telemetry.snapshotEvents(
Ci.nsITelemetry.DATASET_PRERELEASE_CHANNELS
).parent;
let buttonEvents = events.filter(
e =>
e[1] == "security.ui.identitypopup" &&
e[2] == "click" &&
e[3] == "clear_sitedata"
);
is(buttonEvents.length, 1, "recorded telemetry for the button click");
await siteDataUpdated;
// Check that cookies were deleted.

43
browser/base/content/test/siteIdentity/browser_identityPopup_telemetry.js
Просмотреть файл

@ -1,43 +0,0 @@
/* Any copyright is dedicated to the Public Domain.
* http://creativecommons.org/publicdomain/zero/1.0/ */
const BENIGN_PAGE =
"http://tracking.example.org/browser/browser/base/content/test/trackingUI/benignPage.html";
/**
* Enable local telemetry recording for the duration of the tests.
*/
var oldCanRecord = Services.telemetry.canRecordExtended;
Services.telemetry.canRecordExtended = true;
registerCleanupFunction(function() {
Services.telemetry.canRecordExtended = oldCanRecord;
});
add_task(async function testIdentityPopupEvents() {
let tab = await BrowserTestUtils.openNewForegroundTab(gBrowser);
await promiseTabLoadEvent(tab, BENIGN_PAGE);
Services.telemetry.clearEvents();
let shown = BrowserTestUtils.waitForEvent(
gIdentityHandler._identityPopup,
"popupshown"
);
EventUtils.synthesizeMouseAtCenter(gIdentityHandler._identityBox, {});
await shown;
let events = Services.telemetry.snapshotEvents(
Ci.nsITelemetry.DATASET_PRERELEASE_CHANNELS,
true
).parent;
let openEvents = events.filter(
e =>
e[1] == "security.ui.identitypopup" &&
e[2] == "open" &&
e[3] == "identity_popup"
);
is(openEvents.length, 1, "recorded telemetry for opening the identity popup");
gBrowser.removeCurrentTab();
});

13
browser/components/BrowserGlue.jsm
Просмотреть файл

@ -1722,19 +1722,6 @@ BrowserGlue.prototype = {
},
_recordContentBlockingTelemetry() {
let recordIdentityPopupEvents = Services.prefs.prefHasUserValue(
"security.identitypopup.recordEventElemetry"
)
? Services.prefs.getBoolPref("security.identitypopup.recordEventElemetry")
: Services.prefs.getBoolPref(
"security.identitypopup.recordEventTelemetry"
);
Services.telemetry.setEventRecordingEnabled(
"security.ui.identitypopup",
recordIdentityPopupEvents
);
Services.telemetry.setEventRecordingEnabled(
"security.ui.protectionspopup",
Services.prefs.getBoolPref(

4
browser/components/controlcenter/content/identityPanel.inc.xul
Просмотреть файл

@ -58,7 +58,7 @@
<button id="identity-popup-security-expander"
class="identity-popup-expander"
when-connection="not-secure secure secure-ev secure-cert-user-overridden cert-error-page"
oncommand="gIdentityHandler.showSecuritySubView(); gIdentityHandler.recordClick('security_subview_btn');"/>
oncommand="gIdentityHandler.showSecuritySubView();"/>
</hbox>
<!-- Permissions Section -->
@ -83,7 +83,7 @@
class="panel-footer">
<button id="identity-popup-clear-sitedata-button"
label="&identity.clearSiteData;"
oncommand="gIdentityHandler.clearSiteData(event); gIdentityHandler.recordClick('clear_sitedata');"/>
oncommand="gIdentityHandler.clearSiteData(event);"/>
</vbox>
</panelview>

44
toolkit/components/telemetry/Events.yaml
Просмотреть файл

@ -1563,50 +1563,6 @@ security.ui.protections:
extra_keys:
category: The category of protections the user is in, standard, strict or custom.
security.ui.identitypopup:
open:
objects: ["identity_popup"]
bug_numbers:
- 1484251
- 1522256
- 1522919
- 1553181
- 1562575
description: >
How many times the control center was opened.
expiry_version: "72"
notification_emails:
- jhofmann@mozilla.com
- pdol@mozilla.com
- seceng-telemetry@mozilla.com
release_channel_collection: opt-in
record_in_processes:
- main
products:
- firefox
click:
objects: [
"permission_prefs_btn",
"clear_sitedata",
"security_subview_btn",
]
bug_numbers:
- 1484251
- 1553181
- 1562575
description: >
User interaction by click events in the identity popup.
expiry_version: "72"
notification_emails:
- jhofmann@mozilla.com
- pdol@mozilla.com
- seceng-telemetry@mozilla.com
release_channel_collection: opt-in
record_in_processes:
- main
products:
- firefox
security.ui.protectionspopup:
open:
objects: ["protections_popup"]