Bug 1738021 - Make sure to replace all dashes for Telemetry probes. r=Gijs

Differential Revision: https://phabricator.services.mozilla.com/D129678

browser/modules/BrowserUsageTelemetry.jsm

@@ -822,7 +822,7 @@ let BrowserUsageTelemetry = {
     let source = this._getWidgetContainer(node);
 
     if (item && source) {
-      let scalar = `browser.ui.interaction.${source.replace("-", "_")}`;
+      let scalar = `browser.ui.interaction.${source.replace(/-/g, "_")}`;
       Services.telemetry.keyedScalarAdd(scalar, telemetryId(item), 1);
       if (SET_USAGECOUNT_PREF_BUTTONS.includes(item)) {
         let pref = `browser.engagement.${item}.used-count`;